This task tracks https://github.com/facebook/hhvm/pull/5502 and is meant for discussion around how that bug affects the MobileFrontend and Gather projects.
Instances of the bug:
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Patch to uniqify filename of eval()'d code | operations/debs/hhvm | master | +508 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | phuedx | T101918 Mustache template rendering issues - leaking templates | |||
| Resolved | Jdlrobson | T104427 Remove template pre-compilation from Gather | |||
| Resolved | phuedx | T102937 [facebook/hhvm] Incorrect return value from eval, Closure generated in first eval pass is returned in the second eval pass #5502 | |||
| Resolved | Joe | T106483 Create new HHVM package for HHVM 3.6.5 + patches |
Event Timeline
Comment Actions
Change 219125 had a related patch set uploaded (by EBernhardson):
Patch to uniqify filename of eval()'d code
Comment Actions
After the patch is merged (presumably tomorrow), I'd still need to do the usual test dance: first on beta, then on the canaries, finally in full prod.
We could hope to deploy the package to beta tomorrow, and see it move to the canaries early next week.
Comment Actions
Change 219125 had a related patch set uploaded (by EBernhardson):
Patch to uniqify filename of eval()'d code
Comment Actions
I've submitted a patch (previously, just forgot to Bug: tag it) and now updated the patch to match what was accepted. Just need to poke @Joe to get it deployed.
Comment Actions
@EBernhardson Awesome thanks!
@phuedx I've created T104427 for removing our custom solution once this is finished.
Comment Actions
Sorry guys, I still didn't build the package including this patch. I'll do it today and start our rollout procedure.
Comment Actions
Change 219125 merged by Giuseppe Lavagetto:
Patch to uniqify filename of eval()'d code