Maniphest T103299

Graphoid tests fail
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• mobrovac
	Jun 22 2015, 9:50 AM

Tags

Referenced Files

None

Subscribers

Description

After updating to the latest version of Graphoid, the following tests are failing:

graphoid should get a PNG image from the Extension:Graph/Demo page without revision ID
graphoid should get a PNG image from the Extension:Graph/Demo page with the given revision ID
graphoid should fail to get a non-existent graph id
jshint should pass for working directory

This is worrisome because the same version is deployed in production.

Details

	Subject	Repo	Branch	Lines +/-
	Fixing unit test	mediawiki/services/graphoid	master	+8 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Joe	T94821 Set up monitoring automation for services
		Resolved		• mobrovac	T105774 Expose the monitoring spec for Graphoid
		Resolved		MoritzMuehlenhoff	T101870 Service containment for nodejs-based services with firejail
		Resolved		MoritzMuehlenhoff	T103095 Confine Graphoid with firejail
		Resolved		Yurik	T103299 Graphoid tests fail

Event Timeline

• mobrovac created this task.Jun 22 2015, 9:50 AM

• mobrovac assigned this task to Yurik.

• mobrovac raised the priority of this task from to High.

• mobrovac updated the task description. (Show Details)

• mobrovac added projects: Graphoid, Services.

• mobrovac subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2015, 9:50 AM

@Yurik, this needs to be fixed ASAP

• mobrovac added a parent task: T105774: Expose the monitoring spec for Graphoid.Jul 14 2015, 9:05 AM

• mobrovac added a parent task: T103095: Confine Graphoid with firejail.Jul 16 2015, 11:45 AM

Change 225266 had a related patch set uploaded (by Agx):
Fixing unity test

https://gerrit.wikimedia.org/r/225266

gerritbot added a project: Patch-For-Review.Jul 16 2015, 11:39 PM

Change 225266 merged by Yurik:
Fixing unit test

https://gerrit.wikimedia.org/r/225266

Yurik closed this task as Resolved.Jul 16 2015, 11:49 PM

jonas.agx mentioned this in rGGRA6998cec598e1: Fixing unit test.Jul 17 2015, 1:25 AM

Restricted Application added subscribers: TerraCodes, Urbanecm. · View Herald TranscriptMay 16 2016, 5:27 AM

SamanthaNguyen removed a project: Patch-For-Review.Jan 14 2017, 2:40 AM

Restricted Application added a subscriber: Jay8g. · View Herald TranscriptJan 14 2017, 2:40 AM