Maniphest T103569

Flashing content on manipulating TOC
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sumit
	Jun 23 2015, 5:52 PM

Tags

Referenced Files

None

Subscribers

Description

The toc manipulation by https://gerrit.wikimedia.org/r/218672 with purpose of adding it to banner, leaves a moment of flashing content, which needs to be fixed

Details

	Subject	Repo	Branch	Lines +/-
	WikidataPageBanner hook changes and serverside toc	mediawiki/extensions/WikidataPageBanner	master	+154 -141

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Sumit	T77925 Wikidata PageBanner extension
		Duplicate		Sumit	T93106 GSoC proposal for Wikivoyage PageBanner extension
		Resolved		Jdlrobson	T104461 Check banners on Monobook skin
		Resolved		Sumit	T97839 drop-down TOC for wikivoyage banners
		Resolved		Sumit	T103569 Flashing content on manipulating TOC

Event Timeline

Sumit created this task.Jun 23 2015, 5:52 PM

Sumit claimed this task.

Sumit raised the priority of this task from to Medium.

Sumit updated the task description. (Show Details)

Sumit added a project: Wikidata-Page-Banner.

Sumit added subscribers: Sumit, Nicolas_Raoul, Aklapper and 2 others.

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 23 2015, 5:52 PM

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Jun 24 2015, 10:25 AM

Sumit moved this task from In discussion to June 26-July 18 on the Wikidata-Page-Banner board.Jun 24 2015, 2:42 PM

Best thing to do is to hide it by default .client-js #toc { display: none; } in the styles at the top.

Change 221459 had a related patch set uploaded (by Sumit):
WikidataPageBanner hook changes and serverside toc

https://gerrit.wikimedia.org/r/221459

gerritbot added a project: Patch-For-Review.Jun 29 2015, 3:27 PM

Jdlrobson moved this task from June 26-July 18 to June 16-June 25 on the Wikidata-Page-Banner board.Jul 1 2015, 4:14 PM

Sumit mentioned this in T104460: Add tests for icons options for the PAGEBANNER function.Jul 1 2015, 5:27 PM

Change 221459 merged by jenkins-bot:
WikidataPageBanner hook changes and serverside toc

https://gerrit.wikimedia.org/r/221459

Sumit mentioned this in rMEXT9ef8373ac768: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Jul 16 2015, 10:32 AM

Sumit mentioned this in rEWDP95ee5aa6647a: WikidataPageBanner hook changes and serverside toc.

Sumit closed this task as Resolved.Jul 16 2015, 12:28 PM

Sumit set Security to None.