Page MenuHomePhabricator
Create Task
Maniphest T103970

Replace some Linker::linkKnown usages with LinkRenderer
Closed, ResolvedPublic
Actions

Description

The Linker::linkKnown() function is deprecated as of 1.28, and the new LinkRenderer is preferred instead. This task is to migrate extensions to use the new code instead of the deprecated function.

Details

SubjectRepoBranchLines +/-
Replace some Linker::linkKnown usages with LinkRenderermediawiki/extensions/NewestPagesmaster+6 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Jun 26 2015, 9:58 AM
Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-extensions-NewestPages, Technical-Debt.
Krinkle subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2015, 9:58 AM
MtDu subscribed.Jan 17 2016, 1:44 PM

@Krinkle
Does not seem like this is a problem anymore. This is what I see under the makeListItem function. https://dpaste.de/Vpuu No instances if Linker::makeKnownLinkObj. Only Linker::linkKnown, which appears to still be in use. Correct me if I'm wrong.
Thanks,
MtDu

Jayprakash12345 renamed this task from [deprecated] Use of Linker::makeKnownLinkObj was deprecated. [Called from NewestPages::makeListItem] to Replace some Linker::linkKnown usages with LinkRenderer.Jul 27 2018, 12:48 PM
Jayprakash12345 claimed this task.
Jayprakash12345 updated the task description. (Show Details)
Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptJul 27 2018, 12:48 PM
gerritbot subscribed.Jul 27 2018, 12:56 PM

Change 448509 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/NewestPages@master] Replace some Linker::linkKnown usages with LinkRenderer

https://gerrit.wikimedia.org/r/448509

gerritbot added a project: Patch-For-Review.Jul 27 2018, 12:56 PM
Jayprakash12345 moved this task from Backlog to In Review on the MediaWiki-extensions-NewestPages board.Jul 27 2018, 12:56 PM
Jayprakash12345 moved this task from Backlog to Configured on the User-Jayprakash12345 board.
matej_suchanek added a parent task: T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.Aug 1 2018, 7:06 AM
gerritbot added a comment.Feb 3 2019, 1:23 PM

Change 448509 merged by jenkins-bot:
[mediawiki/extensions/NewestPages@master] Replace some Linker::linkKnown usages with LinkRenderer

https://gerrit.wikimedia.org/r/448509

Jayprakash12345 closed this task as Resolved.Feb 3 2019, 1:43 PM
Jayprakash12345 lowered the priority of this task from High to Medium.
Jayprakash12345 removed a project: Patch-For-Review.
Jayprakash12345 removed a subscriber: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits