Page MenuHomePhabricator

Replace Linker::link() usage with LinkRenderer in MediaWiki extensions
Open, Needs TriagePublic

Description

(This task is a parent task for extensions. For Core see T223010. For Skins see these tasks.)

Linker::link() and Linker::linkKnown() functions are deprecated as of MediaWiki 1.28, and the new LinkRenderer is preferred instead.

See the list of dedicated subtasks below for extension codebases which have a dedicated project tag (T279325-T279339are WMF-deployed extensions).

List of remaining extension codebases which do not have a dedicated project tag (hence that's MediaWiki-extensions-Other), per 2021-04-05:

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/GlobalUserrightsmaster+2 -1
mediawiki/extensions/EditSimilarmaster+4 -1
mediawiki/extensions/OAuthmaster+79 -68
mediawiki/extensions/FlaggedRevsmaster+18 -15
mediawiki/extensions/LastUserLoginmaster+5 -3
mediawiki/coremaster+103 -64
mediawiki/extensions/ApprovedRevsmaster+1 -1
mediawiki/extensions/GlobalBlockingmaster+34 -28
mediawiki/extensions/TranslationNotificationsmaster+2 -2
mediawiki/coremaster+43 -50
mediawiki/coremaster+22 -21
mediawiki/coremaster+15 -11
mediawiki/extensions/CentralNoticemaster+21 -19
mediawiki/extensions/Flowmaster+36 -21
mediawiki/extensions/Echomaster+2 -2
mediawiki/extensions/VoteNYmaster+4 -1
mediawiki/extensions/CentralNoticemaster+24 -21
mediawiki/extensions/Interwikimaster+20 -10
mediawiki/extensions/UserPageViewTrackermaster+7 -4
mediawiki/extensions/ReplaceTextmaster+31 -8
mediawiki/extensions/TitleIconmaster+35 -36
mediawiki/extensions/CommentStreamsmaster+10 -2
mediawiki/extensions/Renameusermaster+19 -20
mediawiki/extensions/CheckUsermaster+12 -10
mediawiki/coremaster+14 -22
mediawiki/extensions/BlueSpiceExtensionsmaster+4 -1
mediawiki/extensions/FlaggedRevsmaster+52 -37
mediawiki/extensions/ArticleFeedbackv5master+6 -3
mediawiki/extensions/Translatemaster+80 -16
mediawiki/coremaster+9 -5
mediawiki/coremaster+3 -3
mediawiki/coremaster+4 -1
mediawiki/extensions/ArticleFeedbackmaster+3 -3
mediawiki/coremaster+27 -34
mediawiki/extensions/WikimediaIncubatormaster+19 -15
mediawiki/extensions/Gadgetsmaster+12 -7
mediawiki/extensions/Wikibasemaster+20 -21
mediawiki/extensions/PollNYmaster+12 -9
mediawiki/extensions/Disambiguatormaster+10 -7
mediawiki/extensions/Nukemaster+19 -18
mediawiki/extensions/GlobalUsagemaster+17 -12
mediawiki/extensions/CentralAuthmaster+19 -17
mediawiki/extensions/EducationProgrammaster+18 -18
mediawiki/coremaster+81 -59
mediawiki/extensions/ArticleFeedbackv5master+40 -25
mediawiki/extensions/ApprovedRevsmaster+23 -20
mediawiki/extensions/CheckUsermaster+18 -19
mediawiki/extensions/ArticleRatingsmaster+2 -2
mediawiki/extensions/CleanChangesmaster+21 -11
mediawiki/extensions/UserMergemaster+5 -2
mediawiki/extensions/LiquidThreadsmaster+2 -1
mediawiki/extensions/VisualEditormaster+7 -3
mediawiki/extensions/LiquidThreadsmaster+113 -54
mediawiki/extensions/CodeReviewmaster+56 -40
mediawiki/extensions/SocialProfilemaster+45 -26
mediawiki/extensions/GWToolsetmaster+23 -18
mediawiki/extensions/QuizGamemaster+13 -12
mediawiki/extensions/DPLforummaster+12 -10
mediawiki/extensions/MobileFrontendmaster+18 -8
mediawiki/extensions/ArticleFeedbackv5master+40 -25
mediawiki/extensions/BibManagermaster+18 -15
mediawiki/extensions/BibManagermaster+20 -15
mediawiki/extensions/ArticleFeedbackv5master+36 -24
mediawiki/extensions/BlockAndNukemaster+4 -3
mediawiki/extensions/LifeWebmaster+18 -3
mediawiki/extensions/BlogPagemaster+11 -3
mediawiki/extensions/BreadCrumbsmaster+5 -2
mediawiki/extensions/ArticleFeedbackmaster+9 -3
mediawiki/extensions/Newslettermaster+39 -28
mediawiki/extensions/SmiteSpammaster+12 -8
mediawiki/coremaster+51 -30
mediawiki/extensions/AbuseFiltermaster+3 -2
mediawiki/extensions/AbuseFiltermaster+92 -55
mediawiki/coremaster+33 -23
mediawiki/coremaster+55 -51
mediawiki/coremaster+24 -27
mediawiki/extensions/Flowmaster+12 -12
mediawiki/coremaster+28 -21
mediawiki/coremaster+28 -17
mediawiki/coremaster+63 -46
mediawiki/coremaster+30 -14
mediawiki/coremaster+37 -30
mediawiki/coremaster+49 -33
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedFlorian
ResolvedNone
ResolvedJayprakash12345
ResolvedPalak199
OpenPalak199
OpenPalak199
ResolvedMholloway
OpenNone
OpenPalak199
OpenNone
OpenPalak199
ResolvedSahilgrewalhere
OpenNone
OpenNone
OpenNone
OpenNikerabbit
ResolvedAnjali_Kumari_41
OpenNone
Resolvedashley
ResolvedPwirth
ResolvedSahilgrewalhere
ResolvedSahilgrewalhere
OpenNone
OpenNone
OpenNone
DeclinedNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedSahilgrewalhere
Resolvedashley
Resolvedashley
ResolvedSahilgrewalhere
Resolvedashley
OpenNone
DeclinedNone
OpenNone
ResolvedYaron_Koren
ResolvedAnjali_Kumari_41
OpenNone
OpenNone
OpenNone
Resolvedashley
OpenNone
OpenNone
OpenNone
DeclinedNone
OpenNone
Resolvedashley
Resolvedashley
OpenNone
Resolvedashley
OpenNone

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 409377 merged by jenkins-bot:
[mediawiki/extensions/Renameuser@master] Use LinkRenderer instead of Linker

https://gerrit.wikimedia.org/r/409377

Change 423521 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/CentralNotice@master] Replace some Linker::link() usages with LinkRenderer

https://gerrit.wikimedia.org/r/423521

Change 426157 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/CommentStreams@master] Replaced Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/426157

Change 426157 merged by jenkins-bot:
[mediawiki/extensions/CommentStreams@master] Replaced Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/426157

Change 426238 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/TitleIcon@master] Replaced Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/426238

Change 426238 merged by jenkins-bot:
[mediawiki/extensions/TitleIcon@master] Replaced Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/426238

Change 426321 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/extensions/ReplaceText@master] Replaced Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/426321

Change 426321 merged by jenkins-bot:
[mediawiki/extensions/ReplaceText@master] Replaced Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/426321

Change 423524 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/Interwiki@master] Replace Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/423524

Change 439473 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/VoteNY@master] Replace some Linker::link() usages with LinkRenderer

https://gerrit.wikimedia.org/r/439473

Change 439480 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/UserPageViewTracker@master] Replace some Linker::link() usages with LinkRenderer

https://gerrit.wikimedia.org/r/439480

Change 423524 merged by jenkins-bot:
[mediawiki/extensions/Interwiki@master] Replace Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/423524

Change 336010 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/336010

Change 439473 merged by jenkins-bot:
[mediawiki/extensions/VoteNY@master] Replace some Linker::link() usages with LinkRenderer

https://gerrit.wikimedia.org/r/439473

Change 452571 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Echo@master] Replace deprecated Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/452571

Change 452571 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Replace deprecated Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/452571

Change 452726 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/Flow@master] Replace deprecated Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/452726

Change 452726 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace deprecated Linker::link() with LinkRenderer

https://gerrit.wikimedia.org/r/452726

Change 423521 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Replace some Linker::link() usages with LinkRenderer

https://gerrit.wikimedia.org/r/423521

Change 463823 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Replace Linker::linkKnown() with LinkRenderer in DifferenceEngine.php

https://gerrit.wikimedia.org/r/463823

Change 463825 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Replace Linker::link() usage with LinkRenderer in includes/page

https://gerrit.wikimedia.org/r/463825

Change 463823 abandoned by Urbanecm:
Replace Linker::linkKnown() with LinkRenderer in DifferenceEngine.php

https://gerrit.wikimedia.org/r/463823

Change 463825 abandoned by Urbanecm:
Replace Linker::link() usage with LinkRenderer in includes/page

https://gerrit.wikimedia.org/r/463825

Change 521466 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] Clean up LinkRenderer usage in IndexPager and extensions

https://gerrit.wikimedia.org/r/521466

Change 521466 merged by jenkins-bot:
[mediawiki/core@master] Clean up LinkRenderer usage in IndexPager and extensions

https://gerrit.wikimedia.org/r/521466

Change 534901 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/core@master] Replace Link::link usage with LinkRenderer in includes

https://gerrit.wikimedia.org/r/534901

Change 534949 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/FlaggedRevs@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534949

Change 534950 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/GlobalBlocking@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534950

Change 534951 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/OAuth@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534951

Change 534952 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/TranslationNotifications@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534952

Change 534952 merged by jenkins-bot:
[mediawiki/extensions/TranslationNotifications@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534952

Change 534950 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534950

Change 326384 had a related patch set uploaded (by Matěj Suchánek; owner: MtDu):
[mediawiki/extensions/ApprovedRevs@master] Replace Linker::link*() usage with LinkRenderer

https://gerrit.wikimedia.org/r/326384

Change 326384 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Replace Linker::link*() usage with LinkRenderer

https://gerrit.wikimedia.org/r/326384

Change 534901 merged by jenkins-bot:
[mediawiki/core@master] Replace Linker::link usage with LinkRenderer in includes

https://gerrit.wikimedia.org/r/534901

Change 663717 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/LastUserLogin@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/663717

Change 663717 merged by jenkins-bot:
[mediawiki/extensions/LastUserLogin@master] Replace Linker::link usage and manual link construction with LinkRenderer

https://gerrit.wikimedia.org/r/663717

Change 534949 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534949

Change 534951 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534951

Aklapper renamed this task from Replace Linker::link() usage with LinkRenderer in XX extension (clonable) to Replace Linker::link() usage with LinkRenderer in MediaWiki extensions.Apr 5 2021, 5:44 PM

Only open patch (not merged or abandoned) is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserPageViewTracker/+/439480 which needs input.

Change 678269 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/GlobalUserrights@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678269

Change 678270 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/EditSimilar@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678270

hi @Legoktm
In the description, I saw this link https://www.mediawiki.org/wiki/Manual:LinkRenderer for documentation, but unfortunately the page doesn't exist. Would you please let me know where can I find its documentation, I was trying to replace the occurances but as I am not able to find the documentation, several iterations of patches need to there. Thanks :)

hi @Legoktm
In the description, I saw this link https://www.mediawiki.org/wiki/Manual:LinkRenderer for documentation, but unfortunately the page doesn't exist. Would you please let me know where can I find its documentation, I was trying to replace the occurances but as I am not able to find the documentation, several iterations of patches need to there. Thanks :)

It's not the most obvious, but it is on the page in the red box

https://www.mediawiki.org/wiki/Manual:LinkRenderer.php

Change 678270 merged by jenkins-bot:

[mediawiki/extensions/EditSimilar@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678270

Change 678269 merged by jenkins-bot:

[mediawiki/extensions/GlobalUserrights@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678269