Page MenuHomePhabricator

Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions
Open, Needs TriagePublic

Description

(This task is a parent task for extensions. For Core see T223010. For Skins see these tasks.)

Linker::link() and Linker::linkKnown() functions are deprecated as of MediaWiki 1.28, and the new LinkRenderer is preferred instead.

See the list of dedicated subtasks below for extension codebases which have a dedicated project tag (T279325-T279339are WMF-deployed extensions).

List of remaining extension codebases which do not have a dedicated project tag (hence that's MediaWiki-extensions-Other), updated at 2022-07-15:

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/CreatePageUwmaster+2 -3
mediawiki/extensions/Favoritesmaster+39 -42
mediawiki/extensions/CreatedPagesListmaster+5 -1
mediawiki/extensions/AjaxShowEditorsmaster+6 -2
mediawiki/extensions/ContributionsListmaster+4 -2
mediawiki/extensions/CloneDiffmaster+3 -3
mediawiki/extensions/GoogleAnalyticsTopPagesmaster+7 -2
mediawiki/extensions/GlobalUserrightsmaster+2 -1
mediawiki/extensions/EditSimilarmaster+4 -1
mediawiki/extensions/OAuthmaster+79 -68
mediawiki/extensions/FlaggedRevsmaster+18 -15
mediawiki/extensions/LastUserLoginmaster+5 -3
mediawiki/coremaster+103 -64
mediawiki/extensions/ApprovedRevsmaster+1 -1
mediawiki/extensions/GlobalBlockingmaster+34 -28
mediawiki/extensions/TranslationNotificationsmaster+2 -2
mediawiki/coremaster+43 -50
mediawiki/coremaster+22 -21
mediawiki/coremaster+15 -11
mediawiki/extensions/CentralNoticemaster+21 -19
mediawiki/extensions/Flowmaster+36 -21
mediawiki/extensions/Echomaster+2 -2
mediawiki/extensions/VoteNYmaster+4 -1
mediawiki/extensions/CentralNoticemaster+24 -21
mediawiki/extensions/Interwikimaster+20 -10
mediawiki/extensions/UserPageViewTrackermaster+7 -4
mediawiki/extensions/ReplaceTextmaster+31 -8
mediawiki/extensions/TitleIconmaster+35 -36
mediawiki/extensions/CommentStreamsmaster+10 -2
mediawiki/extensions/Renameusermaster+19 -20
mediawiki/extensions/CheckUsermaster+12 -10
mediawiki/coremaster+14 -22
mediawiki/extensions/BlueSpiceExtensionsmaster+4 -1
mediawiki/extensions/FlaggedRevsmaster+52 -37
mediawiki/extensions/ArticleFeedbackv5master+6 -3
mediawiki/extensions/Translatemaster+80 -16
mediawiki/coremaster+9 -5
mediawiki/coremaster+3 -3
mediawiki/coremaster+4 -1
mediawiki/extensions/ArticleFeedbackmaster+3 -3
mediawiki/coremaster+27 -34
mediawiki/extensions/WikimediaIncubatormaster+19 -15
mediawiki/extensions/Gadgetsmaster+12 -7
mediawiki/extensions/Wikibasemaster+20 -21
mediawiki/extensions/PollNYmaster+12 -9
mediawiki/extensions/Disambiguatormaster+10 -7
mediawiki/extensions/Nukemaster+19 -18
mediawiki/extensions/GlobalUsagemaster+17 -12
mediawiki/extensions/CentralAuthmaster+19 -17
mediawiki/extensions/EducationProgrammaster+18 -18
mediawiki/coremaster+81 -59
mediawiki/extensions/ArticleFeedbackv5master+40 -25
mediawiki/extensions/ApprovedRevsmaster+23 -20
mediawiki/extensions/CheckUsermaster+18 -19
mediawiki/extensions/ArticleRatingsmaster+2 -2
mediawiki/extensions/CleanChangesmaster+21 -11
mediawiki/extensions/UserMergemaster+5 -2
mediawiki/extensions/LiquidThreadsmaster+2 -1
mediawiki/extensions/VisualEditormaster+7 -3
mediawiki/extensions/LiquidThreadsmaster+113 -54
mediawiki/extensions/CodeReviewmaster+56 -40
mediawiki/extensions/SocialProfilemaster+45 -26
mediawiki/extensions/GWToolsetmaster+23 -18
mediawiki/extensions/QuizGamemaster+13 -12
mediawiki/extensions/DPLforummaster+12 -10
mediawiki/extensions/MobileFrontendmaster+18 -8
mediawiki/extensions/ArticleFeedbackv5master+40 -25
mediawiki/extensions/BibManagermaster+18 -15
mediawiki/extensions/BibManagermaster+20 -15
mediawiki/extensions/ArticleFeedbackv5master+36 -24
mediawiki/extensions/BlockAndNukemaster+4 -3
mediawiki/extensions/LifeWebmaster+18 -3
mediawiki/extensions/BlogPagemaster+11 -3
mediawiki/extensions/BreadCrumbsmaster+5 -2
mediawiki/extensions/ArticleFeedbackmaster+9 -3
mediawiki/extensions/Newslettermaster+39 -28
mediawiki/extensions/SmiteSpammaster+12 -8
mediawiki/coremaster+51 -30
mediawiki/extensions/AbuseFiltermaster+3 -2
mediawiki/extensions/AbuseFiltermaster+92 -55
mediawiki/coremaster+33 -23
mediawiki/coremaster+55 -51
mediawiki/coremaster+24 -27
mediawiki/extensions/Flowmaster+12 -12
mediawiki/coremaster+28 -21
mediawiki/coremaster+28 -17
mediawiki/coremaster+63 -46
mediawiki/coremaster+30 -14
mediawiki/coremaster+37 -30
mediawiki/coremaster+49 -33
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedFlorian
ResolvedNone
ResolvedJayprakash12345
ResolvedPalak199
ResolvedPalak199
OpenNone
Resolved Mholloway
ResolvedSahilgrewalhere
ResolvedPalak199
ResolvedSouthparkfan
ResolvedPalak199
ResolvedSahilgrewalhere
ResolvedSouthparkfan
ResolvedSouthparkfan
ResolvedSouthparkfan
ResolvedNikerabbit
ResolvedAnjali_Kumari_41
Resolvedjhsoby
Resolvedashley
ResolvedPwirth
ResolvedSahilgrewalhere
ResolvedSahilgrewalhere
ResolvedSahilgrewalhere
DeclinedNone
ResolvedSouthparkfan
DeclinedNone
ResolvedSouthparkfan
ResolvedSouthparkfan
ResolvedSouthparkfan
ResolvedSouthparkfan
ResolvedSahilgrewalhere
Resolvedashley
Resolvedashley
ResolvedSahilgrewalhere
Resolvedashley
ResolvedSouthparkfan
DeclinedNone
ResolvedSouthparkfan
ResolvedYaron_Koren
ResolvedAnjali_Kumari_41
OpenRussRogovetz
ResolvedSahilgrewalhere
ResolvedSouthparkfan
Resolvedashley
ResolvedSouthparkfan
ResolvedSouthparkfan
ResolvedSouthparkfan
DeclinedNone
ResolvedSouthparkfan
Resolvedashley
Resolvedashley
ResolvedSouthparkfan
Resolvedashley
ResolvedSouthparkfan

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 534951 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Replace Linker::link usage with LinkRenderer

https://gerrit.wikimedia.org/r/534951

Aklapper renamed this task from Replace Linker::link() usage with LinkRenderer in XX extension (clonable) to Replace Linker::link() usage with LinkRenderer in MediaWiki extensions.Apr 5 2021, 5:44 PM

Only open patch (not merged or abandoned) is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserPageViewTracker/+/439480 which needs input.

Change 678269 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/GlobalUserrights@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678269

Change 678270 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/EditSimilar@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678270

hi @Legoktm
In the description, I saw this link https://www.mediawiki.org/wiki/Manual:LinkRenderer for documentation, but unfortunately the page doesn't exist. Would you please let me know where can I find its documentation, I was trying to replace the occurances but as I am not able to find the documentation, several iterations of patches need to there. Thanks :)

hi @Legoktm
In the description, I saw this link https://www.mediawiki.org/wiki/Manual:LinkRenderer for documentation, but unfortunately the page doesn't exist. Would you please let me know where can I find its documentation, I was trying to replace the occurances but as I am not able to find the documentation, several iterations of patches need to there. Thanks :)

It's not the most obvious, but it is on the page in the red box

Screenshot 2021-04-14 at 15.12.01.png (204×2 px, 80 KB)

https://www.mediawiki.org/wiki/Manual:LinkRenderer.php

Change 678270 merged by jenkins-bot:

[mediawiki/extensions/EditSimilar@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678270

Change 678269 merged by jenkins-bot:

[mediawiki/extensions/GlobalUserrights@master] Linker -> LinkRenderer

https://gerrit.wikimedia.org/r/678269

Southparkfan renamed this task from Replace Linker::link() usage with LinkRenderer in MediaWiki extensions to Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.Jul 10 2022, 11:35 PM
Southparkfan updated the task description. (Show Details)

Change 814260 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/CloneDiff@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814260

Change 814261 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/CreatePageUw@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814261

Change 814262 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/CreatedPagesList@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814262

Change 814263 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/ContributionsList@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814263

Change 814264 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/AjaxShowEditors@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814264

Change 814268 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/Favorites@master] Replace Linker::link() and linkKnown() with LinkRenderer

https://gerrit.wikimedia.org/r/814268

Change 814269 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[mediawiki/extensions/GoogleAnalyticsTopPages@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814269

Change 814269 merged by jenkins-bot:

[mediawiki/extensions/GoogleAnalyticsTopPages@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814269

Change 814260 merged by jenkins-bot:

[mediawiki/extensions/CloneDiff@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814260

Change 814263 merged by jenkins-bot:

[mediawiki/extensions/ContributionsList@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814263

Change 814264 merged by jenkins-bot:

[mediawiki/extensions/AjaxShowEditors@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814264

Change 814262 merged by jenkins-bot:

[mediawiki/extensions/CreatedPagesList@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814262

Change 814268 merged by Umherirrender:

[mediawiki/extensions/Favorites@master] Replace Linker::link() and linkKnown() with LinkRenderer

https://gerrit.wikimedia.org/r/814268

Change 814261 merged by jenkins-bot:

[mediawiki/extensions/CreatePageUw@master] Replace Linker with LinkRenderer

https://gerrit.wikimedia.org/r/814261