Page MenuHomePhabricator

extensions/Gadgets - file permissions trigger debian lintian warnings
Closed, ResolvedPublic

Description

0. Context

DEB packages of mediawiki and many of its extensions, are prepared as part of the WP-MIRROR project.
See https://www.mediawiki.org/wiki/Wp-mirror.

  1. Lintian

During the build process, lintian performs a great number of sanity checks, including seeing if each file has file permissions appropriate to its file type.

When lintian sees a non-executable file with 755 permissions, rather than 644, lintian will throw a warning like:

W: wp-mirror-mediawiki: executable-not-elf-or-script usr/share/wp-mirror-mediawiki/extensions/Gadgets/GadgetHooks.php

  1. Files which should have permissions set to 644

Gadgets/GadgetHooks.php
Gadgets/Gadgets_body.php
Gadgets/tests/GadgetTest.php

  1. Technical details

DEB standards version: 3.9.6
GIT branch: master

Event Timeline

wpmirrordev updated the task description. (Show Details)
wpmirrordev raised the priority of this task from to Normal.
wpmirrordev assigned this task to daniel.
wpmirrordev added a subscriber: wpmirrordev.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2015, 1:20 AM
Legoktm removed daniel as the assignee of this task.Jun 27 2015, 3:47 AM
Legoktm set Security to None.

It says the file already has 644 not 755.

(shell) cd Gadgets/
(shell) git pull
Already up-to-date
(shell) git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
(shell) ls -l *php
-rwxr-xr-x 1 foo foo 6107 Jun 26 17:15 GadgetHooks.php
-rw-r--r-- 1 foo foo 8585 Jun 26 17:15 Gadgets.alias.php
-rwxr-xr-x 1 foo foo 13849 Jun 26 17:15 Gadgets_body.php
-rw-r--r-- 1 foo foo 570 Jun 26 17:15 Gadgets.php
-rw-r--r-- 1 foo foo 5588 Jun 26 17:15 SpecialGadgets.php
(shell) ls -l tests/
-rwxr-xr-x 1 foo foo 2404 Jun 26 17:15 GadgetTest.php

Change 221386 had a related patch set uploaded (by Alex Monk):
Set 644 file permissions on .php files

https://gerrit.wikimedia.org/r/221386

Krenair claimed this task.Jun 27 2015, 5:52 PM
Jdforrester-WMF closed this task as Resolved.Jun 27 2015, 6:51 PM

Change 221386 merged by jenkins-bot:
Set 644 file permissions on .php files

https://gerrit.wikimedia.org/r/221386

I confirm that the above mentioned debian lintian warnings are cured.
Thanks.