Page MenuHomePhabricator
Create Task
Maniphest T104058

ContentTranslation uses deprecated $.isEmpty
Closed, ResolvedPublic
Actions

Description

$.isEmpty was added in https://gerrit.wikimedia.org/r/#/c/158369/ and I'm not sure what is it even supposed to do. It's likely that it's supposed to be removed, or maybe replaced with a different check.

Details

SubjectRepoBranchLines +/-
Remove $.isEmpty check from the formatter toolmediawiki/extensions/ContentTranslationwmf/1.26wmf11+1 -3
Remove $.isEmpty check from the formatter toolmediawiki/extensions/ContentTranslationmaster+1 -3
Customize query in gerrit

Related Objects

Event Timeline

Amire80 created this task.Jun 27 2015, 10:36 AM
Amire80 raised the priority of this task from to Medium.
Amire80 updated the task description. (Show Details)
Amire80 added projects: ContentTranslation, Technical-Debt.
Amire80 subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2015, 10:36 AM
gerritbot subscribed.Jun 27 2015, 10:43 AM

Change 221365 had a related patch set uploaded (by Amire80):
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221365

gerritbot added a project: Patch-For-Review.Jun 27 2015, 10:43 AM
santhosh subscribed.Jun 29 2015, 11:12 AM

$.isEmpty is defined in jquery.mwExtension. This module is still in the core, but it's deprecated, and no core modules load it any longer since June 20.
So this function doesn't exist. It works only if by chance this module is loaded is some other way. Some wikis added it, because they have gadgets that depend on it.

gerritbot added a comment.Jun 29 2015, 11:13 AM

Change 221365 merged by jenkins-bot:
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221365

Amire80 mentioned this in rECTXc6b992c5fd64: Remove $.isEmpty check from the formatter tool.Jun 29 2015, 11:13 AM
Diffusion mentioned this in rMEXT94f8704df425: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Jun 29 2015, 11:13 AM
gerritbot added a comment.Jun 29 2015, 12:09 PM

Change 221604 had a related patch set uploaded (by KartikMistry):
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221604

gerritbot added a comment.Jun 29 2015, 12:13 PM

Change 221604 merged by jenkins-bot:
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221604

KartikMistry mentioned this in rECTX148699770c14: Remove $.isEmpty check from the formatter tool.Jun 29 2015, 12:13 PM
Amire80 mentioned this in rMWe87975128ae7: Updated mediawiki/core Project: mediawiki/extensions/ContentTranslation….Jun 29 2015, 12:13 PM
• Forrestbot added projects: WMF-deploy-2015-06-30_(1.26wmf12), WMF-deploy-2015-06-23_(1.26wmf11).Jun 29 2015, 7:16 PM
Nikerabbit closed this task as Resolved.Jul 2 2015, 7:19 AM
Nikerabbit claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits