Page MenuHomePhabricator

ContentTranslation uses deprecated $.isEmpty
Closed, ResolvedPublic

Description

$.isEmpty was added in https://gerrit.wikimedia.org/r/#/c/158369/ and I'm not sure what is it even supposed to do. It's likely that it's supposed to be removed, or maybe replaced with a different check.

Event Timeline

Amire80 created this task.Jun 27 2015, 10:36 AM
Amire80 updated the task description. (Show Details)
Amire80 raised the priority of this task from to Normal.
Amire80 added a subscriber: Amire80.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2015, 10:36 AM

Change 221365 had a related patch set uploaded (by Amire80):
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221365

$.isEmpty is defined in jquery.mwExtension. This module is still in the core, but it's deprecated, and no core modules load it any longer since June 20.
So this function doesn't exist. It works only if by chance this module is loaded is some other way. Some wikis added it, because they have gadgets that depend on it.

Change 221365 merged by jenkins-bot:
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221365

Change 221604 had a related patch set uploaded (by KartikMistry):
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221604

Change 221604 merged by jenkins-bot:
Remove $.isEmpty check from the formatter tool

https://gerrit.wikimedia.org/r/221604

Nikerabbit closed this task as Resolved.Jul 2 2015, 7:19 AM
Nikerabbit claimed this task.