| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| QA: Add browser test for changing a collection name | mediawiki/extensions/Gather | master | +33 -4 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • rmoen | T104025 When saving collection settings and then clicking the back icon, page should refresh. | |||
| Resolved | • rmoen | T104720 Add browser tests for changing the name of a collection |
Event Timeline
Comment Actions
Change 222479 had a related patch set uploaded (by Jdlrobson):
Add browser test for changing a collection name
Comment Actions
My mistake.. so yeh there is a constraint that Yuri built it annoyingly that means your collection name has to be unique (which I always thought was annoying).
We can delete the collection after creating it but that's no good if the test fails as the collection will never get removed.
The alternative would be to give the collection a random name, store it and then test against that..
@dduvall is there a way to do a tear down after running all Gather tests or a specific test?
Comment Actions
@rmoen I made your test simply add " cool" to the end of the name. With the preceding patch the name will be random and a fresh collection so in theory unique so your name will always save.
I've +1ed it but someone other than the 2 of us should press the +2 trigger.
Comment Actions
Change 222479 had a related patch set uploaded (by Phuedx):
QA: Add browser test for changing a collection name
Comment Actions
I merged the second patch https://gerrit.wikimedia.org/r/#/c/222695/2 needs to be merged for code review to be completed.
Comment Actions
Change 222479 merged by jenkins-bot:
QA: Add browser test for changing a collection name