Page MenuHomePhabricator

Add browser tests for changing the name of a collection
Closed, ResolvedPublic

Event Timeline

Jdlrobson created this task.Jul 3 2015, 6:23 PM
Jdlrobson assigned this task to rmoen.
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Jdlrobson, gerritbot, bmansurov and 4 others.

Change 222479 had a related patch set uploaded (by Jdlrobson):
Add browser test for changing a collection name

https://gerrit.wikimedia.org/r/222479

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Jul 3 2015, 6:27 PM

My mistake.. so yeh there is a constraint that Yuri built it annoyingly that means your collection name has to be unique (which I always thought was annoying).

We can delete the collection after creating it but that's no good if the test fails as the collection will never get removed.
The alternative would be to give the collection a random name, store it and then test against that..

@dduvall is there a way to do a tear down after running all Gather tests or a specific test?

@rmoen I made your test simply add " cool" to the end of the name. With the preceding patch the name will be random and a fresh collection so in theory unique so your name will always save.
I've +1ed it but someone other than the 2 of us should press the +2 trigger.

Change 222479 had a related patch set uploaded (by Phuedx):
QA: Add browser test for changing a collection name

https://gerrit.wikimedia.org/r/222479

I merged the second patch https://gerrit.wikimedia.org/r/#/c/222695/2 needs to be merged for code review to be completed.

Change 222479 merged by jenkins-bot:
QA: Add browser test for changing a collection name

https://gerrit.wikimedia.org/r/222479

phuedx closed this task as Resolved.Jul 7 2015, 4:05 PM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-51-YOLO board.
phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-51-YOLO board.