Page MenuHomePhabricator
Create Task
Maniphest T104838

[Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

1.Open the ink inspector
2.Search for an article
3.Select an article to add it in the page say Latin

Observed Result:
On the page its getting added as '/wiki/Latin'

See the screenshot attached

Screen Shot 2015-07-06 at 4.48.13 PM.png (496×820 px, 111 KB)

Details

SubjectRepoBranchLines +/-
Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining textmediawiki/extensions/VisualEditorwmf/1.26wmf13+8 -0
Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining textmediawiki/extensions/VisualEditormaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jul 6 2015, 10:49 AM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2015, 10:49 AM
Ryasmeen moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Jul 7 2015, 12:06 PM
Ryasmeen added a comment.Jul 8 2015, 2:52 PM

Reproducible on test2 now

Ryasmeen renamed this task from [Regression pre-wmf13] Article URL with namespace '/wiki/' is getting added in the page while adding it from the link inspector to [Regression wmf13] Article URL with namespace '/wiki/' is getting added in the page while adding it from the link inspector.Jul 8 2015, 2:52 PM
Ryasmeen set Security to None.
Jdforrester-WMF renamed this task from [Regression wmf13] Article URL with namespace '/wiki/' is getting added in the page while adding it from the link inspector to [Regression wmf13] Adding an link with the link inspector in insertion mode inserts an anchor with "/wiki/" prepended.Jul 8 2015, 3:38 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.
Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.
Jdforrester-WMF moved this task from Needs Discussion/Analysis to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF added a subscriber: Krenair.
Krenair added a comment.Jul 9 2015, 12:36 AM

Sounds like this could've been caused by https://gerrit.wikimedia.org/r/#/c/220307/2

gerritbot subscribed.Jul 9 2015, 1:03 AM

Change 223707 had a related patch set uploaded (by Alex Monk):
Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text

https://gerrit.wikimedia.org/r/223707

gerritbot added a project: Patch-For-Review.Jul 9 2015, 1:03 AM
Krenair added a comment.Jul 9 2015, 1:04 AM

We should probably be avoiding getHref in ve.ui.MWLinkAnnotationInspector.prototype.getInsertionText for internal links, but the uploaded patch should still fix the immediate issue.

Krenair claimed this task.Jul 9 2015, 8:29 PM
Krenair merged a task: T105415: Visual editor (link inspector) prepending "/wiki/" to displayed text of internal links when created without text selected.Jul 9 2015, 10:45 PM
Krenair added a subscriber: Thryduulf.
gerritbot added a comment.Jul 9 2015, 11:22 PM

Change 223707 merged by jenkins-bot:
Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text

https://gerrit.wikimedia.org/r/223707

Krenair mentioned this in rEVEDb8c39de8efea: Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when….Jul 9 2015, 11:23 PM
Krenair removed a project: Patch-For-Review.Jul 9 2015, 11:31 PM
gerritbot added a comment.Jul 9 2015, 11:34 PM

Change 223983 had a related patch set uploaded (by Alex Monk):
Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text

https://gerrit.wikimedia.org/r/223983

gerritbot added a project: Patch-For-Review.Jul 9 2015, 11:34 PM
gerritbot added a comment.Jul 9 2015, 11:41 PM

Change 223983 merged by jenkins-bot:
Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when determining text

https://gerrit.wikimedia.org/r/223983

Krenair mentioned this in rEVED6a23a5d112b5: Bypass ve.ui.MWInternalLinkAnnotationWidget.prototype.getHref when….Jul 9 2015, 11:42 PM
• Forrestbot added projects: WMF-deploy-2015-07-07_(1.26wmf13), WMF-deploy-2015-07-14_(1.26wmf14).Jul 10 2015, 12:00 AM
Krenair added a comment.Jul 10 2015, 12:38 AM

I backported and deployed that commit to fix production.

Jdforrester-WMF closed this task as Resolved.Jul 10 2015, 12:48 AM
Jdforrester-WMF subscribed.

Fixed in prod.

Jdforrester-WMF removed a project: Patch-For-Review.Jul 10 2015, 12:48 AM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2015/16 Q1 blockers board.
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL