AuthorityControl gadget always uses globe:earth
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikki
	Jul 9 2015, 12:18 PM

Description

The GeoHack links generated by https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js always use Earth as the globe. It seems from the comment /* BUG: .getGlobe() returns Q2 always */ in the code that this is known, but I couldn't find a ticket for it.

For example, https://www.wikidata.org/wiki/Q3055620 mentioned on https://www.wikidata.org/wiki/Wikidata:Project_chat#Error_with_extraterrestrial_coordinate_locations_.28P625.29 links to https://tools.wmflabs.org/geohack/geohack.php?language=en&params=47.5_N_210_E_globe:earth even though the globe is set to Q111 (Mars).

Related Objects

Mentioned In: T131665: [Bug] Geohack link ignores globe in coordinates

Event Timeline

Nikki created this task.Jul 9 2015, 12:18 PM

Nikki raised the priority of this task from to Needs Triage.

Nikki updated the task description. (Show Details)

Nikki added a project: Wikidata-Gadgets.

Nikki subscribed.

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 9 2015, 12:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Ricordisamoa subscribed.Jul 9 2015, 12:38 PM

Feldo subscribed.Jul 9 2015, 12:44 PM

Snipre subscribed.Jul 9 2015, 12:52 PM

Feldo renamed this task from AuthorityControl gadget always uses globe=earth to AuthorityControl gadget always uses globe:earth.Jul 9 2015, 1:25 PM

Feldo set Security to None.

When checking the stored information via //www.wikidata.org/w/api.php?action=wbgetclaims&entity=Q3055620&property=P625&format=jsonfm you can see that the globe is set to Mars, but the link indeed points to https://tools.wmflabs.org/geohack/geohack.php?language=en&params=47.5_N_210_E_globe:earth. The globe isn't defined in the URL property (P1630): https://tools.wmflabs.org/geohack/geohack.php?language=en&params=$1

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Jul 12 2015, 1:08 PM

Sjoerddebruin triaged this task as Medium priority.Jul 23 2015, 12:48 PM

Sjoerddebruin subscribed.

The problem is in https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikidata.git/master/vendor%2Fdata-values%2Fjavascript%2Flib%2FglobeCoordinate%2FglobeCoordinate.GlobeCoordinate.js#L43 not in the gadget.

Sjoerddebruin moved this task from Backlog to Bugs on the Wikidata-Gadgets board.Feb 23 2016, 10:38 AM

Nikki mentioned this in T131665: [Bug] Geohack link ignores globe in coordinates.Apr 6 2016, 11:40 AM

Ricordisamoa merged a task: T131665: [Bug] Geohack link ignores globe in coordinates.Apr 6 2016, 12:09 PM

Ricordisamoa added subscribers: thiemowmde, Smalyshev.

https://github.com/wmde/DataValuesJavascript/pull/94

In https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikidata.git/master/vendor%2Fdata-values%2Fjavascript%2Flib%2FglobeCoordinate%2FglobeCoordinate.GlobeCoordinate.js#L142

if( this.getGlobe() !== otherGlobeCoordinate.getGlobe() ) {
	return false;
}

should get added, too.

https://github.com/wmde/DataValuesJavascript/pull/94 is merged

...and deployed.
The link shown at https://www.wikidata.org/w/index.php?title=Q3055620&oldid=263487179#P625 now leads to the correct GeoHack page.
MediaWiki:Gadget-AuthorityControl.js has been updated to reflect the change: https://www.wikidata.org/wiki/?diff=321509805

AuthorityControl gadget always uses globe:earthClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

AuthorityControl gadget always uses globe:earth
Closed, ResolvedPublic
Actions