Page MenuHomePhabricator

Spike: Errors while charging recurring GlobalCollect might be handled wrong
Open, MediumPublic


I'm pretty sure that there are error modes in which the recurring charge fails, and CiviCRM records that it was successful, and vice-versa. These are both really bad.

See possible examples in T105041

Sorry, this is all I got for now. I thought there was already a card for this issue, but can't find it.

Event Timeline

awight created this task.Jul 15 2015, 4:00 AM
awight raised the priority of this task from to High.
awight updated the task description. (Show Details)
awight added a subscriber: awight.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2015, 4:00 AM
Ejegg added a subscriber: Ejegg.Jul 20 2015, 3:02 PM

One way to handle this might be to remove the 'RECURRING_CHARGE' transaction from the gc adapter, and have the Civi module make each of the do_payment / get_orderstatus / set_payment calls individually, updating the db record with the intermediate status. Then if we see charge that died in process, we can run another get_orderstatus to decide whether to retry.

Interesting! I'm not sure we're having granular fail like that, but it sounds much more correct.

atgo moved this task from Backlog to Bugs on the Recurring-Donations board.Jul 30 2015, 12:12 AM
DStrine lowered the priority of this task from High to Medium.Apr 11 2017, 4:33 PM
DStrine added a subscriber: DStrine.

dropping this to normal since we haven't touched this task in a while. We should recheck this after the new integration.

mmodell removed a subscriber: awight.Jun 22 2017, 9:39 PM