Zuul has been changed the way it sends its code-review/verified votes. Instead of using --verified 2 it nows uses: --label verified=2.
But:
$ ssh -p 29418 hashar@gerrit.wikimedia.org 'gerrit review --label verified=1 226272,1' fatal: internal server error while approving 226272,1 one or more approvals failed; review output above
Passing the label uppercase with --label Verified=-1 does work as expected.
On the server side with --label verified=-1 we have:
[2015-07-22 20:20:56,774] ERROR com.google.gerrit.sshd.commands.ReviewCommand : internal error while approving 226272,1 com.google.gwtorm.server.OrmException: insert failure on patch_set_approvals at com.google.gwtorm.schema.sql.SqlDialect.convertError(SqlDialect.java:152) ... Caused by: java.sql.BatchUpdateException: Duplicate entry '226272-1-24-Verified' for key 'PRIMARY' ... Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '226272-1-24-Verified' for key 'PRIMARY'
Full trace:
Obvious fix: use the upper case version :-D