Page MenuHomePhabricator
Create Task
Maniphest T106963

SiteMatrix API returns unexpected null for 'wiki.url' field of Wikipedia project
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/225287/ has exposed some strangeness around SiteMatrix and MediaWiki's wgConf - in https://es.wikipedia.org/w/api.php?action=sitematrix&format=jsonfm "url" and "sitename" are null for wikipedias.

> var_dump( $wgConf->get( 'wgCanonicalServer', 'eswiki', 'wiki', array( 'lang' => 'es', 'site' => 'wiki' ) ) ); // What SiteMatrix would be doing
NULL

> var_dump( $wgConf->get( 'wgCanonicalServer', 'eswiki', 'wikipedia', array( 'lang' => 'es', 'site' => 'wiki' ) ) ); // Whereas this actually works
string(24) "https://es.wikipedia.org"

Spotted by @Sitic

Details

SubjectRepoBranchLines +/-
"wiki" → "wikipedia"mediawiki/extensions/SiteMatrixmaster+1 -1
Re-add default=wikipedia lines to wgCanonicalServer and wgSitenameoperations/mediawiki-configmaster+2 -0
Fix loading of canonical url and site name settingsmediawiki/extensions/SiteMatrixwmf/1.26wmf15+30 -8
Fix loading of canonical url and site name settingsmediawiki/extensions/SiteMatrixmaster+30 -8
Customize query in gerrit

Related Objects

Event Timeline

Krenair created this task.Jul 25 2015, 9:41 PM
Krenair raised the priority of this task from to High.
Krenair updated the task description. (Show Details)
Krenair added projects: SiteMatrix, MediaWiki-Configuration.
Krenair added subscribers: Krenair, Sitic.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2015, 9:41 PM
Legoktm subscribed.Jul 25 2015, 11:14 PM

Do we just need to change "wiki" --> "wikipedia" in SiteMatrix's extension.json? My hunch is this is a regression from rMWbc2915b7220e: Attempt to remove a hard-coded "wikipedia". that was masked by the default value until now.

Krenair added a comment.Jul 25 2015, 11:24 PM

I tried that on mw1017 earlier, breaks other things, probably because it's also used as the database name suffix.

gerritbot subscribed.Jul 25 2015, 11:25 PM

Change 227065 had a related patch set uploaded (by Legoktm):
"wiki" → "wikipedia"

https://gerrit.wikimedia.org/r/227065

gerritbot added a project: Patch-For-Review.Jul 25 2015, 11:25 PM
Sitic mentioned this in T106897: meta_p.wiki table corrupt (contains many NULL entries for 'url' field).Jul 26 2015, 3:35 AM
scfc merged a task: T106967: sitematrix returns null as "url" for Wikipedia sites.Jul 26 2015, 3:39 AM
scfc added a parent task: T106897: meta_p.wiki table corrupt (contains many NULL entries for 'url' field).
scfc added subscribers: Krinkle, scfc, Pathoschild and 4 others.
Glaisher reopened this task as Open.Jul 26 2015, 10:19 AM
Glaisher closed this task as a duplicate of T106897: meta_p.wiki table corrupt (contains many NULL entries for 'url' field).
Glaisher subscribed.
Mjbmr set Security to None.Jul 26 2015, 10:20 AM
Mjbmr subscribed.
Krenair removed a parent task: T106897: meta_p.wiki table corrupt (contains many NULL entries for 'url' field).Jul 26 2015, 3:58 PM
• MZMcBride subscribed.Jul 26 2015, 11:07 PM
Glaisher merged a task: T107002: action=sitematrix&smsiteprop=url|code is not showing url value for wikipedias since 1.26wmf15 .Jul 27 2015, 6:15 AM
Glaisher added a subscriber: Merl.
coren claimed this task.Jul 27 2015, 6:05 PM
coren removed coren as the assignee of this task.Jul 27 2015, 6:28 PM
coren subscribed.
Krinkle renamed this task from SiteMatrix returning null for wikipedia canonical URLs and site names to SiteMatrix API returns unexpected null for 'wiki.url' field of Wikipedia project.Jul 27 2015, 6:46 PM
Krinkle raised the priority of this task from High to Unbreak Now!.
Krinkle added a project: Regression.

This is causing Global SUL to throw a runtime exception because wikiObj.url is null instead of a string. As such it is unable to establish an HTTP connection to any Wikipedia domain.

Pathoschild added a comment.Jul 27 2015, 6:53 PM

This also breaks Synchbot, which has been disabled until this is fixed.

Krenair added a comment.Jul 27 2015, 7:22 PM

As per discussion with @Legoktm and @Krinkle, I'm going to re-add the default=wikipedia lines temporarily, until we can get this properly fixed. But this is not going to be closed until it is fixed properly.

gerritbot added a comment.Jul 27 2015, 7:27 PM

Change 227273 had a related patch set uploaded (by Alex Monk):
Re-add default=wikipedia lines to wgCanonicalServer and wgSitename

https://gerrit.wikimedia.org/r/227273

gerritbot added a comment.Jul 27 2015, 7:29 PM

Change 227273 merged by jenkins-bot:
Re-add default=wikipedia lines to wgCanonicalServer and wgSitename

https://gerrit.wikimedia.org/r/227273

Krenair mentioned this in rOMWC45ed8877f1d0: Re-add default=wikipedia lines to wgCanonicalServer and wgSitename.Jul 27 2015, 7:29 PM
Krenair mentioned this in T104088: Get rid of remaining default=wikipedia assumptions.Jul 27 2015, 7:35 PM
Krenair added a comment.Jul 27 2015, 7:37 PM

There's still other broken things in SiteMatrix. E.g. the sitename is now all completely "Wikipedia" (it was null before the above commit), even for non-wikipedias. If you change SiteMatrix::getSitename to include $major as the third (optional) parameter to $wgConf->get, it gives you all of the English sitenames of the project. Which is better, but not by much.

Reedy merged a task: T107064: In sitematrix api module, wikipedia sites have a null url.Jul 28 2015, 12:08 AM
Reedy added a subscriber: aude.
Reedy subscribed.
In T107064#1486314, @gerritbot wrote:

Change 227350 had a related patch set (by Aude) published:
Fix loading of canonical url and site name settings

https://gerrit.wikimedia.org/r/227350

gerritbot added a comment.Jul 28 2015, 12:09 AM

Change 227350 had a related patch set uploaded (by Reedy):
Fix loading of canonical url and site name settings

https://gerrit.wikimedia.org/r/227350

gerritbot added a comment.Jul 28 2015, 12:21 AM

Change 227350 merged by jenkins-bot:
Fix loading of canonical url and site name settings

https://gerrit.wikimedia.org/r/227350

Diffusion mentioned this in rMEXT70b2f3cc2c4f: Updated mediawiki/extensions Project: mediawiki/extensions/SiteMatrix….Jul 28 2015, 12:21 AM
Reedy mentioned this in rESMX0bc66ae5be87: Fix loading of canonical url and site name settings.Jul 28 2015, 12:22 AM
gerritbot added a comment.Jul 28 2015, 12:28 AM

Change 227379 had a related patch set uploaded (by Alex Monk):
Fix loading of canonical url and site name settings

https://gerrit.wikimedia.org/r/227379

gerritbot added a comment.Jul 28 2015, 12:29 AM

Change 227379 merged by jenkins-bot:
Fix loading of canonical url and site name settings

https://gerrit.wikimedia.org/r/227379

Krenair mentioned this in rESMX47b13711153c: Fix loading of canonical url and site name settings.Jul 28 2015, 12:29 AM
aude mentioned this in rMW177e4d0d0c72: Updated mediawiki/core Project: mediawiki/extensions/SiteMatrix….Jul 28 2015, 12:29 AM
Krenair closed this task as Resolved.Jul 28 2015, 12:36 AM
Krenair assigned this task to aude.
• Forrestbot added projects: WMF-deploy-2015-07-21_(1.26wmf15), WMF-deploy-2015-07-28_(1.26wmf16).Jul 28 2015, 1:00 AM
Glaisher mentioned this in T107062: Email notifications for reassigning/claim should be consistent with web interface.Jul 28 2015, 8:44 AM
gerritbot added a comment.Sep 14 2015, 12:28 AM

Change 227065 abandoned by Legoktm:
"wiki" → "wikipedia"

https://gerrit.wikimedia.org/r/227065

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL