Page MenuHomePhabricator
Create Task
Maniphest T107232

'Undo' action from 'View history' cannot be completed
Closed, ResolvedPublic
Actions

Description

  1. On any Flow page edit some comment(s) and/or the description board
  2. Go to 'View history' and click on undo for 'edited a comment' and 'edited the description' antires.

The diff page to which you redirected, is dimmed and in a state of being loaded. Although, it displays: "The edit can be undone. Please check the comparison below to verify that this is what you want to do, and then save the changes below to finish undoing the edit. " - the page never becomes active.

Screen Shot 2015-07-28 at 3.50.52 PM.png (537×883 px, 87 KB)

The same never-finish-loading issue for action that cannot be undone.

Screen Shot 2015-07-28 at 3.47.37 PM.png (297×918 px, 43 KB)

A separate question: 'edited the description' action made by 'Flow talk page manager'(http://test.wikimedia.beta.wmflabs.org/w/index.php?title=Talk:ET20&action=history) also has 'undo'. Is it what can be undone?

Note: 'unhide', 'undelete', 'reopen' actions - can be successfully completed.

Details

SubjectRepoBranchLines +/-
Fix undo pagesmediawiki/extensions/Flowmaster+38 -15
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jul 28 2015, 11:29 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Triage.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2015, 11:29 PM
• DannyH triaged this task as High priority.Jul 29 2015, 11:29 PM
• DannyH set Security to None.
• DannyH moved this task from Untriaged to Ready for next sprint on the Collaboration-Team-Triage board.
gerritbot subscribed.Jul 30 2015, 8:48 PM

Change 228138 had a related patch set uploaded (by Sbisson):
[WIP] Fix undo-edit-header

https://gerrit.wikimedia.org/r/228138

gerritbot added a project: Patch-For-Review.Jul 30 2015, 8:48 PM
• DannyH renamed this task from [betalabs] 'Undo' action from 'View history' cannot be completed to 'Undo' action from 'View history' cannot be completed.Jul 31 2015, 9:27 PM
• DannyH added a project: Collaboration-Team-Archive-2015-2016.
SBisson claimed this task.Aug 3 2015, 12:37 PM
SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
SBisson added a comment.Aug 3 2015, 3:20 PM

undo-edit-post and undo-edit-topic-summary actions have the same problem.

• Catrope merged a task: T107737: Undo header edit isn't possible (due to flow-ui-load-overlay).Aug 3 2015, 4:58 PM
• Catrope added a subscriber: Florian.
• DannyH moved this task from Ready for next sprint to Current workboard on the Collaboration-Team-Triage board.Aug 3 2015, 11:43 PM
• Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 5 2015, 5:43 PM
SBisson added a subscriber: • DannyH.Aug 5 2015, 5:50 PM

A separate question: 'edited the description' action made by 'Flow talk page manager'(http://test.wikimedia.beta.wmflabs.org/w/index.php?title=Talk:ET20&action=history) also has 'undo'. Is it what can be undone?

'Flow talk page manager' sets the board description after converting it a page to Flow. It is a revision like any other and can be undone. I don't know if we want or if it is possible to make it non-undoable. @DannyH?

• DannyH added a comment.Aug 5 2015, 9:23 PM

Yes, that can be undone. It's just undoing an edit to the wikitext in the description; it's not undoing a function.

• Catrope moved this task from Needs Review to Code Review Started on the Collaboration-Team-Archive-2015-2016 board.Aug 5 2015, 10:28 PM
gerritbot added a comment.Aug 7 2015, 12:59 AM

Change 228138 merged by jenkins-bot:
Fix undo pages

https://gerrit.wikimedia.org/r/228138

SBisson mentioned this in rEFLW5094c41722a6: Fix undo pages.Aug 7 2015, 1:00 AM
Diffusion mentioned this in rMEXTbea757a3985c: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 7 2015, 1:00 AM
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 7 2015, 1:00 AM
SBisson moved this task from Code Review Started to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 7 2015, 11:06 AM
Etonkovidova added a comment.Aug 10 2015, 5:03 PM

Checked

  • undo-edit-post
  • undo-edit-topic-summary
  • undo description edit

Also checked the edits that cannot be undone.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 10 2015, 5:03 PM
• DannyH closed this task as Resolved.Aug 10 2015, 5:14 PM
• DannyH removed a project: Collaboration-Team-Archive-2015-2016.
• DannyH removed a project: Collaboration-Team-Triage.Aug 20 2015, 9:06 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 20 2015, 9:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits