Maniphest T107962

Collections link not showing in left nav
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Aug 4 2015, 11:24 PM

Tags

Referenced Files

None

Subscribers

Description

https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/220/

Seems present in HTML but for some reason is not being revealed when I visit
http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein

I think this is a race condition - $( '#mw-mf-page-left' ).find( '.collection-menu-item' ).removeClass( 'hidden' ); is possibly being executed too early.

Details

	Subject	Repo	Branch	Lines +/-
	Unhide the 'Collections' menu item	mediawiki/extensions/Gather	master	+1 -2
	Unhide the 'Collections' menu item	mediawiki/extensions/Gather	master	+2 -2
	Unhide the 'Collections' menu item	mediawiki/extensions/Gather	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: rMEXTbbc5edb6f11f: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
rEGAT2a0b033ecc0c: Unhide the 'Collections' menu item

Event Timeline

Jdlrobson created this task.Aug 4 2015, 11:24 PM

Jdlrobson raised the priority of this task from to High.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Reading-Web-Sprint-53-12-Monkeys.

Jdlrobson moved this task to Needs Analysis on the Reading-Web-Sprint-53-12-Monkeys board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2015, 11:24 PM

Jdlrobson updated the task description. (Show Details)Aug 4 2015, 11:27 PM

Jdlrobson set Security to None.

• KLans_WMF raised the priority of this task from High to Unbreak Now!.Aug 5 2015, 5:16 PM

• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-53-12-Monkeys board.

• bmansurov claimed this task.Aug 5 2015, 5:51 PM

• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-53-12-Monkeys board.

Change 229430 had a related patch set uploaded (by Bmansurov):
Unhide the 'Collections' menu item

https://gerrit.wikimedia.org/r/229430

gerritbot added a project: Patch-For-Review.Aug 5 2015, 6:01 PM

• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 6:01 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 6:23 PM

• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 8:04 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 8:55 PM

• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 10:03 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 11:37 PM

Change 229603 had a related patch set uploaded (by Bmansurov):
Unhide the 'Collections' menu item

https://gerrit.wikimedia.org/r/229603

Change 229605 had a related patch set uploaded (by Bmansurov):
Unhide the 'Collections' menu item

https://gerrit.wikimedia.org/r/229605

Change 229605 abandoned by Bmansurov:
Unhide the 'Collections' menu item

https://gerrit.wikimedia.org/r/229605

Change 229603 abandoned by Bmansurov:
Unhide the 'Collections' menu item

https://gerrit.wikimedia.org/r/229603

• bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 6 2015, 12:16 AM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 6 2015, 12:54 AM

Change 229430 merged by jenkins-bot:
Unhide the 'Collections' menu item

https://gerrit.wikimedia.org/r/229430

• bmansurov mentioned this in rEGAT2a0b033ecc0c: Unhide the 'Collections' menu item.Aug 6 2015, 12:57 AM

• bmansurov mentioned this in rMEXTbbc5edb6f11f: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….

• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 6 2015, 1:00 AM

We seem to be green:
https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-Gather-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/

Also verified it shows up fine in beta cluster.

• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 12:33 PM

Jdlrobson merged a task: T108852: gather pop-up pointing to wrong place and covering search bar.Aug 13 2015, 5:14 PM

Jdlrobson added subscribers: Mobile, dchen.

Danny_B renamed this task from Regression: Collections link not showing in left nav to Collections link not showing in left nav.Jul 3 2016, 10:56 PM

Danny_B added projects: Mobile, Regression.

Danny_B removed a subscriber: Mobile.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 3 2016, 10:56 PM