Page MenuHomePhabricator
Create Task
Maniphest T108041

FailPage logic is all jacked up
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Payments is currently sending users to a 404 /Donate-error URL most of the time an error occurs. There's no consistency in how we're getting the failure redirect. We should be using the error forms when RapidFail is true (and we can find a good error form), and falling back to a correctly formed wiki URL when it's not.

Details

SubjectRepoBranchLines +/-
Fix fail page redirection (see deploy note!)mediawiki/extensions/DonationInterfacemaster+62 -40
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Aug 5 2015, 4:02 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Unbreak Now!.
Ejegg updated the task description. (Show Details)
Ejegg added projects: MediaWiki-extensions-DonationInterface, Fundraising Sprint The Pogues.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 4:02 PM
• atgo added a project: Unplanned-Sprint-Work.Aug 5 2015, 4:05 PM
• atgo subscribed.
gerritbot subscribed.Aug 5 2015, 4:47 PM

Change 229414 had a related patch set uploaded (by Ejegg):
Fix fail page redirection

https://gerrit.wikimedia.org/r/229414

gerritbot added a project: Patch-For-Review.Aug 5 2015, 4:47 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint The Pogues board.Aug 5 2015, 4:48 PM
Ejegg set Security to None.
Ejegg edited a custom field.
Ejegg mentioned this in T108059: AstroPay donors all sent to fail page.Aug 5 2015, 4:53 PM
Ejegg moved this task from Review to Doing on the Fundraising Sprint The Pogues board.Aug 5 2015, 9:58 PM
• atgo added a project: Fundraising-Backlog.Aug 5 2015, 10:04 PM
• atgo moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.
• atgo added a project: Fundraising Sprint Queen.Aug 5 2015, 10:27 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Queen board.Aug 5 2015, 10:28 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint Queen board.Aug 17 2015, 3:43 PM
• atgo added a project: Fundraising Sprint Rowlf the Dog.Aug 19 2015, 10:58 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Rowlf the Dog board.Aug 19 2015, 11:00 PM
• DStrine removed a project: Unplanned-Sprint-Work.Aug 20 2015, 4:58 PM
gerritbot added a comment.Aug 26 2015, 4:27 PM

Change 229414 merged by jenkins-bot:
Fix fail page redirection (see deploy note!)

https://gerrit.wikimedia.org/r/229414

Ejegg mentioned this in rMEXTebd1e12e3bd1: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Aug 26 2015, 4:27 PM
awight mentioned this in rEDOIfd7d61bf98aa: Fix fail page redirection (see deploy note!).Aug 26 2015, 4:27 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Rowlf the Dog board.Aug 26 2015, 5:23 PM
Ejegg added a project: Fundraising Sprint Snoop (Dogg|Lion).Sep 3 2015, 8:16 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Snoop (Dogg|Lion) board.Sep 3 2015, 8:22 PM
Ejegg closed this task as Resolved.Sep 9 2015, 5:30 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Snoop (Dogg|Lion) board.
• atgo unsubscribed.Mar 30 2016, 10:03 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:40 PM
Restricted Application added subscribers: Jay8g, TerraCodes. · View Herald TranscriptJan 11 2018, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL