Page MenuHomePhabricator
Create Task
Maniphest T108123

Handle result of Amazon API calls
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

After making ConfirmOrderReference, authorize and capture API calls, we will either have problems to solve or a successful payment. On success, send the donor to the thank you page and drop their info into the completed donation queue. On correctable failure, let 'em correct it. On total failure, finalize status to failed and send the donor to the fail page.

Details

SubjectRepoBranchLines +/-
Handle results of Amazon API callsmediawiki/extensions/DonationInterfaceamazon+299 -33
Don't submit an Amazon payment with invalid amountmediawiki/extensions/DonationInterfaceamazon+21 -4
Allow callables in GatewayAdapter::$error_mapmediawiki/extensions/DonationInterfaceamazon+10 -4
Move Amazon test responses into their own filesmediawiki/extensions/DonationInterfaceamazon+185 -177
Add amount and currency to Amazon API postmediawiki/extensions/DonationInterfaceamazon+14 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT93302 Big English Fundraiser - December
 ResolvedNoneT87625 [epic] Amazon upgrade
 ResolvedNoneT108102 [EPIC] Amazon (embedded) internal test
ResolvedEjeggT108123 Handle result of Amazon API calls

Event Timeline

Ejegg created this task.Aug 5 2015, 9:51 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: Fundraising-Backlog, MediaWiki-extensions-DonationInterface.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2015, 9:51 PM
Ejegg added a parent task: T108102: [EPIC] Amazon (embedded) internal test .Aug 5 2015, 9:54 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Aug 11 2015, 9:28 PM
• atgo triaged this task as High priority.Aug 19 2015, 9:29 PM
• atgo set Security to None.
Ejegg edited a custom field.Aug 19 2015, 10:36 PM
• DStrine moved this task from Sprint +1 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Aug 19 2015, 10:49 PM
• atgo added a project: Fundraising Sprint Rowlf the Dog.Aug 19 2015, 10:58 PM
Ejegg claimed this task.Aug 25 2015, 8:19 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Rowlf the Dog board.
gerritbot subscribed.Aug 31 2015, 6:49 PM

Change 235057 had a related patch set uploaded (by Ejegg):
Add amount and currency to Amazon API post

https://gerrit.wikimedia.org/r/235057

gerritbot added a project: Patch-For-Review.Aug 31 2015, 6:49 PM
gerritbot added a comment.Aug 31 2015, 7:30 PM

Change 235057 merged by jenkins-bot:
Add amount and currency to Amazon API post

https://gerrit.wikimedia.org/r/235057

Ejegg mentioned this in rEDOI66405f62f3be: Add amount and currency to Amazon API post.Aug 31 2015, 7:30 PM
gerritbot added a comment.Sep 1 2015, 4:25 AM

Change 233993 had a related patch set uploaded (by Ejegg):
WIP handle errors in Amazon API calls

https://gerrit.wikimedia.org/r/233993

gerritbot added a comment.Sep 1 2015, 7:28 PM

Change 235293 had a related patch set uploaded (by Ejegg):
Allow callables in GatewayAdapter::$error_map

https://gerrit.wikimedia.org/r/235293

gerritbot added a comment.Sep 1 2015, 10:16 PM

Change 235369 had a related patch set uploaded (by Ejegg):
Move Amazon test responses into their own files

https://gerrit.wikimedia.org/r/235369

Ejegg moved this task from Doing to Review on the Fundraising Sprint Rowlf the Dog board.Sep 2 2015, 4:28 PM
Ejegg added a project: Fundraising Sprint Snoop (Dogg|Lion).Sep 3 2015, 8:15 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Snoop (Dogg|Lion) board.Sep 3 2015, 8:22 PM
gerritbot added a comment.Sep 4 2015, 5:23 PM

Change 235369 merged by jenkins-bot:
Move Amazon test responses into their own files

https://gerrit.wikimedia.org/r/235369

gerritbot added a comment.Sep 4 2015, 5:23 PM

Change 235293 merged by jenkins-bot:
Allow callables in GatewayAdapter::$error_map

https://gerrit.wikimedia.org/r/235293

Ejegg mentioned this in rEDOI6f0b6b09cf87: Move Amazon test responses into their own files.Sep 4 2015, 5:23 PM
Ejegg mentioned this in rEDOIea84a1b9f713: Allow callables in GatewayAdapter::$error_map.
gerritbot added a comment.Sep 11 2015, 8:46 PM

Change 237748 had a related patch set uploaded (by Ejegg):
Don't submit an Amazon payment with invalid amount

https://gerrit.wikimedia.org/r/237748

gerritbot added a comment.Sep 14 2015, 11:50 PM

Change 233993 merged by jenkins-bot:
Handle results of Amazon API calls

https://gerrit.wikimedia.org/r/233993

Ejegg mentioned this in rEDOIc2a5959c6539: Handle results of Amazon API calls.Sep 14 2015, 11:51 PM
gerritbot added a comment.Sep 14 2015, 11:51 PM

Change 237748 merged by jenkins-bot:
Don't submit an Amazon payment with invalid amount

https://gerrit.wikimedia.org/r/237748

awight mentioned this in rEDOI5e8e6c9a3bb3: Don't submit an Amazon payment with invalid amount.Sep 14 2015, 11:51 PM
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint Snoop (Dogg|Lion) board.Sep 15 2015, 5:07 PM
• DStrine moved this task from Pending Deployment to Done on the Fundraising Sprint Snoop (Dogg|Lion) board.Sep 17 2015, 12:18 AM
• DStrine added a project: Fundraising Sprint Tom Waits.Sep 17 2015, 1:12 AM
Ejegg moved this task from Backlog to Done on the Fundraising Sprint Tom Waits board.Sep 17 2015, 2:36 PM
Ejegg closed this task as Resolved.Sep 18 2015, 8:12 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits