Gather should only load skins.minerva.scripts in Minerva skin
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Tbayer
	Aug 8 2015, 3:54 AM

Description

Gather loads skins.minerva.scripts in Vector. This should never happen.

Original report:
In e.g. https://en.wikipedia.org/wiki/Special:Gather/all/recent , it's not possible to place the cursor into the search box on top right (by either clicking on it or via the keyboard shortcut Alt-Shift-F / CTRL-Option-F).

Reproduced with current Chromium/Chrome versions under Linux and OS X, both when logged in and logged out.

It seems to work fine in Firefox, though, both under Linux and OS X.
Note: This may be due to an issue in MobileFrontend's MobileWebUIClickTracking code which should not be running in desktop.

Details

	Subject	Repo	Branch	Lines +/-
	Avoid loading Minerva code in Vector	mediawiki/extensions/Gather	dev	+67 -26
	Search box can now be clicked on from pages which use MobileFrontend.js	mediawiki/extensions/MobileFrontend	master	+6 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T109351 [EPIC] Gather should not depend on MobileFrontend
		Resolved		Jdlrobson	T108432 Gather should only load skins.minerva.scripts in Minerva skin

Event Timeline

• Tbayer created this task.Aug 8 2015, 3:54 AM

• Tbayer raised the priority of this task from to Needs Triage.

• Tbayer updated the task description. (Show Details)

• Tbayer added a project: Gather.

• Tbayer subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2015, 3:54 AM

It's trying to click track for some reason as this happens:
[MobileWebUIClickTracking] Value null is the wrong type for property "mobileMode" (string expected)

Click tracking should not be loaded here.

Jdlrobson renamed this task from Search box inaccessible in Special:Gather to Desktop: Search box inaccessible in Special:Gather.Aug 12 2015, 5:59 AM

Jdlrobson added a project: good first task.

Jdlrobson set Security to None.

Jdlrobson moved this task from Needs triage to Bug backlog on the Gather board.

• KLans_WMF triaged this task as Low priority.Sep 16 2015, 5:18 PM

Jdlrobson updated the task description. (Show Details)Dec 1 2015, 9:30 PM

Jdlrobson added a project: Google-Code-In-2015.

Will mentor this task in #GCI2015

xSavitar moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 2 2015, 10:55 AM

Mhutti1 claimed this task.Jan 19 2016, 5:31 PM

Change 265124 had a related patch set uploaded (by Mhutti1):
Search box can now be clicked on from pages which use MobileFrontend.js

https://gerrit.wikimedia.org/r/265124

gerritbot added a project: Patch-For-Review.Jan 19 2016, 9:14 PM

Jdlrobson merged a task: T121946: Search box bug on Special:Gather.Jan 19 2016, 9:15 PM

Jdlrobson added subscribers: • bmansurov, Quiddity, StudiesWorld.

Jdlrobson renamed this task from Desktop: Search box inaccessible in Special:Gather to Gather should only load skins.minerva.scripts in Minerva skin.Jan 20 2016, 1:35 AM

Jdlrobson lowered the priority of this task from Low to Lowest.

Jdlrobson removed projects: Google-Code-In-2015, good first task.

Jdlrobson updated the task description. (Show Details)

Change 261276 had a related patch set uploaded (by Jdlrobson):
Avoid loading Minerva code in Vector

https://gerrit.wikimedia.org/r/261276

Jdlrobson added a parent task: T109351: [EPIC] Gather should not depend on MobileFrontend.Jan 20 2016, 1:36 AM

Jdlrobson claimed this task.Jan 20 2016, 1:51 AM

Jdlrobson added a subscriber: Mhutti1.

Change 265124 merged by jenkins-bot:
Search box can now be clicked on from pages which use MobileFrontend.js

https://gerrit.wikimedia.org/r/265124

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 20 2016, 4:00 AM

Change 261276 merged by jenkins-bot:
Avoid loading Minerva code in Vector