Page MenuHomePhabricator
Create Task
Maniphest T108448

Free external links not highlighted
Closed, ResolvedPublic
Actions

Description

Free external links (without [ and ]) are currently not highlighted.

Details

SubjectRepoBranchLines +/-
add highlighting of free external links (v 3.1.9)mediawiki/extensions/CodeMirrormaster+49 -7
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Aug 8 2015, 8:18 AM
Schnark raised the priority of this task from to Needs Triage.
Schnark updated the task description. (Show Details)
Schnark added a project: MediaWiki-extensions-CodeMirror.
Schnark subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2015, 8:18 AM
Pastakhov claimed this task.Aug 10 2015, 7:57 AM
Pastakhov triaged this task as Medium priority.
Pastakhov set Security to None.
gerritbot subscribed.Aug 10 2015, 11:02 AM

Change 230513 had a related patch set uploaded (by Pastakhov):
add highlighting of free external links (v 3.1.9)

https://gerrit.wikimedia.org/r/230513

gerritbot added a project: Patch-For-Review.Aug 10 2015, 11:02 AM
gerritbot added a comment.Aug 10 2015, 5:15 PM

Change 230513 merged by jenkins-bot:
add highlighting of free external links (v 3.1.9)

https://gerrit.wikimedia.org/r/230513

Pastakhov mentioned this in rMEXTe6b6dbb51abb: Updated mediawiki/extensions Project: mediawiki/extensions/CodeMirror….Aug 10 2015, 5:16 PM
Pastakhov mentioned this in rECMI00f668e32c55: add highlighting of free external links (v 3.1.9).
Pastakhov closed this task as Resolved.Aug 10 2015, 5:18 PM
Pastakhov added a comment.Aug 11 2015, 7:34 AM

Now it is looking for free external links only from start line and after a space character. Is it ok?
For example link will not be highlighted:

wikitext (https://meta.wikimedia.org/) wikitext

It is possible to resolve, but it will reduce the performance.
Should we to fix it?

Pastakhov reopened this task as Open.Aug 11 2015, 7:35 AM
Pastakhov added a comment.Aug 14 2015, 7:33 AM

Free external links not highlighted in table also

Niharika lowered the priority of this task from Medium to Lowest.Nov 7 2017, 11:57 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 7 2017, 11:57 PM
• TBolliger moved this task from New & TBD Tickets to In Sprint 🏃‍♀️🏃‍♂️ on the Community-Tech board.Feb 6 2018, 10:55 PM
Niharika closed this task as Resolved.Mar 2 2018, 6:47 AM
Niharika moved this task from In Sprint 🏃‍♀️🏃‍♂️ to Archive on the Community-Tech board.
Niharika subscribed.
In T108448#1526720, @Pastakhov wrote:

Now it is looking for free external links only from start line and after a space character. Is it ok?
For example link will not be highlighted:

wikitext (https://meta.wikimedia.org/) wikitext

It is possible to resolve, but it will reduce the performance.
Should we to fix it?

I think that's acceptable.

Niharika moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Mar 2 2018, 7:05 AM
Bhsd removed a project: Patch-For-Review.Feb 28 2024, 8:24 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL