Page MenuHomePhabricator
Create Task
Maniphest T108533

[Bug] Escaping problem when creating an item from search
Closed, DuplicatePublic
Actions

Description

I was wondering why sometimes items with funky characters turn up and now I know how to reproduce it:

Looking https://www.wikidata.org/wiki/MediaWiki:Searchmenu-new this part probably causing the problems:

<span class="plainlinks">[{{fullurl:Special:CreateItem|label={{urlencode:$1}}}} create a new item]</span>

Would it be as simple as getting rid of the urlencode or would something else break?

Related Objects

Event Timeline

Multichill created this task.Aug 9 2015, 5:29 PM
Multichill raised the priority of this task from to Needs Triage.
Multichill updated the task description. (Show Details)
Multichill added a project: Wikidata.
Multichill subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2015, 5:29 PM
Lydia_Pintscher renamed this task from Escaping problem when creating an item from search to [Bug] Escaping problem when creating an item from search.Aug 17 2015, 3:47 PM
Lydia_Pintscher set Security to None.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
Lydia_Pintscher triaged this task as Medium priority.Aug 17 2015, 4:45 PM
matej_suchanek added a project: TestMe.Apr 17 2016, 7:03 PM
IvanFon subscribed.EditedDec 18 2016, 7:55 PM

I can reproduce this issue on Firefox 50.0 on Elementary OS 0.4. I tested on Wikidata (Mediawiki version 1.290).

  1. Enter a search with special characters
  2. Click on "create a new item"
  3. The label field will show the escaping issues
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 18 2016, 7:55 PM
IvanFon removed a project: TestMe.Dec 18 2016, 7:57 PM
matej_suchanek merged a task: T192984: Label in Special:NewItem is too much escaped.Apr 26 2018, 3:25 PM
matej_suchanek added a subscriber: Envlh.
Lucas_Werkmeister_WMDE closed this task as a duplicate of T263258: “Create a new item” link on search results page can produce incorrectly-escaped label.Oct 18 2022, 8:19 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL