Page MenuHomePhabricator
Create Task
Maniphest T108638

Convert wikiversions from CDB to static array file
Closed, ResolvedPublic
Actions

Description

As previously discussed in T99740, PHP files containing static array definitions are translated to bytecode by HHVM and cached in its bytecode cache, and are thus faster to read than CDB files. We should exploit this by switching the representation of the wikiversions mapping from CDB to PHP.

Details

SubjectRepoBranchLines +/-
Build wikiversions.php in addition to wikiversions.cdbmediawiki/tools/scapmaster+18 -2
Convert multiversion scripts to use wikiversions.phpoperations/mediawiki-configmaster+28 -42
Add wikiversions{-labs}.php to .gitignoreoperations/mediawiki-configmaster+2 -0
Build wikiversions.php in addition to wikiversions.cdboperations/mediawiki-configmaster+12 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ori created this task.Aug 10 2015, 9:45 PM
ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added a project: MediaWiki-Configuration.
ori subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2015, 9:45 PM
Legoktm edited projects, added Wikimedia-Site-requests; removed MediaWiki-Configuration.Aug 10 2015, 9:45 PM
Legoktm set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 10 2015, 9:45 PM
gerritbot subscribed.Aug 10 2015, 9:46 PM

Change 230662 had a related patch set uploaded (by Ori.livneh):
Build wikiversions.php in addition to wikiversions.cdb

https://gerrit.wikimedia.org/r/230662

gerritbot added a project: Patch-For-Review.Aug 10 2015, 9:46 PM
gerritbot added a comment.Aug 10 2015, 9:48 PM

Change 230662 merged by jenkins-bot:
Build wikiversions.php in addition to wikiversions.cdb

https://gerrit.wikimedia.org/r/230662

ori mentioned this in rOMWC607524367ce7: Build wikiversions.php in addition to wikiversions.cdb.Aug 10 2015, 9:48 PM
gerritbot added a comment.Aug 10 2015, 10:11 PM

Change 230679 had a related patch set uploaded (by Ori.livneh):
Build wikiversions.php in addition to wikiversions.cdb

https://gerrit.wikimedia.org/r/230679

greg added a project: Deployments.Aug 10 2015, 10:12 PM
gerritbot added a comment.Aug 10 2015, 10:49 PM

Change 230690 had a related patch set uploaded (by Ori.livneh):
Add wikiversions{-labs}.php to .gitignore

https://gerrit.wikimedia.org/r/230690

gerritbot added a comment.Aug 10 2015, 10:50 PM

Change 230690 merged by jenkins-bot:
Add wikiversions{-labs}.php to .gitignore

https://gerrit.wikimedia.org/r/230690

ori mentioned this in rOMWC79d9111a12f6: Add wikiversions{-labs}.php to .gitignore.Aug 10 2015, 10:50 PM
gerritbot added a comment.Aug 10 2015, 11:02 PM

Change 230679 merged by Ori.livneh:
Build wikiversions.php in addition to wikiversions.cdb

https://gerrit.wikimedia.org/r/230679

gerritbot added a comment.Aug 10 2015, 11:32 PM

Change 230702 had a related patch set uploaded (by Ori.livneh):
Convert multiversion scripts to use wikiversions.php

https://gerrit.wikimedia.org/r/230702

gerritbot added a comment.Aug 10 2015, 11:33 PM

Change 230702 merged by jenkins-bot:
Convert multiversion scripts to use wikiversions.php

https://gerrit.wikimedia.org/r/230702

ori mentioned this in rOMWC435506d76a27: Convert multiversion scripts to use wikiversions.php.Aug 10 2015, 11:33 PM
ori mentioned this in rMSCAa404a39b3210: Build wikiversions.php in addition to wikiversions.cdb.Aug 10 2015, 11:39 PM
ori added a subscriber: 20after4.Aug 11 2015, 12:02 AM

@20after4: This is done now, and the relevant changes have all been synced. Just an FYI that the operative file is now wikiversions.php, not wikiversions.cdb. All the tools work as before.

ori closed this task as Resolved.Aug 11 2015, 12:03 AM
ori claimed this task.
Luke081515 moved this task from Backlog to Done on the Wikimedia-Site-requests board.Aug 22 2015, 5:31 PM
Krinkle mentioned this in T99740: Use static php array files for l10n cache at WMF (instead of CDB).Sep 4 2015, 2:49 AM
Krinkle added a parent task: T99740: Use static php array files for l10n cache at WMF (instead of CDB).
Krinkle mentioned this in T127780: Convert Wikihiero to use static array files instead of ".ser" files (serialised php text).Feb 23 2016, 1:07 AM
Krinkle mentioned this in T156924: Allow integration of data from etcd into the MediaWiki configuration.Mar 4 2017, 2:55 AM
Krinkle added a parent task: T212460: Adopt static array files for local disk storage of values (epic).Dec 20 2018, 9:51 PM
Krinkle removed a parent task: T99740: Use static php array files for l10n cache at WMF (instead of CDB).
ori mentioned this in rMSCAc21d5dec0d98: Build wikiversions.php in addition to wikiversions.cdb.Feb 7 2019, 12:09 PM
ori mentioned this in rMSCA2ab97a1a9f1c: Build wikiversions.php in addition to wikiversions.cdb.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL