Page MenuHomePhabricator

Passing bad parameters to WIKIDATAPAGEBANNER should throw warnings
Closed, ResolvedPublic

Description

As an editor, if I add
{{PAGEBANNER:captionText=foo}} I should get a warning saying captionText is not a valid parameter name. This should apply to all parameters.

Bonus points if you provide a link in the warning to some template usage notes :)

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to Epics on the Wikidata-Page-Banner board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Should I add the warnings as server-side using wfWarn( ) ?

They should only show up to editors. I'm not sure if we have any existing examples to follow.

Change 239325 had a related patch set uploaded (by Florianschmidtwelzow):
Show a warning if there are unknown parameters

https://gerrit.wikimedia.org/r/239325

Change 239325 merged by jenkins-bot:
Show a warning if there are unknown parameters

https://gerrit.wikimedia.org/r/239325