Page MenuHomePhabricator
Create Task
Maniphest T109317

Passing bad parameters to WIKIDATAPAGEBANNER should throw warnings
Closed, ResolvedPublic
Actions

Description

As an editor, if I add
{{PAGEBANNER:captionText=foo}} I should get a warning saying captionText is not a valid parameter name. This should apply to all parameters.

Bonus points if you provide a link in the warning to some template usage notes :)

Details

SubjectRepoBranchLines +/-
Show a warning if there are unknown parametersmediawiki/extensions/WikidataPageBannermaster+85 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 17 2015, 3:43 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Wikidata-Page-Banner.
Jdlrobson moved this task to Epics on the Wikidata-Page-Banner board.
Jdlrobson subscribed.
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 17 2015, 3:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 17 2015, 3:43 PM
Sumit subscribed.EditedAug 17 2015, 5:52 PM

Should I add the warnings as server-side using wfWarn( ) ?

Jdlrobson added a comment.Aug 17 2015, 5:59 PM

They should only show up to editors. I'm not sure if we have any existing examples to follow.

Jdlrobson moved this task from Epics to Backlog on the Wikidata-Page-Banner board.Aug 28 2015, 7:28 PM
Florian claimed this task.Sep 18 2015, 6:32 AM
gerritbot subscribed.Sep 18 2015, 7:00 AM

Change 239325 had a related patch set uploaded (by Florianschmidtwelzow):
Show a warning if there are unknown parameters

https://gerrit.wikimedia.org/r/239325

gerritbot added a project: Patch-For-Review.Sep 18 2015, 7:00 AM
gerritbot added a comment.Sep 23 2015, 6:20 PM

Change 239325 merged by jenkins-bot:
Show a warning if there are unknown parameters

https://gerrit.wikimedia.org/r/239325

Florian mentioned this in rEWDPfd19ffa2a8aa: Show a warning if there are unknown parameters.Sep 23 2015, 6:20 PM
Diffusion mentioned this in rMEXT77b72c81a673: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Sep 23 2015, 6:20 PM
Jdlrobson closed this task as Resolved.Sep 23 2015, 6:25 PM

Thanks @Florian !

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 8:02 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits