Maniphest T109341

Link preview should snap to full screen, half screen, or dismissal positions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Niedzielski
	Aug 17 2015, 5:59 PM

Tags

Referenced Files

None

Subscribers

• Niedzielski

Description

Description

Link previews should use the bottom sheets library and design patterns in the Android Support library v23.2[0].

Steps to reproduce (1)

Engage a link preview.
Scroll down or press the spacebar so the preview is behind the continue to page button.

Steps to reproduce (2)

Engage a link preview.
Scroll down so the preview is about 1/3 open.

Steps to reproduce (3)

Engage a link preview.
Scroll up so the preview is about 2/3 open.

Expected results

When not being held, the preview should snap to dismiss, half screen, or full screen display, whichever is nearest.

Actual results

Link preview stays where it is let go.

Environments observed

App version: 773994917d6c95909af949331f4ffad73c00550a
Android OS versions: API 15
Device model: AOSP Nexus One emulator
Device language: English

[0] http://android-developers.blogspot.com/2016/02/android-support-library-232.html

Details

	Subject	Repo	Branch	Lines +/-
	Convert link preview dialog to be a native BottomSheet.	apps/android/wikipedia	master	+116 -410

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Dbrant	T109341 Link preview should snap to full screen, half screen, or dismissal positions
		Resolved		Dbrant	T128126 [Dev] Upgrade Android Support libraries to v23.2

Event Timeline

• Niedzielski created this task.Aug 17 2015, 5:59 PM

• Niedzielski raised the priority of this task from to Needs Triage.

• Niedzielski updated the task description. (Show Details)

• Niedzielski added a project: Wikipedia-Android-App-Backlog.

• Niedzielski subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2015, 5:59 PM

MBinder_WMF added a project: Essential-Work.Sep 9 2015, 7:14 PM

MBinder_WMF removed a project: Essential-Work.Sep 9 2015, 7:29 PM

• Niedzielski updated the task description. (Show Details)Nov 20 2015, 5:16 PM

• Niedzielski set Security to None.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 20 2015, 5:16 PM

Dbrant moved this task from Needs Triage to Open Questions/Discussions on the Wikipedia-Android-App-Backlog board.Jan 27 2016, 8:25 PM

This should be much greater gain and lower cost to implement now that Support v23.2 is out.

• Niedzielski added a subtask: T128126: [Dev] Upgrade Android Support libraries to v23.2.Feb 25 2016, 8:42 PM

Dbrant closed subtask T128126: [Dev] Upgrade Android Support libraries to v23.2 as Resolved.Mar 25 2016, 2:13 PM

Change 335279 had a related patch set uploaded (by Dbrant):
Convert link preview dialog to be a native BottomSheet.

https://gerrit.wikimedia.org/r/335279

gerritbot added a project: Patch-For-Review.Jan 31 2017, 9:20 PM

Dbrant claimed this task.Jan 31 2017, 9:38 PM

Dbrant moved this task from Open Questions/Discussions to Android-app-release-v2.6.19x-Bermuda🌴 on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.

Change 335279 merged by jenkins-bot:
Convert link preview dialog to be a native BottomSheet.

https://gerrit.wikimedia.org/r/335279

Dbrant moved this task from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Feb 10 2017, 2:59 PM

Dbrant closed this task as Resolved.Feb 10 2017, 3:00 PM