Page MenuHomePhabricator
Create Task
Maniphest T109365

Cancel keeps temporary text in editors
Closed, ResolvedPublic
Actions

Description

  1. Click "Edit description"
  2. Add or change the text in the editor
  3. Click "Cancel"
  4. Click "Edit description"
  5. The editor contains the text that was last entered instead of the current content of the description

Also applies to new topic and reply editors.

While keeping temporary work could be nice in some places is it misleading for editing information like the board description as it starts with the previously drafted content instead of the current content.

Details

SubjectRepoBranchLines +/-
Add a confirmation dialog for canceling editsmediawiki/extensions/Flowmaster+174 -5
Always refetch data editing descriptionmediawiki/extensions/Flowmaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.Aug 17 2015, 8:08 PM
SBisson raised the priority of this task from to Needs Triage.
SBisson updated the task description. (Show Details)
SBisson added a project: StructuredDiscussions.
SBisson subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 17 2015, 8:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Catrope subscribed.Aug 19 2015, 11:32 PM

We decided that this is a feature for new things (new reply, new topic) but a bug for editing of existing things. When you edit something that already exists, cancel should not preserve your changes.

• Catrope triaged this task as High priority.Aug 19 2015, 11:33 PM
• Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
• Catrope set Security to None.
• DannyH lowered the priority of this task from High to Medium.Aug 20 2015, 8:35 PM
• DannyH edited projects, added Collaboration-Team-Triage; removed Collaboration-Team-Archive-2015-2016.
• DannyH moved this task from Untriaged to Near-Term Interest on the Collaboration-Team-Triage board.
• DannyH subscribed.
• DannyH moved this task from Near-Term Interest to Temporary on the Collaboration-Team-Triage board.Aug 21 2015, 5:28 PM
• DannyH moved this task from Temporary to Near-Term Interest on the Collaboration-Team-Triage board.Aug 21 2015, 9:23 PM
• DannyH added a project: OKR-Work.Aug 27 2015, 7:08 PM
gerritbot subscribed.Sep 1 2015, 9:52 PM

Change 235364 had a related patch set uploaded (by Mooeypoo):
Always refetch data editing description

https://gerrit.wikimedia.org/r/235364

gerritbot added a project: Patch-For-Review.Sep 1 2015, 9:52 PM
Mooeypoo claimed this task.Sep 1 2015, 9:55 PM
Mooeypoo edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
Mooeypoo moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
gerritbot added a comment.Sep 1 2015, 9:58 PM

Change 235364 merged by jenkins-bot:
Always refetch data editing description

https://gerrit.wikimedia.org/r/235364

Diffusion mentioned this in rMEXTa3eef6d24fc6: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Sep 1 2015, 9:59 PM
Mooeypoo mentioned this in rEFLW06e56d5617ee: Always refetch data editing description.Sep 1 2015, 9:59 PM
• Forrestbot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 1 2015, 10:00 PM
Etonkovidova subscribed.EditedSep 1 2015, 11:02 PM

In betalabs:

Cancel and recommence - previous data displayed?
New topicNo
New postYes
New descriptionNo
New summaryNo
Edit titleNo
Edit postNo
Edit descriptionNo
Edit summaryNo
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 1 2015, 11:03 PM
gerritbot added a comment.Sep 2 2015, 12:23 AM

Change 235383 had a related patch set uploaded (by Mooeypoo):
Add a confirmation dialog for canceling edits

https://gerrit.wikimedia.org/r/235383

gerritbot added a comment.Sep 2 2015, 11:09 PM

Change 235383 merged by jenkins-bot:
Add a confirmation dialog for canceling edits

https://gerrit.wikimedia.org/r/235383

Mooeypoo mentioned this in rEFLWd2477fcc664a: Add a confirmation dialog for canceling edits.Sep 2 2015, 11:10 PM
Mooeypoo mentioned this in rMEXTe04809062517: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
• DannyH closed this task as Resolved.Sep 3 2015, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits