Page MenuHomePhabricator
Create Task
Maniphest T109748

Regression on production: 'Cancel' for Nested Replies (>two levels) broken
Closed, ResolvedPublic
Actions

Assigned To
Catrope
Authored By
Etonkovidova
Aug 20 2015, 6:38 PM
Tags
Referenced Files
F1948589: Screen Shot 2015-08-20 at 11.08.21 AM.png
Aug 20 2015, 6:38 PM
F1953265: Screen Shot 2015-08-20 at 11.33.30 AM.png
Aug 20 2015, 6:38 PM
F1948316: Screen Shot 2015-08-20 at 11.08.06 AM.png
Aug 20 2015, 6:38 PM
Subscribers
Aklapper
Catrope
• DannyH
Etonkovidova
gerritbot
• Mattflaschen-WMF
Quiddity

Description

  1. In betalabs create two level Replies.
  2. Then click on the upper Reply to go to the third level, e.g. 'Reply' link under 9:27 was clicked.

Screen Shot 2015-08-20 at 11.08.06 AM.png (495×759 px, 40 KB)

  1. Click 'Cancel'(or hit Esc) - the editor area container will become blank - no editing icons:

Screen Shot 2015-08-20 at 11.08.21 AM.png (431×746 px, 40 KB)

  • The editor area gets stuck - the buttons do nothing. Only reloading the page dismisses it.
  • nothing is displayed in Console
  • Repeated attempts to Reply for the level 3 nested replies will bring empty editing areas along with correctly displayed editing area.

Something like this:

Screen Shot 2015-08-20 at 11.33.30 AM.png (577×812 px, 54 KB)




UPDATED: This bug can actually be seen on Mediawiki.org now.
Details
SubjectRepoBranchLines +/-
Don't open two editors when clicking a nested reply linkmediawiki/extensions/Flowwmf/1.26wmf19+1 -1
Don't open two editors when clicking a nested reply linkmediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit
Related Objects
Event Timeline
Etonkovidova created this task.Aug 20 2015, 6:38 PM
Etonkovidova raised the priority of this task from  to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper.  ·  View Herald TranscriptAug 20 2015, 6:38 PM
Etonkovidova updated the task description. (Show Details)Aug 20 2015, 6:44 PM
Etonkovidova set Security to None.
• DannyH renamed this task from [betalabs] Regression: 'Cancel' for Nested Replies(>two levels) broken to Regression on production: 'Cancel' for Nested Replies (>two levels) broken.Aug 20 2015, 8:27 PM
• DannyH triaged this task as Unbreak Now! priority.
• DannyH updated the task description. (Show Details)
gerritbot subscribed.Aug 21 2015, 1:38 AM
Change 232881 had a related patch set uploaded (by Catrope):

Don't open two editors when clicking a nested reply link



https://gerrit.wikimedia.org/r/232881
gerritbot added a project: Patch-For-Review.Aug 21 2015, 1:38 AM
• Mattflaschen-WMF assigned this task to Catrope.Aug 21 2015, 5:33 PM
• Mattflaschen-WMF moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
• Mattflaschen-WMF subscribed.
Catrope moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Aug 21 2015, 5:33 PM
• DannyH added a project: Essential-Work.Aug 21 2015, 11:17 PM
• DannyH edited projects, added OKR-Work; removed Essential-Work.
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Aug 24 2015, 2:19 PM
gerritbot added a comment.Aug 24 2015, 2:38 PM
Change 232881 merged by jenkins-bot:

Don't open two editors when clicking a nested reply link



https://gerrit.wikimedia.org/r/232881
Diffusion mentioned this in rMEXT1e425b1e28bf: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Aug 24 2015, 2:38 PM
Catrope mentioned this in rEFLW522a55a6efe7: Don't open two editors when clicking a nested reply link.Aug 24 2015, 2:40 PM
• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 24 2015, 3:00 PM
Etonkovidova added a comment.Aug 24 2015, 4:44 PM
Checked in betalabs - all is fixed for 8 level of nesting; no new issues have been found.
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Aug 24 2015, 4:46 PM
• DannyH closed this task as Resolved.Aug 24 2015, 8:39 PM
• DannyH subscribed.
• Mattflaschen-WMF added a comment.Aug 25 2015, 12:51 AM
If this is the same error that happens when you click 'Reply' on 'Has this stuff been fixed' at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Breakfast , it's quite disruptive in practice.



I think this should be cherry-picked.
gerritbot added a comment.Aug 25 2015, 12:53 AM
Change 233650 had a related patch set uploaded (by Mattflaschen):

Don't open two editors when clicking a nested reply link



https://gerrit.wikimedia.org/r/233650
• Mattflaschen-WMF reopened this task as Open.Aug 25 2015, 5:50 PM
• Mattflaschen-WMF closed this task as a duplicate of T110219: Clicking "reply" on specific posts in Flow, will open multiple edit-areas.
• Mattflaschen-WMF merged a task: T110219: Clicking "reply" on specific posts in Flow, will open multiple edit-areas.
• Mattflaschen-WMF added subscribers: Catrope, Quiddity.
gerritbot added a comment.Aug 26 2015, 1:41 AM
Change 233650 merged by jenkins-bot:

Don't open two editors when clicking a nested reply link



https://gerrit.wikimedia.org/r/233650
Diffusion mentioned this in rMWf26d087338e2: Updated mediawiki/core Project: mediawiki/extensions/Flow….Aug 26 2015, 1:41 AM
• Mattflaschen-WMF mentioned this in rEFLW5ae68835ef30: Don't open two editors when clicking a nested reply link.Aug 26 2015, 1:42 AM
• Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 26 2015, 2:00 AM
• DannyH closed this task as Resolved.Aug 26 2015, 5:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL