Page MenuHomePhabricator

Regression on production: 'Cancel' for Nested Replies (>two levels) broken
Closed, ResolvedPublic

Description

  1. In betalabs create two level Replies.
  2. Then click on the upper Reply to go to the third level, e.g. 'Reply' link under 9:27 was clicked.

Screen Shot 2015-08-20 at 11.08.06 AM.png (495×759 px, 40 KB)

  1. Click 'Cancel'(or hit Esc) - the editor area container will become blank - no editing icons:

Screen Shot 2015-08-20 at 11.08.21 AM.png (431×746 px, 40 KB)

  • The editor area gets stuck - the buttons do nothing. Only reloading the page dismisses it.
  • nothing is displayed in Console
  • Repeated attempts to Reply for the level 3 nested replies will bring empty editing areas along with correctly displayed editing area.

Something like this:

Screen Shot 2015-08-20 at 11.33.30 AM.png (577×812 px, 54 KB)

UPDATED: This bug can actually be seen on Mediawiki.org now.

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a subscriber: Etonkovidova.
DannyH renamed this task from [betalabs] Regression: 'Cancel' for Nested Replies(>two levels) broken to Regression on production: 'Cancel' for Nested Replies (>two levels) broken.Aug 20 2015, 8:27 PM
DannyH triaged this task as Unbreak Now! priority.
DannyH updated the task description. (Show Details)

Change 232881 had a related patch set uploaded (by Catrope):
Don't open two editors when clicking a nested reply link

https://gerrit.wikimedia.org/r/232881

Change 232881 merged by jenkins-bot:
Don't open two editors when clicking a nested reply link

https://gerrit.wikimedia.org/r/232881

Checked in betalabs - all is fixed for 8 level of nesting; no new issues have been found.

DannyH added a subscriber: DannyH.

If this is the same error that happens when you click 'Reply' on 'Has this stuff been fixed' at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Breakfast , it's quite disruptive in practice.

I think this should be cherry-picked.

Change 233650 had a related patch set uploaded (by Mattflaschen):
Don't open two editors when clicking a nested reply link

https://gerrit.wikimedia.org/r/233650

Change 233650 merged by jenkins-bot:
Don't open two editors when clicking a nested reply link

https://gerrit.wikimedia.org/r/233650