Page MenuHomePhabricator
Create Task
Maniphest T109979

Footer icons and copyright link ignores $wgExternalLinkTarget
Closed, ResolvedPublic
Actions

Description

The setting $wgExternalLinkTarget is ignored in some links in the footer:

  • Powered by MediaWiki icon (and probably any other $wgFooterIcons)
  • License icon (in Monobook may be rendered differently from other footer icons, since it's left-floated instead of right)
  • Link to the license terms.

See issue in Support Desk

See also:

Details

SubjectRepoBranchLines +/-
Modify footer icons to use $wgExternalLinkTargetmediawiki/coremaster+4 -1
Footer icons modified to follow $wgExternalLinkTargetmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Ciencia_Al_Poder created this task.Aug 23 2015, 2:58 PM
Ciencia_Al_Poder raised the priority of this task from to Needs Triage.
Ciencia_Al_Poder updated the task description. (Show Details)
Ciencia_Al_Poder added projects: MediaWiki-General, good first task.
Ciencia_Al_Poder subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2015, 2:58 PM
Saptak013 subscribed.Sep 29 2015, 2:08 AM

Can you provide me some example links where I can see this errors?

Ciencia_Al_Poder added a comment.Sep 29 2015, 9:32 AM

@Saptak013

  1. Install MediaWiki,
  2. set $wgExternalLinkTarget = '_blank'; in LocalSettings.php.
  3. You'll see that clicking the Powered by MediaWiki icon, License icon or the Link to the license terms in the footer loads on the same page instead of opening a new page
Aklapper added a comment.Sep 29 2015, 10:13 AM

Hi @Saptak013, for general information how to get started working on code (and how to install MediaWiki yourself), please see How to become a MediaWiki hacker. Thanks & looking forward to your patch!

Saptak013 added a comment.Sep 29 2015, 5:24 PM

ok.. Got it..

Saptak013 added a comment.Oct 2 2015, 8:40 PM

Pushed for a gerrit review. https://gerrit.wikimedia.org/r/#/c/243232/ . Please verify.

gerritbot subscribed.Oct 3 2015, 9:19 AM

Change 243232 had a related patch set uploaded (by Martineznovo):
Footer icons modified to follow $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/243232

gerritbot added a project: Patch-For-Review.Oct 3 2015, 9:19 AM
gerritbot added a comment.Oct 4 2015, 6:50 AM

Change 243484 had a related patch set uploaded (by Saptak013):
Footer icons modified to follow $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/243484

Saptak013 added a comment.Oct 4 2015, 6:52 AM

Modified the commit to follow the mediawiki convention.
https://gerrit.wikimedia.org/r/#/c/243484/ Please check

Aklapper added a comment.Oct 4 2015, 8:53 AM

(No need to add duplicated comments - gerritbot already notifies this task about related patches.)

gerritbot added a comment.Oct 4 2015, 10:12 AM

Change 243232 abandoned by Saptak013:
Footer icons modified to follow $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/243232

Umherirrender removed a project: Patch-For-Review.Dec 28 2015, 8:31 PM
Umherirrender set Security to None.
Umherirrender removed a subscriber: gerritbot.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 28 2015, 8:31 PM
Ciencia_Al_Poder assigned this task to Saptak013.Dec 28 2015, 9:39 PM
Ciencia_Al_Poder added a project: Patch-For-Review.

There's still a patch for review...

EddieGP removed a project: Patch-For-Review.Feb 19 2017, 10:32 PM
EddieGP subscribed.

Patch was abandoned. @Ciencia_Al_Poder are you going to work on this? If not, I might have a look.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptFeb 19 2017, 10:32 PM
Ciencia_Al_Poder added a comment.Feb 20 2017, 8:23 PM

I'm not going to work on it, but https://gerrit.wikimedia.org/r/#/c/243484/ is still alive. Needs a rebase though

EddieGP added a comment.Feb 23 2017, 2:36 PM

Was rebased.

EddieGP mentioned this in E514: Code Review Office Hours.Feb 23 2017, 4:25 PM
gerritbot added a comment.Mar 1 2017, 7:55 PM

Change 243484 merged by jenkins-bot:
Modify footer icons to use $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/243484

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), MW-1.29-release-notes.Mar 1 2017, 8:00 PM
Ciencia_Al_Poder closed this task as Resolved.Mar 1 2017, 8:35 PM
EddieGP claimed this task.Mar 1 2017, 10:26 PM
EddieGP mentioned this in E515: Code Review Office Hours.Mar 1 2017, 11:09 PM
EddieGP triaged this task as Medium priority.Mar 3 2017, 7:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits