Page MenuHomePhabricator
Create Task
Maniphest T110403

Huge langlinks list on top of mobile login page
Closed, ResolvedPublic
Actions

Description

Have a look on this wonderful login page for dewiki:

Unbenannt.PNG (650×374 px, 41 KB)

It's alpha and beta only (where we have core login page) on an emulated Nexus 5. That looks terrible and the languagelinks should be hidden for now (and maybe replaced with a nicer language selection, maybe a dropdown?

The list is created here:
https://github.com/wikimedia/mediawiki/blob/d1fb1a2d0e1878aac70b3767c58ef6b3a1aa065f/includes/specials/SpecialUserlogin.php#L1649-L1666

And is a simply mediawiki message key and needs to be enabled with $wgLoginLanguageSelector (for local testing e.g.).

Details

SubjectRepoBranchLines +/-
WIP: Convert UserLogin language links into a dropdown select listmediawiki/coremaster+36 -36
Hide languagelinks list on alpha/beta login pagemediawiki/extensions/MobileFrontendmaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Aug 26 2015, 9:22 PM
Florian assigned this task to Jdlrobson.
Florian claimed this task.
Florian raised the priority of this task from to High.
Florian updated the task description. (Show Details)
Florian added projects: Reading-Web-Planning, MobileFrontend, Epic, WMF-deploy-2015-08-18_(1.26wmf19), Patch-For-Review, Technical-Debt, Tracking-Neverending.
Florian added subscribers: • Jhernandez, gerritbot, Aklapper and 3 others.
Florian added a subscriber: Jdlrobson.
Florian updated the task description. (Show Details)Aug 26 2015, 9:26 PM
Florian set Security to None.
gerritbot added a comment.Aug 26 2015, 9:30 PM

Change 234149 had a related patch set uploaded (by Florianschmidtwelzow):
Hide languagelinks list on alpha/beta login page

https://gerrit.wikimedia.org/r/234149

gerritbot added a comment.Aug 26 2015, 10:17 PM

Change 234163 had a related patch set uploaded (by Florianschmidtwelzow):
WIP: Convert UserLogin language links into a dropdown select list

https://gerrit.wikimedia.org/r/234163

Florian removed projects: Tracking-Neverending, Technical-Debt, WMF-deploy-2015-08-18_(1.26wmf19), Epic, Reading-Web-Planning.Aug 26 2015, 10:20 PM
Jdlrobson added a project: Language-Team.Aug 26 2015, 10:21 PM
Jdlrobson added a subscriber: Amire80.Aug 26 2015, 10:23 PM
Jdlrobson added a comment.Aug 26 2015, 10:26 PM

@Florian thanks for the patch! I'm not sure from a design perspective if using a drop down is the best idea. I suspect something like ULS would be better ran here (with search interface, preferred languages etc). The mobile blue button should arguably be showing on the login form under the login form for switching languages.

Language engineering - this kind of problem keeps coming up - we serve large chunks of HTML in pages for all the languages we support in a way that impacts mobile readability. I really think language selection should be JavaScript based everywhere with a link as a fallback to a page such as https://en.m.wikipedia.org/wiki/Special:MobileLanguages/San_Francisco

It seems to be a problem with our infrastructure which keeps hurting mobile and I'm keen to address it. @Amire80 is it worth us having some kind of chat around the strategy for this kind of thing?

gerritbot added a comment.Aug 27 2015, 6:37 PM

Change 234149 merged by jenkins-bot:
Hide languagelinks list on alpha/beta login page

https://gerrit.wikimedia.org/r/234149

Florian mentioned this in rEMFRbf4ec7dab024: Hide languagelinks list on alpha/beta login page.Aug 27 2015, 6:37 PM
Diffusion mentioned this in rMEXTcc3260bfe084: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 27 2015, 6:37 PM
Florian removed a project: Patch-For-Review.Aug 27 2015, 6:56 PM

I removed the Patch-For-Review project, because there is no change anymore to review. But the real underlying problem (having a bad formatted huge list of languages) still isn't resolved, so keeping this task open :)

Florian removed a parent task: T74910: Getting rid of own login page (tracking).Aug 27 2015, 6:58 PM
• Forrestbot added a project: WMF-deploy-2015-09-01_(1.26wmf21).Aug 27 2015, 7:00 PM
gerritbot added a comment.Sep 2 2015, 5:23 PM

Change 234163 abandoned by Florianschmidtwelzow:
WIP: Convert UserLogin language links into a dropdown select list

Reason:
It's still in gerrit, but I actually don't work on it, until there is some consensus in the task :)

https://gerrit.wikimedia.org/r/234163

Jdlrobson moved this task from Backlog to team:other on the MobileFrontend board.Sep 2 2015, 6:57 PM
Jdlrobson renamed this task from Huge langlinks list on top of alpha/beta login page to Huge langlinks list on top of mobile login page.Sep 9 2015, 7:54 PM
Jdlrobson removed a project: MobileFrontend.
Jdlrobson added a project: MediaWiki-User-login-and-signup.
Florian removed Florian as the assignee of this task.Nov 25 2015, 8:14 PM

I'm not working on this.

Aklapper closed this task as Resolved.Sep 20 2016, 2:05 PM
Aklapper claimed this task.

Being logged out and going to https://de.m.wikipedia.org/w/index.php?title=Spezial:Anmelden I cannot reproduce this anymore. No section of languages is displayed on top.

Closing as resolved; please reopen if this is still a problem.

Jdlrobson added a comment.Sep 20 2016, 2:44 PM

We hid them... this is why it's not there.
I've created T146151 rather than repurpose the bug to make that clearer.

Liuxinyu970226 unsubscribed.Sep 21 2016, 9:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits