Banners should support extraClassNames parameter
Closed, ResolvedPublic
Actions

Description

Create a generic "extraClassNames" parameter to add one or more CSS class names to the banner wrapper.
This for instance allows solving of the problem of dark text on dark banners.
The overall banner theme could be flipped, like replacing dark with white and white with dark.
usage:

{{PAGEBANNER:|extraClass=darkOnWhite otherClassName|}}

Details

	Subject	Repo	Branch	Lines +/-
	Added WikidataPageBanner support for extraClass	mediawiki/extensions/WikidataPageBanner	master	+21 -1

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Aug 31 2015, 4:37 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Wikidata-Page-Banner.

Jdlrobson moved this task to Epics on the Wikidata-Page-Banner board.

Jdlrobson subscribed.

Restricted Application added a project: Wikidata. · View Herald TranscriptAug 31 2015, 4:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Sep 1 2015, 11:16 AM

Jdlrobson triaged this task as High priority.Sep 4 2015, 12:31 AM

Jdlrobson added a project: good first task.

Jdlrobson set Security to None.

Jdlrobson lowered the priority of this task from High to Medium.Oct 9 2015, 8:08 PM

Jdlrobson added a project: Google-Code-In-2015.Oct 28 2015, 10:37 PM

I'd be ready to mentor this in GCI 2015.

Sumit updated the task description. (Show Details)Dec 3 2015, 7:04 PM

Imported as https://codein.withgoogle.com/dashboard/tasks/5166743517396992/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 5 2015, 3:56 PM

I am currently working on implementing this feature. The model I have in mind is this one: property name will be extraClasses.

The property will support multiple classes separated by semicolons ; (I believe semicolon will not create any conflict in the syntax).

I am waiting for you feedback. Thank you!

You can let the classes remain separated by space, as in the example.

In T110904#1878556, @Sumit wrote:

You can let the classes remain separated by space, as in the example.

I haven't seen the example. Then I'll implement it as it is in the example

Change 259152 had a related patch set uploaded (by Victorbarbu):
Added WikidataPageBanner support for extraClass

https://gerrit.wikimedia.org/r/259152

gerritbot added a project: Patch-For-Review.Dec 14 2015, 9:50 PM

Adding a php unit test might be advisable before calling this completely done!

Jdlrobson removed a project: Wikidata.Dec 14 2015, 10:21 PM

Thanks @Victorbarbu! :)

My pleasure!

If it is still needed, I could try writing some tests, but I am not sure what could go wrong.

Change 259152 merged by jenkins-bot:
Added WikidataPageBanner support for extraClass

https://gerrit.wikimedia.org/r/259152

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)).Dec 15 2015, 7:00 PM

@Victorbarbu yeh I think it might be overkill - we are probably good without them!

Banners should support extraClassNames parameterClosed, ResolvedPublicActions

Description

Details

Event Timeline

Banners should support extraClassNames parameter
Closed, ResolvedPublic
Actions