Dates missing on Special:Notifications in many languages
Closed, ResolvedPublic

Quiddity created this task.Aug 31 2015, 9:24 PM
Quiddity updated the task description. (Show Details)
Quiddity raised the priority of this task from to Needs Triage.
Quiddity added a project: Notifications.
Quiddity added a subscriber: Quiddity.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 31 2015, 9:24 PM
Restricted Application added subscribers: Josve05a, Aklapper. · View Herald Transcript
Quiddity renamed this task from Date missing in Serbian Echo special:notifications to Date missing in Serbian Echo special:notifications.Aug 31 2015, 9:24 PM
Quiddity set Security to None.

What language does "sr" end up being? Echo has files for sr-ec.json and sr-el.json, no sr.json.

I think this has to do with wfGetLangObj( 'sr-ec' )->getDateFormatString( 'pretty', 'default' ) returning null.

Quiddity renamed this task from Date missing in Serbian Echo special:notifications to Date missing in Serbian, Croatian and Slovenian Echo special:notifications.Sep 1 2015, 1:09 AM
Legoktm claimed this task.Sep 1 2015, 5:07 PM

In Language::getDateFormatString(), we're not falling back to the date type if pretty is not available when using default mode. It's still unclear to me as to why this only affects the sr variants though.

Change 235268 had a related patch set uploaded (by Legoktm):
Language: Fix 'pretty' fallback in getDateFormatString()

https://gerrit.wikimedia.org/r/235268

This affects significantly more than Serbian, Croatian and Slovenian...confirmed using the same script that all instances are fixed with my patch.

1cdo: BAD
2ce: BAD
3cs: BAD
4fi: BAD
5fit: BAD
6fy: BAD
7gan: BAD
8gan-hans: BAD
9gan-hant: BAD
10hr: BAD
11ii: BAD
12is: BAD
13ja: BAD
14km: BAD
15ko: BAD
16ko-kp: BAD
17lzh: BAD
18my: BAD
19nan: BAD
20nn: BAD
21oc: BAD
22pnt: BAD
23sl: BAD
24sr: BAD
25sr-ec: BAD
26sr-el: BAD
27th: BAD
28vi: BAD
29vo: BAD
30vot: BAD
31wuu: BAD
32yue: BAD
33za: BAD
34zh: BAD
35zh-classical: BAD
36zh-cn: BAD
37zh-hans: BAD
38zh-hant: BAD
39zh-hk: BAD
40zh-min-nan: BAD
41zh-mo: BAD
42zh-my: BAD
43zh-sg: BAD
44zh-tw: BAD
45zh-yue: BAD

Legoktm renamed this task from Date missing in Serbian, Croatian and Slovenian Echo special:notifications to Dates missing on Special:Notifications in many languages.Sep 1 2015, 9:43 PM
Legoktm triaged this task as High priority.

(The script I used to generated the list was P1963).

Change 235268 merged by jenkins-bot:
Language: Fix 'pretty' fallback in getDateFormatString()

https://gerrit.wikimedia.org/r/235268

Checked locally - e.g. http://127.0.0.1:8080/w/index.php?title=Special:Notifications&uselang=sr-el and uselang=sr-el.

Checked in betalabs - general regression testing for Notifications display.

Note: 'User Preferences - Date format' was set to Default which is different from one lang to another . Some of dates formats look not typical: e,g, userlang: sr-el
'20. AVGUST 2015.'

DannyH closed this task as Resolved.Sep 3 2015, 4:34 PM
DannyH added a subscriber: DannyH.