Page MenuHomePhabricator

Duplicate icons: 'puzzle' icon and 'template' (in VE)
Closed, ResolvedPublic1 Estimated Story Points

Description

pasted_file (35×104 px, 1 KB)

pasted_file (32×89 px, 1 KB)

Also this icon should probably be converted to a puzzle piece:

pasted_file (41×146 px, 1 KB)

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: OOUI.
Esanders subscribed.
Esanders renamed this task from Merge 'puzzle' icon with 'template' (in VE) to Duplicate icons: Merge 'puzzle' icon with 'template' (in VE).Sep 1 2015, 1:43 PM
Esanders renamed this task from Duplicate icons: Merge 'puzzle' icon with 'template' (in VE) to Duplicate icons: 'puzzle' icon and 'template' (in VE).
Esanders reopened this task as Open.
Esanders set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Volker_E added subscribers: Jdforrester-WMF, Volker_E.

@Esanders @Jdforrester-WMF Is 'puzzle' in use anywhere? I couldn't find icon: 'puzzle' either in core or VE.

@Esanders @Jdforrester-WMF Is 'puzzle' in use anywhere? I couldn't find icon: 'puzzle' either in core or VE.

Nope. VE has kept using it's "original" icon, and AFAIAA nothing else tries to pictographically reflect the concept of a template. We could just upstream VE's item, over-writing the current icon, and switch to that?

Design team, foremost @RHo is in the process of aligning all icons to our style guide. What were the specific advantages of the VE icon over the current OOjs UI one?

image.png (84×182 px, 3 KB)
vs
image.png (166×878 px, 11 KB)

Change 362242 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] icons: Replace the puzzle icon, using the one from VisualEditor

https://gerrit.wikimedia.org/r/362242

@Volker_E - happy to go with the VE one in use, under the assumption the VE one will be updated slightly as part of the coming icon set (e.g., the curved left and right hand sides of the puzzle shape will be straightened)

Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.22.3 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.22.3); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.

Change 363631 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Drop local 'template' icon, use 'puzzle' from upstream

https://gerrit.wikimedia.org/r/363631

Change 362242 merged by jenkins-bot:
[oojs/ui@master] icons: Replace the puzzle icon, using the one from VisualEditor

https://gerrit.wikimedia.org/r/362242

Jdforrester-WMF changed the point value for this task from 1 to 0.Jul 14 2017, 11:20 PM
Jdforrester-WMF changed the point value for this task from 0 to 1.
Jdforrester-WMF removed a project: Patch-For-Review.

Change 363631 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Drop local 'template' icon, use 'puzzle' from upstream

https://gerrit.wikimedia.org/r/363631