Page MenuHomePhabricator
Create Task
Maniphest T111958

Lead paragraph shifting improperly terminates when a list is encountered
Closed, ResolvedPublic
Actions

Description

The JavaScript transform in relocateFirstParagraph.js apparently doesn't handle lists, resulting in a misplaced infobox in cases such as the article "Planet":

Screenshot_2015-09-09-10-16-24.png (1×720 px, 328 KB)

Details

SubjectRepoBranchLines +/-
Prevent lead paragraph shifting from leaving connected content behindapps/android/wikipediamaster+129 -58
Customize query in gerrit

Related Objects

Event Timeline

• Mholloway created this task.Sep 9 2015, 3:15 PM
• Mholloway raised the priority of this task from to Needs Triage.
• Mholloway updated the task description. (Show Details)
• Mholloway added a project: Wikipedia-Android-App-Backlog.
• Mholloway moved this task to Needs Triage on the Wikipedia-Android-App-Backlog board.
• Mholloway subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 3:15 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Sep 9 2015, 7:11 PM
Dbrant added a project: Essential-Work.
Dbrant subscribed.
• Mholloway claimed this task.Oct 9 2015, 8:29 PM
• Mholloway set Security to None.
• Mholloway added a project: Mobile-App-Android-Sprint-67-Holmium.
• Mholloway moved this task from To Do to Doing on the Mobile-App-Android-Sprint-67-Holmium board.
• Mholloway moved this task from Bug Backlog to Current Sprint on the Wikipedia-Android-App-Backlog board.
• Mholloway unsubscribed.
gerritbot subscribed.Oct 12 2015, 7:11 PM

Change 245576 had a related patch set uploaded (by Mholloway):
Prevent lead paragraph shifting from leaving connected content behind

https://gerrit.wikimedia.org/r/245576

gerritbot added a project: Patch-For-Review.Oct 12 2015, 7:11 PM
• Mholloway moved this task from Doing to Code Review on the Mobile-App-Android-Sprint-67-Holmium board.Oct 12 2015, 7:12 PM
Dbrant edited projects, added Mobile-App-Android-Sprint-68-Erbium; removed Mobile-App-Android-Sprint-67-Holmium.Oct 13 2015, 2:38 PM
Dbrant moved this task from To Do to Code Review on the Mobile-App-Android-Sprint-68-Erbium board.
gerritbot added a comment.Oct 14 2015, 6:18 PM

Change 245576 merged by jenkins-bot:
Prevent lead paragraph shifting from leaving connected content behind

https://gerrit.wikimedia.org/r/245576

• Mholloway moved this task from Code Review to QA Signoff on the Mobile-App-Android-Sprint-68-Erbium board.Oct 14 2015, 6:20 PM
Etonkovidova subscribed.Oct 21 2015, 7:25 PM

Checked with 2.0.131-alpha-2015-10-21 on Nexus 5 API 22.

Screen Shot 2015-10-21 at 12.23.31 PM.png (787×486 px, 218 KB)

NOTE: iOS with 5.0.0 (411) still has the issue.
Etonkovidova moved this task from QA Signoff to Ready for Signoff on the Mobile-App-Android-Sprint-68-Erbium board.Oct 21 2015, 7:26 PM
Dbrant moved this task from Ready for Signoff to Done on the Mobile-App-Android-Sprint-68-Erbium board.Oct 22 2015, 7:35 PM
Dbrant closed this task as Resolved.Oct 26 2015, 3:17 PM
Dbrant moved this task from Current Sprint to Resolved/Invalid/Declined/Legacy on the Wikipedia-Android-App-Backlog board.Oct 26 2015, 3:27 PM
Jdlrobson mentioned this in T149852: Lead introduction edge case in MobileFrontend where paragraph precedes list element.Nov 2 2016, 9:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL