Customize query in gerrit
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Deskana | T119535 EPIC: Create a Beta Feature for the new completion suggester so that users can give us feedback on it | |||
| Resolved | dcausse | T119989 Turn on completion suggester beta feature on all Wikimedia wikis on Thursday 17th December 2015 | |||
| Resolved | dcausse | T112028 Implement completion suggester as a Beta Feature |
Event Timeline
Comment Actions
Change 237692 had a related patch set uploaded (by DCausse):
Add searchSuggestions to SearchEngine
Comment Actions
Change 237693 had a related patch set uploaded (by DCausse):
Implement searchSuggestions from SearchEngine
Comment Actions
Taking this off the sprint board to reflect reality; this just isn't being prioritised right now.
Comment Actions
We talked in the planning meeting yesterday that we should start this out as an opt-in beta feature. There are some high-level instructions for beta features here: https://www.mediawiki.org/wiki/Beta_Features#Creating_your_own
From within php code the check is something like:
if ( class_exists( 'BetaFeatures' ) && BetaFeatures::isFeatureEnabled( $GLOBALS['wgUser'], 'my-feature-name' ) ) {
// enabled
} else {
// disabled
}To add this to the beta features dialog (in user preferences) we need a hook handler similar to MultimediaViewer: https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/master/MultimediaViewerHooks.php#L243-L263
That has to be added to $wgHooks in the top level CirrusSearch.php file, something like:
$wgHooks['GetBetaFeaturePreferences'][] = 'CirrusSearch\Hooks::getBetaFeaturePreferences'
If everything works right it should end up in the beta features user preferences, such as: https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-betafeatures
Comment Actions
Change 256407 had a related patch set uploaded (by DCausse):
Extracted some code from PrefixSearch for re-usability by other search engines.
Comment Actions
Change 256407 merged by jenkins-bot:
Extracted some code from PrefixSearch for re-usability by other search engines.
Comment Actions
This will need the titlesuggest indices built for all wikis, and some way of updating them since they can't be built in real time by normal edits.
I've created https://gerrit.wikimedia.org/r/256974 to add definitions that allow the titlesuggest indices to be built, not sure yet about updating them. The obvious way would be a cron job of some sort via puppet. Following other examples, such as modules/mediawiki/manifests/maintenance/pagetriage.pp, we would create a cirrussearch.pp and add mediawiki::maintenance::cirrussearch to terbium.
Comment Actions
Change 258068 had a related patch set uploaded (by EBernhardson):
[WIP] Cron job to rebuild completion indices
Comment Actions
Change 258068 had a related patch set uploaded (by EBernhardson):
Cron job to rebuild completion indices
Comment Actions
on terbium:
Notice: /Stage[main]/Mediawiki::Maintenance::Cirrussearch/Cron[cirrus_build_completion_indices_eqiad]/ensure: created
Notice: /Stage[main]/Mediawiki::Maintenance::Cirrussearch/File[/var/log/mediawiki/cirrus-suggest]/ensure: created
Notice: /Stage[main]/Mediawiki::Maintenance::Cirrussearch/Cron[cirrus_build_completion_indices_codfw]/ensure: created
Notice: /Stage[main]/Mediawiki::Maintenance::Cirrussearch/File[/etc/logrotate.d/cirrus-suggest]/ensure: defined content as