Page MenuHomePhabricator
Create Task
Maniphest T112461

Api html output doesn't produce url for source because of new URL format
Closed, ResolvedPublic
Actions

Description

The link to the source should be a clickable url. That's not the case right now.

http://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&srcountry=nl&srlang=nl&srid=1234

Details

SubjectRepoBranchLines +/-
Fix parsing of source URLslabs/tools/heritagemaster+4 -6
Customize query in gerrit

Related Objects

Event Timeline

Multichill created this task.Sep 13 2015, 1:47 PM
Multichill raised the priority of this task from to Needs Triage.
Multichill updated the task description. (Show Details)
Multichill added a project: Wiki-Loves-Monuments-API.
Multichill added subscribers: Ahonc, Aklapper, JeanFred, Multichill.
Ahonc merged a task: T57657: Source link does not recognise https protocol.Sep 13 2015, 1:50 PM
Ahonc added subscribers: Base, • wikibugs-l-list.
Base closed this task as a duplicate of T57657: Source link does not recognise https protocol.Sep 13 2015, 6:56 PM
Ricordisamoa subscribed.Sep 25 2015, 7:00 PM
gerritbot subscribed.Sep 26 2015, 12:25 AM

Change 241253 had a related patch set uploaded (by Jean-Frédéric):
Fix parsing of source URLs

https://gerrit.wikimedia.org/r/241253

gerritbot added a project: Patch-For-Review.Sep 26 2015, 12:25 AM

Change 241253 merged by jenkins-bot:
Fix parsing of source URLs

https://gerrit.wikimedia.org/r/241253

JeanFred mentioned this in rTHER2be5c388e701: Fix parsing of source URLs.Sep 26 2015, 12:27 AM
JeanFred renamed this task from Api html output doesn't produce url for source to Api html output doesn't produce url for source because of new URL format.Sep 26 2015, 12:30 AM
JeanFred changed the task status from Duplicate to Resolved.
JeanFred claimed this task.
JeanFred mentioned this in T57657: Source link does not recognise https protocol.
JeanFred set Security to None.
Ahonc added a project: WMUA-WLM-2015.Oct 13 2015, 8:30 PM
intracer moved this task from Backlog to Done on the WMUA-WLM-2015 board.Oct 13 2015, 8:32 PM
Antanana reopened this task as Open.Oct 13 2015, 8:41 PM
Antanana subscribed.

It does not work for Ukrainian lists: http://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&srcountry=ua&srlang=uk&srid=80-391-1424&props=image|name|address|municipality|lat|lon|id|country|source|monument_article|registrant_url

intracer moved this task from Done to Backlog on the WMUA-WLM-2015 board.Oct 13 2015, 8:55 PM
intracer moved this task from Backlog to Not Us on the WMUA-WLM-2015 board.
Ahonc edited subscribers, added: WMUA-WLM-2015; removed: Antanana, Base, Ahonc.Oct 13 2015, 9:22 PM
JeanFred closed this task as Resolved.Oct 15 2015, 8:55 AM
JeanFred added a subscriber: Antanana.
In T112461#1723223, @Antanana wrote:

It does not work for Ukrainian lists: http://tools.wmflabs.org/heritage/api/api.php?action=search&format=html&srcountry=ua&srlang=uk&srid=80-391-1424&props=image|name|address|municipality|lat|lon|id|country|source|monument_article|registrant_url

I’m pretty sure this is T112460 (possibly complicated further by T111526)

• Phabricator_maintenance removed subscribers: WMUA-WLM-2015, • wikibugs-l-list.Jul 30 2016, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits