Page MenuHomePhabricator
Create Task
Maniphest T113421

Banner history: always send a temporary log ID, and never send back two logs on the same pageview
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In the code now, we send a temporary ID only on logs sent when the user clicks on "Donate". Also, there is a chance that the log could be sent back more than once on the same pageview (if the pageview is sampled and sends the log back, and then the user clicks on "Donate"). This wouldn't allow cleanly distinguishing page views that were definitely not associated with a donation. The changes mentioned in the title would fix it.

Details

SubjectRepoBranchLines +/-
BannerHistoryLogger: always send log ID, never send twicemediawiki/extensions/CentralNoticewmf_deploy+57 -42
BannerHistoryLogger: always send log ID, never send twicemediawiki/extensions/CentralNoticemaster+57 -42
Customize query in gerrit

Related Objects

Event Timeline

AndyRussG created this task.Sep 22 2015, 10:00 PM
AndyRussG claimed this task.
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG added projects: Fundraising Sprint Tom Waits, MediaWiki-extensions-CentralNotice.
AndyRussG moved this task to Backlog on the Fundraising Sprint Tom Waits board.
AndyRussG added subscribers: AndyRussG, • ellery.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2015, 10:00 PM
AndyRussG moved this task from Backlog to Doing on the Fundraising Sprint Tom Waits board.Sep 22 2015, 10:01 PM
AndyRussG set Security to None.
AndyRussG edited a custom field.
• atgo added a project: Fundraising-Backlog.Sep 23 2015, 9:36 PM
• atgo moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.
gerritbot subscribed.Sep 25 2015, 4:07 AM

Change 240960 had a related patch set uploaded (by AndyRussG):
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/240960

gerritbot added a project: Patch-For-Review.Sep 25 2015, 4:07 AM
AndyRussG moved this task from Doing to Review on the Fundraising Sprint Tom Waits board.Sep 25 2015, 4:09 AM
gerritbot added a comment.Sep 28 2015, 5:30 PM

Change 240960 merged by Ejegg:
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/240960

Ejegg mentioned this in rECNO816518c212ef: BannerHistoryLogger: always send log ID, never send twice.Sep 28 2015, 5:30 PM
AndyRussG mentioned this in rMEXT65712a72ce0a: Updated mediawiki/extensions Project: mediawiki/extensions/CentralNotice….Sep 28 2015, 5:30 PM
awight moved this task from Review to Pending Deployment on the Fundraising Sprint Tom Waits board.Sep 28 2015, 9:53 PM
gerritbot added a comment.Sep 28 2015, 10:23 PM

Change 241926 had a related patch set uploaded (by AndyRussG):
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/241926

gerritbot added a comment.Sep 28 2015, 10:31 PM

Change 241926 merged by jenkins-bot:
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/241926

AndyRussG mentioned this in rECNOd2593e89ed81: BannerHistoryLogger: always send log ID, never send twice.Sep 28 2015, 10:31 PM
AndyRussG mentioned this in rMW3e7e24a69770: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….
AndyRussG mentioned this in rMWbb65aafa4688: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….
AndyRussG mentioned this in rMW08b5f6f41276: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….
AndyRussG mentioned this in rMW89f37706631a: Updated mediawiki/core Project: mediawiki/extensions/CentralNotice….
AndyRussG closed this task as Resolved.Sep 29 2015, 1:27 AM
AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Tom Waits board.
• DStrine added a project: Unplanned-Sprint-Work.Sep 30 2015, 8:29 PM
• DStrine moved this task from Closed Sprint Work Q1 1516 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Oct 5 2015, 5:26 PM
• DStrine moved this task from Closed Sprint Work Completed in Q2 1516 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits