Page MenuHomePhabricator

Banner history: always send a temporary log ID, and never send back two logs on the same pageview
Closed, ResolvedPublic1 Story Points

Description

In the code now, we send a temporary ID only on logs sent when the user clicks on "Donate". Also, there is a chance that the log could be sent back more than once on the same pageview (if the pageview is sampled and sends the log back, and then the user clicks on "Donate"). This wouldn't allow cleanly distinguishing page views that were definitely not associated with a donation. The changes mentioned in the title would fix it.

Details

Related Gerrit Patches:
mediawiki/extensions/CentralNotice : wmf_deployBannerHistoryLogger: always send log ID, never send twice
mediawiki/extensions/CentralNotice : masterBannerHistoryLogger: always send log ID, never send twice

Event Timeline

AndyRussG claimed this task.
AndyRussG raised the priority of this task from to Needs Triage.
AndyRussG updated the task description. (Show Details)
AndyRussG moved this task to Backlog on the Fundraising Sprint Tom Waits board.
AndyRussG added subscribers: AndyRussG, ellery.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2015, 10:00 PM
AndyRussG set Security to None.
AndyRussG edited a custom field.

Change 240960 had a related patch set uploaded (by AndyRussG):
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/240960

Change 240960 merged by Ejegg:
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/240960

Change 241926 had a related patch set uploaded (by AndyRussG):
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/241926

Change 241926 merged by jenkins-bot:
BannerHistoryLogger: always send log ID, never send twice

https://gerrit.wikimedia.org/r/241926

AndyRussG closed this task as Resolved.Sep 29 2015, 1:27 AM
AndyRussG moved this task from Pending Deployment to Done on the Fundraising Sprint Tom Waits board.