Description
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | zeljkofilipin | T94150 Fix scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily | |||
| Resolved | zeljkofilipin | T113463 Delete broken ZeroBanner browsertests Jenkins job |
Event Timeline
Change 239912 had a related patch set uploaded (by Zfilipin):
Browsertests: switch from PhantomJS to Chrome
I am not sure, but looks like the problem is not that the header changed:
$ git log --grep X-CS commit 0d44661ad18e3030342fa475f94014635e4069a6 Author: Yuri Astrakhan <yurik@wikimedia.org> Date: Sun Aug 17 23:56:54 2014 -0400 If X-CS is TESTON, outputs additional debug info in the banner Need to figure out why opera mini is not working Change-Id: Ie3b69226a42e075fd0c00e37c92885e0be6309de commit a87c4e68fbe31b5d27135d954760c35d27c8b6e2 Author: Yuri Astrakhan <yurik@wikimedia.org> Date: Wed Jul 16 18:03:12 2014 +0300 Cleaned up X-Forward-Proto variance X-CS=ON now does not vary on protocol or proxy Change-Id: I4247efe54c005cb6c2a22b6fa579fcc146204f5f commit 502444d240aac0feeeae2f2884f3013f7a1c0b97 Author: Yuri Astrakhan <yurik@wikimedia.org> Date: Sat Jul 5 23:38:14 2014 -0400 Unified HTML with image banners for non-js users See https://www.mediawiki.org/wiki/Requests_for_comment/Unfragmented_ZERO_design * !!! Config is now tests for X-Forwarded-By & protocol for all requests * When X-CS === "ON", generates banner and config object on the fly * changed default for bannerWarning - migrating as true, but in new configs - false. * Generate banners on the fly using imagemagick * Handle betalabs cluster suffix with a global $wgZeroBannerClusterDomain * In unified, no longer redirect non-free zero. requests to special, show red banner instead To test, set HEADER X-CS to a valid entity, but also supply X-CS via URL: * http://127.0.0.1:8080/wiki/Main_Page?X-CS=ON&debug=true
Looks like mediawiki receives the headers. Look for lines with X-CS.
vagrant@mediawiki-vagrant:/vagrant/logs$ grep X-CS *.log -C 5 mediawiki-wiki-debug.log-[ContentHandler] Created handler for css: CssContentHandler mediawiki-wiki-debug.log-Start request GET /wiki/Main_Page mediawiki-wiki-debug.log-HTTP HEADERS: mediawiki-wiki-debug.log-ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 mediawiki-wiki-debug.log-USER-AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1 mediawiki-wiki-debug.log:X-CS: TESTON mediawiki-wiki-debug.log-CONNECTION: Keep-Alive mediawiki-wiki-debug.log-ACCEPT-ENCODING: gzip, deflate mediawiki-wiki-debug.log-ACCEPT-LANGUAGE: en-US,* mediawiki-wiki-debug.log-HOST: 127.0.0.1:8080 mediawiki-wiki-debug.log-[redis] Creating a new RedisConnectionPool instance with id d70d28fd70891a6f32c19060fdf71767aaa0c97e. -- mediawiki-wiki-debug.log-[caches] LocalisationCache: using store LCStoreCDB mediawiki-wiki-debug.log-Start request GET /wiki/Main_Page mediawiki-wiki-debug.log-HTTP HEADERS: mediawiki-wiki-debug.log-ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 mediawiki-wiki-debug.log-USER-AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1 mediawiki-wiki-debug.log:X-CS: TESTON mediawiki-wiki-debug.log-CONNECTION: Keep-Alive mediawiki-wiki-debug.log-ACCEPT-ENCODING: gzip, deflate mediawiki-wiki-debug.log-ACCEPT-LANGUAGE: en-US,* mediawiki-wiki-debug.log-HOST: 127.0.0.1:8080 mediawiki-wiki-debug.log-[redis] Creating a new RedisConnectionPool instance with id d70d28fd70891a6f32c19060fdf71767aaa0c97e. -- mediawiki-wiki-debug.log-[ContentHandler] Created handler for css: CssContentHandler mediawiki-wiki-debug.log-Start request GET /wiki/Main_Page mediawiki-wiki-debug.log-HTTP HEADERS: mediawiki-wiki-debug.log-ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 mediawiki-wiki-debug.log-USER-AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1 mediawiki-wiki-debug.log:X-CS: TESTON mediawiki-wiki-debug.log-CONNECTION: Keep-Alive mediawiki-wiki-debug.log-ACCEPT-ENCODING: gzip, deflate mediawiki-wiki-debug.log-ACCEPT-LANGUAGE: en-US,* mediawiki-wiki-debug.log-HOST: 127.0.0.1:8080 mediawiki-wiki-debug.log-[redis] Creating a new RedisConnectionPool instance with id d70d28fd70891a6f32c19060fdf71767aaa0c97e. -- mediawiki-wiki-debug.log-[ContentHandler] Created handler for css: CssContentHandler mediawiki-wiki-debug.log-Start request GET /wiki/Main_Page mediawiki-wiki-debug.log-HTTP HEADERS: mediawiki-wiki-debug.log-ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 mediawiki-wiki-debug.log-USER-AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1 mediawiki-wiki-debug.log:X-CS: -TEST-ALL mediawiki-wiki-debug.log-CONNECTION: Keep-Alive mediawiki-wiki-debug.log-ACCEPT-ENCODING: gzip, deflate mediawiki-wiki-debug.log-ACCEPT-LANGUAGE: en-US,* mediawiki-wiki-debug.log-HOST: 127.0.0.1:8080 mediawiki-wiki-debug.log-[redis] Creating a new RedisConnectionPool instance with id d70d28fd70891a6f32c19060fdf71767aaa0c97e. -- mediawiki-wiki-debug.log-[ContentHandler] Created handler for css: CssContentHandler mediawiki-wiki-debug.log-Start request GET /wiki/Main_Page mediawiki-wiki-debug.log-HTTP HEADERS: mediawiki-wiki-debug.log-ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 mediawiki-wiki-debug.log-USER-AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1 mediawiki-wiki-debug.log:X-CS: -TEST-ALL mediawiki-wiki-debug.log-CONNECTION: Keep-Alive mediawiki-wiki-debug.log-ACCEPT-ENCODING: gzip, deflate mediawiki-wiki-debug.log-ACCEPT-LANGUAGE: en-US,* mediawiki-wiki-debug.log-HOST: 127.0.0.1:8080 mediawiki-wiki-debug.log-[redis] Creating a new RedisConnectionPool instance with id d70d28fd70891a6f32c19060fdf71767aaa0c97e. -- mediawiki-wiki-debug.log-[ContentHandler] Created handler for css: CssContentHandler mediawiki-wiki-debug.log-Start request GET /wiki/Main_Page mediawiki-wiki-debug.log-HTTP HEADERS: mediawiki-wiki-debug.log-ACCEPT: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 mediawiki-wiki-debug.log-USER-AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X) AppleWebKit/538.1 (KHTML, like Gecko) PhantomJS/2.0.0 Safari/538.1 mediawiki-wiki-debug.log:X-CS: 250-99 mediawiki-wiki-debug.log-CONNECTION: Keep-Alive mediawiki-wiki-debug.log-ACCEPT-ENCODING: gzip, deflate mediawiki-wiki-debug.log-ACCEPT-LANGUAGE: en-US,* mediawiki-wiki-debug.log-HOST: 127.0.0.1:8080 mediawiki-wiki-debug.log-[redis] Creating a new RedisConnectionPool instance with id d70d28fd70891a6f32c19060fdf71767aaa0c97e.
I do not know why mediawiki does not return zero banners when the header is sent. Anybody has an idea what is wrong? If nobody cares about this job, I vote for deleting it. Is broken since forever. :(
Looks like Selenium does not support adding custom headers, but some browser drivers support it, like phantomjs. Another alternative is to use a proxy like browsermob:
https://github.com/lightbody/browsermob-proxy/
https://github.com/jarib/browsermob-proxy-rb
https://github.com/AutomatedTester/browsermob-proxy-py
There is no longer anyone actively developing for Zero (as a main priority)
and this looks like a trip down the same custom header rabbit hole I ran
into a few months ago. I vote for deleting the job as well.
That is unfortunate. Now I understand why PhantomJS has been chosen originally. Thank you for the investigation!
I could not find a way to set custom headers for Chrome. I will take a look if it possible for Firefox tomorrow.
I don't recall it being possible in Firefox either when originally working
on these tests (as I'm sure I would've greatly favored that over
PhantomJS), but I could be mistaken.
On further investigation, these tests wouldn't pass even if we did use PhantomJS (they're simply designed incorrectly). Definitely feel free to boot them.
Change 239913 had a related patch set uploaded (by Zfilipin):
Switch ZeroBanner browsertests to Chrome
Change 239912 abandoned by Zfilipin:
Browsertests: switch from PhantomJS to Chrome
Change 239913 abandoned by Zfilipin:
Switch ZeroBanner browsertests to Chrome
Change 240648 had a related patch set uploaded (by Zfilipin):
Delete broken ZeroBanner browser tests
Change 240650 had a related patch set uploaded (by Zfilipin):
Delete broken browser tests