Middle/ctrl-clicking on Echo badge does not always work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Quiddity
	Sep 23 2015, 11:47 PM

Description

If the flyout has been previously opened, then middle/ctrl-clicking on the badge will no longer work to open Special:Notifications in a new tab.
Roan says he knows why this happens...

Details

	Subject	Repo	Branch	Lines +/-
	Make middle-clicking badge work	mediawiki/extensions/Echo	master	+18 -4

Customize query in gerrit

Related Objects

Mentioned In: rMEXTa22f64e9434f: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…
rECHO6efd06016965: Make middle-clicking badge work

Event Timeline

Quiddity created this task.Sep 23 2015, 11:47 PM

Quiddity raised the priority of this task from to Needs Triage.

Quiddity updated the task description. (Show Details)

Quiddity added a project: Notifications.

Quiddity subscribed.

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 23 2015, 11:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Quiddity updated the task description. (Show Details)Sep 23 2015, 11:48 PM

Quiddity set Security to None.

I think this happens because the initial version of the badge (before lazy-loading happens) is different from the OOUI version of the badge (after we've lazy-loaded the flyout).

Catrope triaged this task as Medium priority.Sep 24 2015, 12:12 AM

Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.

Change 240629 had a related patch set uploaded (by Catrope):
Make middle-clicking badge work

https://gerrit.wikimedia.org/r/240629

gerritbot added a project: Patch-For-Review.Sep 24 2015, 1:14 AM

Catrope claimed this task.Sep 24 2015, 1:14 AM

Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Archive-2015-2016 board.

Change 240629 merged by jenkins-bot:
Make middle-clicking badge work

https://gerrit.wikimedia.org/r/240629

Catrope mentioned this in rECHO6efd06016965: Make middle-clicking badge work.Sep 24 2015, 11:16 PM

Diffusion mentioned this in rMEXTa22f64e9434f: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 24 2015, 11:17 PM

• Mattflaschen-WMF moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 25 2015, 5:47 PM