Page MenuHomePhabricator
Create Task
Maniphest T113629

Don't show "Mark all as read" for Alerts
Closed, ResolvedPublic
Actions

Description

The Alerts dropdown shouldn't have "Mark all as read" -- it just flashes and disappears.

Details

SubjectRepoBranchLines +/-
Initialize 'mark as read' button hidden unless neededmediawiki/extensions/Echomaster+1 -0
Mark all read button should always start invisiblemediawiki/extensions/Echomaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

• DannyH created this task.Sep 24 2015, 5:18 PM
• DannyH raised the priority of this task from to Medium.
• DannyH updated the task description. (Show Details)
• DannyH added projects: Collaboration-Team-Archive-2015-2016, OKR-Work, Notifications.
• DannyH moved this task to Ready for pickup on the Collaboration-Team-Archive-2015-2016 board.
• DannyH subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 24 2015, 5:18 PM
Mooeypoo claimed this task.Sep 24 2015, 5:55 PM
Mooeypoo set Security to None.
Mooeypoo moved this task from Ready for pickup to In Development on the Collaboration-Team-Archive-2015-2016 board.
gerritbot subscribed.Sep 28 2015, 8:31 PM

Change 241779 had a related patch set uploaded (by Mooeypoo):
Mark all read button should always start invisible

https://gerrit.wikimedia.org/r/241779

gerritbot added a project: Patch-For-Review.Sep 28 2015, 8:31 PM
gerritbot added a comment.Sep 28 2015, 8:44 PM

Change 241779 merged by jenkins-bot:
Mark all read button should always start invisible

https://gerrit.wikimedia.org/r/241779

Mooeypoo mentioned this in rMEXTc2b755fb1bf5: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 28 2015, 8:44 PM
Catrope mentioned this in rECHOe0cd881aeb34: Mark all read button should always start invisible.Sep 28 2015, 8:45 PM
• Mattflaschen-WMF moved this task from In Development to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 29 2015, 5:42 PM
Etonkovidova subscribed.Sep 29 2015, 9:10 PM

'Mark all as read' is fixed - checked in Safari, Chrome, FF, and IE.

Another issue: small cross icon(x) flashes momentarily when Alerts are clicked.

Etonkovidova moved this task from QA Review to In Development on the Collaboration-Team-Archive-2015-2016 board.Sep 29 2015, 9:10 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 10:13 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:48 AM
gerritbot added a comment.Sep 30 2015, 6:37 PM

Change 242636 had a related patch set uploaded (by Mooeypoo):
Initialize 'mark as read' button hidden unless needed

https://gerrit.wikimedia.org/r/242636

Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 8:15 PM
Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 8:29 PM
gerritbot added a comment.Sep 30 2015, 8:31 PM

Change 242636 merged by jenkins-bot:
Initialize 'mark as read' button hidden unless needed

https://gerrit.wikimedia.org/r/242636

Mooeypoo mentioned this in rECHO287d383acfaa: Initialize 'mark as read' button hidden unless needed.Sep 30 2015, 8:32 PM
Diffusion mentioned this in rMEXT00f8985fa608: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 30 2015, 8:34 PM
Etonkovidova added a comment.Oct 1 2015, 12:42 AM

Checked in betalabs for close buttons (x) in Alerts - the issue is fixed.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 1 2015, 12:42 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 1 2015, 5:02 PM
• DannyH unsubscribed.Oct 5 2015, 10:43 PM
Catrope closed this task as Resolved.Oct 9 2015, 7:39 PM
Catrope subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits