Page MenuHomePhabricator
Create Task
Maniphest T114052

ToggleSwitchWidget is pixelated and grip misaligned
Closed, ResolvedPublic
Actions

Description

Screenshot 2015-09-28 15.40.55.png (228×397 px, 21 KB)

Note the corners of the component.

OOjs UI Demos ToggleSwitchWidget min-height-missing 2016-08-03.png (60×134 px, 6 KB)

Details

SubjectRepoBranchLines +/-
MediaWiki theme: Fix ToggleSwitchWidget's sub-pixel rounding errorsoojs/uimaster+7 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• violetto created this task.Sep 28 2015, 10:41 PM
• violetto assigned this task to Volker_E.
• violetto raised the priority of this task from to Needs Triage.
• violetto updated the task description. (Show Details)
• violetto added a project: UI-Standardization.
• violetto subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 28 2015, 10:41 PM
• violetto updated the task description. (Show Details)Sep 28 2015, 10:42 PM
• violetto set Security to None.
• violetto added a parent task: T114026: Minimize differences between implemented components and in pholio mock-ups.Sep 28 2015, 10:48 PM
Volker_E added a comment.Oct 1 2015, 9:15 PM

There are [[ https://stackoverflow.com/questions/6440002/how-to-enable-smooth-rounded-corners-in-android-browser | approaches to make elements with border-radius even smoother ]], but I personally couldn't see a big difference.
We should look at those options side-by-side and decide if there's a real improvement or we just live with what the current browser rendering engines offer.

Volker_E moved this task from Unsorted to Current Quarterly Goals on the UI-Standardization board.Oct 1 2015, 9:15 PM
Volker_E changed the task status from Open to Stalled.Oct 8 2015, 9:08 AM
Volker_E triaged this task as Lowest priority.
Volker_E added a comment.Oct 8 2015, 9:11 AM

Right now, with the em rounding error and browser's different approach to anti-aliasing of border-radius properties, we won't be able to tackle that consequently without changing over to something like rem as measurement unit value.

Volker_E moved this task from Current Quarterly Goals to Unsorted on the UI-Standardization board.Nov 19 2015, 10:29 PM
matmarex edited projects, added OOUI; removed UI-Standardization.Mar 8 2016, 11:27 PM
Volker_E mentioned this in T130691: Sub-pixel rendering layout issues with `em` or `%` relative units (tracking).Mar 23 2016, 12:58 AM
Volker_E removed a parent task: T114026: Minimize differences between implemented components and in pholio mock-ups.May 9 2016, 7:12 PM
Volker_E added a parent task: T130691: Sub-pixel rendering layout issues with `em` or `%` relative units (tracking).Aug 4 2016, 5:42 PM
Volker_E changed the task status from Stalled to Open.Aug 4 2016, 6:05 PM
Volker_E edited subscribers, added: Jdforrester-WMF, matmarex, • Prtksxna; removed: • violetto.
gerritbot subscribed.Aug 4 2016, 6:09 PM

Change 302781 had a related patch set uploaded (by VolkerE):
MediaWiki theme: Fix ToggleSwitchWidget's sub-pixel rounding errors

https://gerrit.wikimedia.org/r/302781

gerritbot added a project: Patch-For-Review.Aug 4 2016, 6:09 PM
Volker_E renamed this task from ToggleSwitchWidget is pixelated to ToggleSwitchWidget is pixelated and grip misaligned.Aug 4 2016, 6:09 PM
Volker_E added projects: UI-Standardization, UI-Standardization-Kanban.
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Aug 5 2016, 1:25 PM
Volker_E raised the priority of this task from Lowest to High.Aug 11 2016, 9:37 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.
gerritbot added a comment.Aug 16 2016, 8:53 PM

Change 302781 merged by jenkins-bot:
MediaWiki theme: Fix ToggleSwitchWidget's sub-pixel rounding errors

https://gerrit.wikimedia.org/r/302781

Jdforrester-WMF closed this task as Resolved.Aug 16 2016, 8:57 PM
Jdforrester-WMF moved this task from Reviewing to OOjs-UI-0.17.8 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.17.8); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.Aug 16 2016, 9:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits