Page MenuHomePhabricator
Create Task
Maniphest T114184

[beta] RTL Echo notifications incorrect display
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Etonkovidova
Sep 29 2015, 9:59 PM
Tags
Referenced Files
F2646407: Screen Shot 2015-09-30 at 9.34.54 AM.png
Sep 30 2015, 4:49 PM
F2646411: Screen Shot 2015-09-29 at 2.51.34 PM.png
Sep 30 2015, 4:49 PM
F2645317: Screen Shot 2015-09-29 at 2.51.49 PM.png
Sep 29 2015, 9:59 PM
F2645315: Screen Shot 2015-09-29 at 2.51.34 PM.png
Sep 29 2015, 9:59 PM
F2645320: Screen Shot 2015-09-29 at 2.37.27 PM.png
Sep 29 2015, 9:59 PM
Subscribers
Aklapper
• DannyH
Etonkovidova
gerritbot

Description

Echo notifications overlays look cut off - 'Mark all as read' is not fully displayed.

Screen Shot 2015-09-29 at 2.51.34 PM.png (665×1 px, 202 KB)

Screen Shot 2015-09-29 at 2.51.49 PM.png (569×1 px, 195 KB)

In production:

Screen Shot 2015-09-29 at 2.37.27 PM.png (663×1 px, 378 KB)

Details

SubjectRepoBranchLines +/-
Fix Echo popup alignment in RTLmediawiki/extensions/Echowmf/1.26wmf24+9 -1
Fix Echo popup alignment in RTLmediawiki/extensions/Echomaster+9 -1
Fix Echo popup alignment in RTLmediawiki/extensions/Echowmf/1.27.0-wmf.1+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 29 2015, 9:59 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2015, 9:59 PM
Etonkovidova updated the task description. (Show Details)Sep 29 2015, 10:00 PM
Etonkovidova set Security to None.
Legoktm edited projects, added Notifications; removed StructuredDiscussions.Sep 29 2015, 10:51 PM
gerritbot subscribed.Sep 29 2015, 10:56 PM

Change 242391 had a related patch set uploaded (by Mooeypoo):
Fix Echo popup alignment in RTL

https://gerrit.wikimedia.org/r/242391

gerritbot added a project: Patch-For-Review.Sep 29 2015, 10:56 PM
gerritbot added a comment.Sep 29 2015, 11:10 PM

Change 242391 merged by jenkins-bot:
Fix Echo popup alignment in RTL

https://gerrit.wikimedia.org/r/242391

Mooeypoo mentioned this in rECHO16ddd5c7d74d: Fix Echo popup alignment in RTL.Sep 29 2015, 11:10 PM
Diffusion mentioned this in rMEXT59c48e6e5efa: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 29 2015, 11:11 PM
gerritbot added a comment.Sep 29 2015, 11:15 PM

Change 242400 had a related patch set uploaded (by Catrope):
Fix Echo popup alignment in RTL

https://gerrit.wikimedia.org/r/242400

gerritbot added a comment.Sep 29 2015, 11:19 PM

Change 242400 merged by jenkins-bot:
Fix Echo popup alignment in RTL

https://gerrit.wikimedia.org/r/242400

Diffusion mentioned this in rMW792e0397f396: Updated mediawiki/core Project: mediawiki/extensions/Echo….Sep 29 2015, 11:20 PM
Catrope mentioned this in rECHO1d73767ef102: Fix Echo popup alignment in RTL.Sep 29 2015, 11:20 PM
gerritbot added a comment.Sep 29 2015, 11:39 PM

Change 242408 had a related patch set uploaded (by Catrope):
Fix Echo popup alignment in RTL

https://gerrit.wikimedia.org/r/242408

gerritbot added a comment.Sep 29 2015, 11:41 PM

Change 242408 merged by jenkins-bot:
Fix Echo popup alignment in RTL

https://gerrit.wikimedia.org/r/242408

Mooeypoo mentioned this in rMWbde793aada9b: Updated mediawiki/core Project: mediawiki/extensions/Echo….Sep 29 2015, 11:42 PM
Catrope mentioned this in rECHOd98e98bcc7d9: Fix Echo popup alignment in RTL.Sep 29 2015, 11:43 PM
Catrope assigned this task to Mooeypoo.Sep 30 2015, 12:05 AM
Catrope moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.
Etonkovidova added a comment.Sep 30 2015, 4:49 PM

Checked in betalabs for hewiki and fawiki

Screen Shot 2015-09-30 at 9.34.54 AM.png (279×1 px, 54 KB)

Screen Shot 2015-09-29 at 2.51.34 PM.png (665×1 px, 202 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Sep 30 2015, 4:49 PM
• DannyH closed this task as Resolved.Sep 30 2015, 4:57 PM
• DannyH subscribed.
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), WMF-deploy-2015-09-22_(1.26wmf24), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)).Oct 1 2015, 4:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL