Page MenuHomePhabricator
Create Task
Maniphest T114562

Focusing a template field or adding a new field focusses the info icon, not the text widget
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

This regression was caused by the booklet layout focus code we changed.

Details

SubjectRepoBranchLines +/-
MWParameterPage: Focus value input when focussing pagemediawiki/extensions/VisualEditormaster+28 -0
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttonsmediawiki/extensions/VisualEditorwmf/1.27.0-wmf.1+5 -19
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttonsmediawiki/extensions/VisualEditormaster+5 -19
Follow-up I4acbe69420: BookletLayout: Fix focus of page switchingoojs/uimaster+11 -2
Customize query in gerrit

Related Objects

Event Timeline

• Esanders created this task.Oct 3 2015, 11:29 AM
• Esanders raised the priority of this task from to Needs Triage.
• Esanders updated the task description. (Show Details)
• Esanders added projects: VisualEditor, VisualEditor-MediaWiki.
• Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2015, 11:29 AM
• Esanders added a comment.Oct 3 2015, 11:38 AM

Worse still, clicking on a the text input box causes the focus to go the (i) until the second time you click it :/

• Esanders triaged this task as High priority.Oct 3 2015, 11:38 AM
• Esanders set Security to None.
• Esanders updated the task description. (Show Details)Oct 3 2015, 12:36 PM
• Esanders added a project: OOUI.
• Esanders added a subscriber: matmarex.
gerritbot subscribed.Oct 3 2015, 1:06 PM

Change 243387 had a related patch set uploaded (by Esanders):
BookletLayout: Fix focus of page switching

https://gerrit.wikimedia.org/r/243387

gerritbot added a project: Patch-For-Review.Oct 3 2015, 1:06 PM
• Esanders added a comment.Oct 3 2015, 1:06 PM

This is a pretty serious UX regression so I'd vote for a backport.

• Esanders renamed this task from Adding a field to a template focusses the info icon, not the text widget to Focusing a template field or adding a new field focusses the info icon, not the text widget.Oct 3 2015, 1:18 PM
• Esanders claimed this task.
gerritbot added a comment.Oct 3 2015, 1:19 PM

Change 243388 had a related patch set uploaded (by Esanders):
MWParameterPage: Focus value input when focussing page

https://gerrit.wikimedia.org/r/243388

matmarex added a comment.Oct 4 2015, 12:43 PM

Wouldn't a better fix for this be to change the DOM order of the buttons and text field in MWParameterPage? It would also remove the need for manual tab indices.

gerritbot added a comment.Oct 4 2015, 6:45 PM

Change 243527 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons

https://gerrit.wikimedia.org/r/243527

matmarex added a comment.Oct 4 2015, 6:48 PM

https://gerrit.wikimedia.org/r/243387 is a good change to make anyway (especially the first part, "Use document.activeElement to check if the page has focus as :focus doesn't work until a later event cycle"), but I think https://gerrit.wikimedia.org/r/243527 is a better fix than https://gerrit.wikimedia.org/r/243388 (and it doesn't have https://gerrit.wikimedia.org/r/243387 as a dependency). Either should be fine though. Somebody please decide and merge one of them :)

• Esanders added a comment.Oct 5 2015, 11:54 AM

Merged DOM order fix, but I think we should merge https://gerrit.wikimedia.org/r/243388 anyway. Explicitly stating which input to focus is faster than calculating which is first, and will may prevent against regressions.

gerritbot added a comment.Oct 5 2015, 11:55 AM

Change 243527 merged by jenkins-bot:
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons

https://gerrit.wikimedia.org/r/243527

matmarex mentioned this in rEVED205beb2b498e: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons.Oct 5 2015, 11:56 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 5 2015, 12:00 PM
gerritbot added a comment.Oct 5 2015, 2:06 PM

Change 243387 merged by jenkins-bot:
Follow-up I4acbe69420: BookletLayout: Fix focus of page switching

https://gerrit.wikimedia.org/r/243387

• Esanders mentioned this in rGOJUdec482111e9b: Follow-up I4acbe69420: BookletLayout: Fix focus of page switching.Oct 5 2015, 2:06 PM
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Oct 5 2015, 5:53 PM
gerritbot added a comment.Oct 5 2015, 5:59 PM

Change 243704 had a related patch set uploaded (by Jforrester):
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons

https://gerrit.wikimedia.org/r/243704

Jdforrester-WMF closed this task as Resolved.Oct 5 2015, 6:01 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Oct 5 2015, 6:58 PM

Change 243704 merged by jenkins-bot:
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons

https://gerrit.wikimedia.org/r/243704

Jdforrester-WMF mentioned this in rEVED6e1eb8bbbdf4: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons.Oct 5 2015, 6:58 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)).Oct 5 2015, 7:00 PM
gerritbot added a comment.Oct 7 2015, 10:07 PM

Change 243388 merged by jenkins-bot:
MWParameterPage: Focus value input when focussing page

https://gerrit.wikimedia.org/r/243388

Jdforrester-WMF mentioned this in rEVED8ac173894d03: MWParameterPage: Focus value input when focussing page.Oct 7 2015, 10:08 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 7 2015, 11:00 PM
Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Oct 20 2015, 9:22 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Nov 21 2015, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits