This regression was caused by the booklet layout focus code we changed.
Description
Details
Related Objects
- Mentioned In
- rEVED8ac173894d03: MWParameterPage: Focus value input when focussing page
rEVED6e1eb8bbbdf4: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
rGOJUdec482111e9b: Follow-up I4acbe69420: BookletLayout: Fix focus of page switching
rEVED205beb2b498e: ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
Event Timeline
Worse still, clicking on a the text input box causes the focus to go the (i) until the second time you click it :/
Change 243387 had a related patch set uploaded (by Esanders):
BookletLayout: Fix focus of page switching
Change 243388 had a related patch set uploaded (by Esanders):
MWParameterPage: Focus value input when focussing page
Wouldn't a better fix for this be to change the DOM order of the buttons and text field in MWParameterPage? It would also remove the need for manual tab indices.
Change 243527 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
https://gerrit.wikimedia.org/r/243387 is a good change to make anyway (especially the first part, "Use document.activeElement to check if the page has focus as :focus doesn't work until a later event cycle"), but I think https://gerrit.wikimedia.org/r/243527 is a better fix than https://gerrit.wikimedia.org/r/243388 (and it doesn't have https://gerrit.wikimedia.org/r/243387 as a dependency). Either should be fine though. Somebody please decide and merge one of them :)
Merged DOM order fix, but I think we should merge https://gerrit.wikimedia.org/r/243388 anyway. Explicitly stating which input to focus is faster than calculating which is first, and will may prevent against regressions.
Change 243527 merged by jenkins-bot:
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
Change 243387 merged by jenkins-bot:
Follow-up I4acbe69420: BookletLayout: Fix focus of page switching
Change 243704 had a related patch set uploaded (by Jforrester):
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
Change 243704 merged by jenkins-bot:
ve.ui.MWParameterPage: Use more natural DOM order for text field and buttons
Change 243388 merged by jenkins-bot:
MWParameterPage: Focus value input when focussing page