Broken Echo notification popup widget in testwiki
Closed, ResolvedPublic

Description

Visiting random page in https://test.wikipedia.org/ and clicking on echo notification icon gives this UI.

santhosh created this task.Oct 7 2015, 5:09 AM
santhosh updated the task description. (Show Details)
santhosh raised the priority of this task from to Needs Triage.
santhosh added a project: Notifications.
santhosh added a subscriber: santhosh.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 7 2015, 5:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

There is a js error as well
Exception in load-callback in module ext.echo.ui:
TypeError: items[i].getModel is not a function

Catrope triaged this task as Unbreak Now! priority.Oct 7 2015, 3:17 PM
Catrope claimed this task.
Catrope set Security to None.

Change 244173 had a related patch set uploaded (by Catrope):
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244173

Change 244173 merged by jenkins-bot:
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244173

Change 244179 had a related patch set uploaded (by Catrope):
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244179

Change 244180 had a related patch set uploaded (by Catrope):
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244180

Change 244179 merged by jenkins-bot:
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244179

Change 244180 merged by jenkins-bot:
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244180

Catrope closed this task as Resolved.Oct 7 2015, 3:45 PM

Checked in betalabs and https://test.wikipedia.org/

  • no more js errors
  • old users, if they do not have Alerts, still have "Alerts - There are no notifications" displayed.
  • newly created users will always have at least one Alert: "Welcome to Wikipedia, {username]! We are glad that you here."