Page MenuHomePhabricator
Create Task
Maniphest T114853

Broken Echo notification popup widget in testwiki
Closed, ResolvedPublic
Actions

Description

Visiting random page in https://test.wikipedia.org/ and clicking on echo notification icon gives this UI.

screenshot2.png (289×818 px, 25 KB)

Details

SubjectRepoBranchLines +/-
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notificationsmediawiki/extensions/Echowmf/1.27.0-wmf.2+8 -6
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notificationsmediawiki/extensions/Echowmf/1.27.0-wmf.1+8 -6
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notificationsmediawiki/extensions/Echomaster+8 -6
Customize query in gerrit

Related Objects

Event Timeline

• santhosh created this task.Oct 7 2015, 5:09 AM
• santhosh raised the priority of this task from to Needs Triage.
• santhosh updated the task description. (Show Details)
• santhosh added a project: Notifications.
• santhosh subscribed.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 7 2015, 5:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• santhosh added a comment.Oct 7 2015, 5:11 AM

There is a js error as well
Exception in load-callback in module ext.echo.ui:
TypeError: items[i].getModel is not a function

Catrope claimed this task.Oct 7 2015, 3:17 PM
Catrope triaged this task as Unbreak Now! priority.
Catrope edited projects, added Collaboration-Team-Archive-2015-2016; removed Collaboration-Team-Triage.
Catrope set Security to None.
gerritbot subscribed.Oct 7 2015, 3:21 PM

Change 244173 had a related patch set uploaded (by Catrope):
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244173

gerritbot added a project: Patch-For-Review.Oct 7 2015, 3:21 PM
gerritbot added a comment.Oct 7 2015, 3:35 PM

Change 244173 merged by jenkins-bot:
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244173

gerritbot added a comment.Oct 7 2015, 3:35 PM

Change 244179 had a related patch set uploaded (by Catrope):
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244179

Catrope mentioned this in rMEXTfc3daf5868f2: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Oct 7 2015, 3:35 PM
gerritbot added a comment.Oct 7 2015, 3:35 PM

Change 244180 had a related patch set uploaded (by Catrope):
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244180

Catrope mentioned this in rECHOcacccc307a87: Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications.Oct 7 2015, 3:36 PM
gerritbot added a comment.Oct 7 2015, 3:41 PM

Change 244179 merged by jenkins-bot:
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244179

gerritbot added a comment.Oct 7 2015, 3:41 PM

Change 244180 merged by jenkins-bot:
Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications

https://gerrit.wikimedia.org/r/244180

Catrope mentioned this in rMW5ff1f9605e5d: Updated mediawiki/core Project: mediawiki/extensions/Echo….Oct 7 2015, 3:41 PM
Catrope mentioned this in rMW90cb21893be3: Updated mediawiki/core Project: mediawiki/extensions/Echo….
Catrope mentioned this in rECHO08293b2a417c: Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications.
Catrope mentioned this in rECHO250bfc0dc149: Follow-up f9e8c5057, 983c7a2463: fix JS error when there are no notifications.
Catrope closed this task as Resolved.Oct 7 2015, 3:45 PM
ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)), MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 7 2015, 7:02 PM
SBisson moved this task from Untriaged to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 20 2015, 2:03 PM
Etonkovidova subscribed.Oct 20 2015, 5:27 PM

Checked in betalabs and https://test.wikipedia.org/

  • no more js errors
  • old users, if they do not have Alerts, still have "Alerts - There are no notifications" displayed.
  • newly created users will always have at least one Alert: "Welcome to Wikipedia, {username]! We are glad that you here."
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 20 2015, 5:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL