Page MenuHomePhabricator

PHP 7 compatibility: Fix variable interpolation in ImageGalleryBase.php
Closed, ResolvedPublic

Description

Break

mediawiki-core/includes/gallery/ImageGalleryBase.php:88
return new self::$modeMapping[$mode]( $mode, $context );

into two explicit lines, due to

referenceold meaningnew meaning in PHP7
Foo::$bar['baz']()Foo::{$bar['baz']}()(Foo::$bar)['baz']()

Event Timeline

Aklapper raised the priority of this task from to Needs Triage.
Aklapper updated the task description. (Show Details)
Aklapper added a subscriber: Aklapper.

Change 256727 had a related patch set uploaded (by Umherirrender):
PHP 7 compatibility: Fix variable interpolation in ImageGalleryBase.php

https://gerrit.wikimedia.org/r/256727

Change 256727 merged by jenkins-bot:
PHP 7 compatibility: Fix variable interpolation in ImageGalleryBase.php

https://gerrit.wikimedia.org/r/256727

Patch merged; closing as resolved. Thanks, @Umherirrender!

Ricordisamoa set Security to None.
Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot.