Page MenuHomePhabricator
Create Task
Maniphest T115328

Add a change Tag to media uploaded to Commons through the cross-wiki upload tool
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Add a change tag to log and RC entry of cross-wiki uploads, toomediawiki/extensions/WikimediaEventswmf/1.27.0-wmf.3+15 -3
Add a change tag to log and RC entry of cross-wiki uploads, toomediawiki/extensions/WikimediaEventsmaster+15 -3
Add a change tag to cross-wiki uploadsmediawiki/extensions/WikimediaEventswmf/1.27.0-wmf.3+47 -1
mw.ForeignUpload: Provide an edit summary to help track these uploadsmediawiki/coremaster+6 -0
Add a change tag to cross-wiki uploadsmediawiki/extensions/WikimediaEventsmaster+47 -1
Add a change tag to cross-wiki uploadsmediawiki/coremaster+18 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Oct 13 2015, 2:45 PM
Jdforrester-WMF raised the priority of this task from to High.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a project: Multimedia.
Jdforrester-WMF moved this task to Next up on the Multimedia board.
Jdforrester-WMF subscribed.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptOct 13 2015, 2:45 PM
gerritbot subscribed.Oct 13 2015, 3:37 PM

Change 245916 had a related patch set uploaded (by Bartosz Dziewoński):
mw.ForeignUpload: Provide an edit summary to help track these uploads

https://gerrit.wikimedia.org/r/245916

gerritbot added a project: Patch-For-Review.Oct 13 2015, 3:37 PM
matmarex subscribed.Oct 13 2015, 3:38 PM

Adding change tags to uploads looks like a mess, so let's have an edit summary at least for now.

matmarex added a project: MediaWiki-General.Oct 13 2015, 3:57 PM
gerritbot added a comment.Oct 13 2015, 3:59 PM

Change 245916 merged by jenkins-bot:
mw.ForeignUpload: Provide an edit summary to help track these uploads

https://gerrit.wikimedia.org/r/245916

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), MW-1.27-release-notes.Oct 13 2015, 4:00 PM
Jdforrester-WMF removed a project: Patch-For-Review.Oct 13 2015, 4:16 PM
Jdforrester-WMF set Security to None.
matmarex claimed this task.Oct 14 2015, 4:32 PM
Steinsplitter awarded a token.Oct 14 2015, 4:59 PM
gerritbot added a comment.Oct 14 2015, 5:24 PM

Change 246271 had a related patch set uploaded (by Bartosz Dziewoński):
Add a change tag to cross-wiki uploads

https://gerrit.wikimedia.org/r/246271

gerritbot added a project: Patch-For-Review.Oct 14 2015, 5:24 PM
gerritbot added a comment.Oct 14 2015, 7:04 PM

Change 246297 had a related patch set uploaded (by Bartosz Dziewoński):
Add a change tag to cross-wiki uploads

https://gerrit.wikimedia.org/r/246297

gerritbot added a comment.Oct 14 2015, 7:13 PM

Change 246271 abandoned by Bartosz Dziewoński:
Add a change tag to cross-wiki uploads

Reason:
Wrong approach, https://gerrit.wikimedia.org/r/246297 (based on Anomie's suggestion) is better.

https://gerrit.wikimedia.org/r/246271

matmarex added a subscriber: Anomie.Oct 14 2015, 7:22 PM

Rather than try to put this in core, where it doesn't really fit, we'll put the code in the WikimediaEvents extension, as suggested by @Anomie with P2198.

matmarex edited projects, added WMF-General-or-Unknown, Commons; removed Patch-For-Review, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), MediaWiki-General.Oct 14 2015, 7:22 PM
Restricted Application added a subscriber: Steinsplitter. · View Herald TranscriptOct 14 2015, 7:22 PM
matmarex added a project: MediaWiki-extensions-WikimediaEvents.Oct 14 2015, 7:33 PM
Steinsplitter moved this task from Incoming to Uploading on the Commons board.Oct 15 2015, 11:41 AM
zhuyifei1999 subscribed.Oct 15 2015, 2:38 PM
gerritbot added a comment.Oct 15 2015, 4:28 PM

Change 246297 merged by jenkins-bot:
Add a change tag to cross-wiki uploads

https://gerrit.wikimedia.org/r/246297

Jdforrester-WMF closed this task as Resolved.Oct 15 2015, 4:28 PM
gerritbot added a comment.Oct 15 2015, 4:38 PM

Change 246701 had a related patch set uploaded (by Bartosz Dziewoński):
Add a change tag to cross-wiki uploads

https://gerrit.wikimedia.org/r/246701

gerritbot added a project: Patch-For-Review.Oct 15 2015, 4:38 PM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 15 2015, 5:00 PM
matmarex added a project: MW-1.26-release.Oct 16 2015, 6:42 PM

Patches cherry-picked to REL1_26 in 03e6ac38bf51456d9035b58040422358c41939f7.

gerritbot added a comment.Oct 19 2015, 3:41 PM

Change 246701 merged by jenkins-bot:
Add a change tag to cross-wiki uploads

https://gerrit.wikimedia.org/r/246701

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 19 2015, 4:00 PM
gerritbot added a comment.Oct 20 2015, 8:22 PM

Change 247646 had a related patch set uploaded (by Bartosz Dziewoński):
Add a change tag to log and RC entry of cross-wiki uploads, too

https://gerrit.wikimedia.org/r/247646

gerritbot added a comment.Oct 20 2015, 8:33 PM

Change 247646 merged by jenkins-bot:
Add a change tag to log and RC entry of cross-wiki uploads, too

https://gerrit.wikimedia.org/r/247646

gerritbot added a comment.Oct 20 2015, 8:41 PM

Change 247650 had a related patch set uploaded (by Bartosz Dziewoński):
Add a change tag to log and RC entry of cross-wiki uploads, too

https://gerrit.wikimedia.org/r/247650

matmarex reopened this task as Open.Oct 20 2015, 9:01 PM

Turned out that this did not quite work because the change tags were only being associated with the page revision, and not the upload log entry, and apparently for uploads only the log entry is inserted into recent changes (and not the page revision, like it happens for regular edits). This meant that the tags displayed on the file history pages, but not on Special:RecentChanges, and you also couldn't search for uploads with the tag, which was the whole damn point.

The fix for this was above, reopening until it's deployed.

matmarex renamed this task from Add a change Tag to media uploaded through the cross-wiki upload tool to Add a change Tag to media uploaded to Commons through the cross-wiki upload tool.Oct 20 2015, 9:04 PM
matmarex removed projects: MW-1.26-release, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)), Patch-For-Review.
gerritbot added a comment.Oct 20 2015, 11:32 PM

Change 247650 merged by jenkins-bot:
Add a change tag to log and RC entry of cross-wiki uploads, too

https://gerrit.wikimedia.org/r/247650

matmarex closed this task as Resolved.Oct 21 2015, 10:09 AM
Jdforrester-WMF moved this task from Next up to Done on the Multimedia board.Oct 23 2015, 5:00 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits