Page MenuHomePhabricator
Create Task
Maniphest T115411

Categories flash and disappear on Flow pages
Closed, ResolvedPublic
Actions

Description

  1. Add some Categories to a Board description
  2. View that Flow board in Safari(9.0) and FF(41)

The added Categories are not displayed. Refresh the page - the Categories will be displayed momentarily.

Details

SubjectRepoBranchLines +/-
Style categories the same in nojs and js Flowmediawiki/extensions/Flowmaster+75 -43
Remove existing categories from DOM after the widget ate themmediawiki/extensions/Flowwmf/1.27.0-wmf.3+6 -6
Remove existing categories from DOM after the widget ate themmediawiki/extensions/Flowmaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Oct 13 2015, 9:39 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: StructuredDiscussions, Collaboration-Team-Archive-2015-2016.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2015, 9:39 PM
Catrope assigned this task to Mooeypoo.Oct 13 2015, 10:30 PM
Catrope subscribed.

I can reproduce this in Chrome too.

Catrope renamed this task from Safari and FF do not display Categories on Flow pages to Categories flash and disappear on Flow pages.Oct 13 2015, 10:30 PM
Catrope set Security to None.
Catrope moved this task from Untriaged to In Development on the Collaboration-Team-Archive-2015-2016 board.
gerritbot subscribed.Oct 13 2015, 10:35 PM

Change 246114 had a related patch set uploaded (by Mooeypoo):
Remove existing categories from DOM after the widget ate them

https://gerrit.wikimedia.org/r/246114

gerritbot added a project: Patch-For-Review.Oct 13 2015, 10:35 PM
gerritbot added a comment.Oct 13 2015, 10:59 PM

Change 246114 merged by jenkins-bot:
Remove existing categories from DOM after the widget ate them

https://gerrit.wikimedia.org/r/246114

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 13 2015, 11:00 PM
gerritbot added a comment.Oct 13 2015, 11:04 PM

Change 246124 had a related patch set uploaded (by Catrope):
Remove existing categories from DOM after the widget ate them

https://gerrit.wikimedia.org/r/246124

gerritbot added a comment.Oct 13 2015, 11:04 PM

Change 246124 merged by Catrope:
Remove existing categories from DOM after the widget ate them

https://gerrit.wikimedia.org/r/246124

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)).Oct 14 2015, 12:00 AM
gerritbot added a comment.Oct 15 2015, 8:50 PM

Change 246779 had a related patch set uploaded (by Mooeypoo):
Style categories the same in nojs and js Flow

https://gerrit.wikimedia.org/r/246779

Mooeypoo moved this task from In Development to Needs Review on the Collaboration-Team-Archive-2015-2016 board.Oct 15 2015, 8:53 PM
Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Archive-2015-2016 board.Oct 17 2015, 12:34 AM
gerritbot added a comment.Oct 17 2015, 12:35 AM

Change 246779 merged by jenkins-bot:
Style categories the same in nojs and js Flow

https://gerrit.wikimedia.org/r/246779

Etonkovidova added a comment.EditedOct 20 2015, 12:23 AM

The main issue is fixed - but Categories at the bottom of a page (they should not be displayed at all) are still displayed for a short time when

  • a page is loaded via search
  • refreshed
  • back/forth browser navigation

Attached a screencast

flashing_categories.mov2 MBDownload

Another issue:
When adding/updating Categories, the, while saving, Board description will display previous Categories momentarily.

  1. Have some Categories on Board description - and delete or add some
  2. Click Save description - the previously saved Categories will be displayed momentarily before switching to an updated Board description.
Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Archive-2015-2016 board.Oct 20 2015, 5:17 PM
Etonkovidova mentioned this in T92874: Display categories in Flow side rail.Oct 20 2015, 9:32 PM
Catrope closed this task as Resolved.Nov 22 2015, 10:49 PM
In T115411#1737140, @Etonkovidova wrote:

The main issue is fixed - but Categories at the bottom of a page (they should not be displayed at all) are still displayed for a short time when

  • a page is loaded via search
  • refreshed
  • back/forth browser navigation

Attached a screencast

flashing_categories.mov2 MBDownload

I can't reproduce that any more. I don't even see the categories at the bottom of the page in non-JS mode.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 22 2015, 10:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits