in MagicWord::matchAndRemove():
$text = preg_replace( $regex, '', $text );
if preg_replace errors, it will log a warning and then return null. At some point, $text will be cast to an empty string. We should throw an exception if it errors, instead of silently failing.
Related: https://wikitech.wikimedia.org/wiki/Incident_documentation/20151014-MediaWiki
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Tgr | T115514 MagicWord.php should check return value of preg_* calls | |||
| Open | None | T115639 Create safe preg_* wrapper library |
Change 246719 had a related patch set uploaded (by Legoktm):
Throw Exceptions on preg_* failures in MagicWordArray::matchAndRemove()
Change 246719 merged by jenkins-bot:
Throw Exceptions on preg_* failures in MagicWordArray::matchAndRemove()
Change 249873 had a related patch set uploaded (by Gergő Tisza):
Include preg_last_error() in error message when preg_* fails
Change 249873 merged by jenkins-bot:
Include preg_last_error() in error message when preg_* fails
Change 249888 had a related patch set uploaded (by Gergő Tisza):
Include preg_last_error() in error message when preg_* fails
Change 249888 merged by jenkins-bot:
Include preg_last_error() in error message when preg_* fails
Change 249898 had a related patch set uploaded (by Gergő Tisza):
Revert throwing exceptions on preg_* failures
Change 249901 had a related patch set uploaded (by Gergő Tisza):
Revert throwing exceptions on preg_* failures
Change 249942 had a related patch set uploaded (by Gergő Tisza):
Log warnings on on preg_* failures in MagicWordArray::matchAndRemove()
Change 249942 merged by jenkins-bot:
Log warnings on on preg_* failures in MagicWordArray::matchAndRemove()