Page MenuHomePhabricator
Create Task
Maniphest T115586

deleteLinks jobs reliably fail due to pageId = 0
Closed, ResolvedPublic
Actions

Description

Originally reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Cascading_protection_glitch

It appears that the code added in https://gerrit.wikimedia.org/r/#/c/240155/ to do deletion links table updates is adding the jobs with pageId = 0 rather than the page_id associated with the LinksDeletionUpdate, so the job does not successfully run.

2015-10-13 09:04:08 mw1007 enwiki runJobs DEBUG: deleteLinks File:Onion_Powder,_Penzeys_Spices,_Arlington_Heights_MA.jpg pageId=0 (uuid=de10c53df37946f59c67265a716e4cb0,timestamp=1444727048,QueuePartition=rdb2) STARTING  
2015-10-13 09:04:08 mw1007 enwiki runJobs ERROR: deleteLinks File:Onion_Powder,_Penzeys_Spices,_Arlington_Heights_MA.jpg pageId=0 (uuid=de10c53df37946f59c67265a716e4cb0,timestamp=1444727048,QueuePartition=rdb2) t=3 error=MWException: Page ID not known, perhaps the page doesn't exist?

I see lots of entries like this in exception.log.

Details

SubjectRepoBranchLines +/-
Use specified pageId for LinksDeletionUpdate→DeleteLinksJobmediawiki/corewmf/1.27.0-wmf.2+1 -1
Use specified pageId for LinksDeletionUpdate→DeleteLinksJobmediawiki/corewmf/1.27.0-wmf.3+1 -1
Use specified pageId for LinksDeletionUpdate→DeleteLinksJobmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.Oct 15 2015, 1:08 PM
Anomie raised the priority of this task from to Needs Triage.
Anomie updated the task description. (Show Details)
Anomie added projects: MediaWiki-Page-deletion, MediaWiki-Core-JobQueue.
Anomie added subscribers: Anomie, aaron.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2015, 1:08 PM
gerritbot subscribed.Oct 15 2015, 1:11 PM

Change 246678 had a related patch set uploaded (by Anomie):
Use specified pageId for LinksDeletionUpdate→DeleteLinksJob

https://gerrit.wikimedia.org/r/246678

gerritbot added a project: Patch-For-Review.Oct 15 2015, 1:11 PM
Anomie added a comment.Oct 15 2015, 2:22 PM

After some further analysis, it seems that this is only occurring for file deletions in 1.27.0-wmf.2, and for all deletions in 1.27.0-wmf.3. That's likely due to https://gerrit.wikimedia.org/r/#/c/242649/2/includes/page/WikiPage.php: before that change, as long as the transaction was already idle (which is the common case, file deletion being the exception) the enqueuing of the jobs would happen inside WikiPage::doDeleteUpdates before the reset of the WikiPage's mId a few lines later (by the call to loadFromRow). After the change, the enqueuing doesn't happen until DeferredUpdates are processed at the end of the request, long after the WikiPage has reset its mId.

gerritbot added a comment.Oct 15 2015, 2:51 PM

Change 246678 merged by jenkins-bot:
Use specified pageId for LinksDeletionUpdate→DeleteLinksJob

https://gerrit.wikimedia.org/r/246678

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 15 2015, 3:00 PM
Anomie added a project: WMF-Server-Backports.Oct 15 2015, 4:19 PM

Scheduled for backporting in Monday morning's SWAT.

Anomie removed a project: Patch-For-Review.Oct 15 2015, 4:19 PM
Anomie set Security to None.
PleaseStand subscribed.Oct 16 2015, 8:20 AM
aaron mentioned this in T115682: hewiki's categorylinks shown as not empty though it is; purging does not help.Oct 18 2015, 11:23 PM
gerritbot added a comment.Oct 19 2015, 1:42 PM

Change 247267 had a related patch set uploaded (by Anomie):
Use specified pageId for LinksDeletionUpdate→DeleteLinksJob

https://gerrit.wikimedia.org/r/247267

gerritbot added a project: Patch-For-Review.Oct 19 2015, 1:42 PM

Change 247268 had a related patch set uploaded (by Anomie):
Use specified pageId for LinksDeletionUpdate→DeleteLinksJob

https://gerrit.wikimedia.org/r/247268

gerritbot added a comment.Oct 19 2015, 3:23 PM

Change 247267 merged by jenkins-bot:
Use specified pageId for LinksDeletionUpdate→DeleteLinksJob

https://gerrit.wikimedia.org/r/247267

gerritbot added a comment.Oct 19 2015, 3:24 PM

Change 247268 merged by jenkins-bot:
Use specified pageId for LinksDeletionUpdate→DeleteLinksJob

https://gerrit.wikimedia.org/r/247268

Anomie closed this task as Resolved.Oct 19 2015, 3:28 PM
Anomie claimed this task.

Backports have been deployed.

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Oct 19 2015, 4:00 PM
eranroz subscribed.Oct 19 2015, 10:13 PM

Once it is deployed, is missing deletions will be deleted manually/maintenance script?

Anomie added a comment.Oct 20 2015, 3:39 PM

They should be automatically cleaned up the first week of November when the monthly runs of refreshLinks.php --dfn-only happen. That could be manually run sooner, if someone wants to file a Wikimedia-Site-requests bug for it.

Bawolff mentioned this in T115113: Empty categories in Non-empty category on Commons.Oct 22 2015, 5:53 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL