Handle errors on (un)subscription in Special:Newsletters
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Glaisher
	Oct 19 2015, 3:30 PM

Description

https://gerrit.wikimedia.org/r/246675 implemented a JS subscription functionality which will show a success message if the API request was successful. It currently doesn't handle errors - but it should show error messages if the API request was unsuccessful. The API was rewritten in https://gerrit.wikimedia.org/r/#/c/244184/ to die on errors so we only need to make the javascript handle it.

Details

	Subject	Repo	Branch	Lines +/-
	Handle errors when attempting to subscribe/unsubscribe on Special:Newsletters	mediawiki/extensions/Newsletter	master	+15 -2

Customize query in gerrit

Related Objects

Mentioned In: T111711: Add a way to subscribe from Special:Newsletters

Event Timeline

Glaisher created this task.Oct 19 2015, 3:30 PM

Glaisher raised the priority of this task from to Needs Triage.

Glaisher updated the task description. (Show Details)

Glaisher added a project: MediaWiki-extensions-Newsletter.

Glaisher subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2015, 3:30 PM

Glaisher mentioned this in T111711: Add a way to subscribe from Special:Newsletters.Oct 19 2015, 3:35 PM

Qgil triaged this task as Low priority.Oct 22 2015, 10:47 AM

Qgil moved this task from Backlog to Technical review on the MediaWiki-extensions-Newsletter board.

Qgil subscribed.

@Glaisher: Possible Google-Code-In-2015 task ?

In T115874#1855420, @01tonythomas wrote:

@Glaisher: Possible Google-Code-In-2015 task ?

Yes. This should be pretty easy. https://phabricator.wikimedia.org/diffusion/ENLT/browse/master/modules/ext.newsletter.js. doAPIRequest() returns a Promise object so we just need to add .fail() handling code here.

https://codein.withgoogle.com/dashboard/tasks/5526685684334592/

Change 259655 had a related patch set uploaded (by PranavK):
Handle errors when attempting to unsubscribe on Special:Newsletters

https://gerrit.wikimedia.org/r/259655

gerritbot added a project: Patch-For-Review.Dec 17 2015, 11:26 AM

Glaisher assigned this task to Pranavmk98.Dec 17 2015, 12:32 PM

Change 259655 merged by jenkins-bot:
Handle errors when attempting to subscribe/unsubscribe on Special:Newsletters