Page MenuHomePhabricator
Create Task
Maniphest T1165

Polish : Mobile experimental mode search header height is inconsistent
Closed, ResolvedPublic
Actions

Description

Screenshot_2014-11-07_23.59.19.png (300×792 px, 52 KB)

Visual diff shows bottom rule offset

Details

SubjectRepoBranchLines +/-
Avoid SearchOverlay input driftmediawiki/extensions/MobileFrontendmaster+22 -11
Customize query in gerrit

Related Objects

Event Timeline

• Jaredzimmerman-WMF created this task.Nov 8 2014, 8:00 AM
• Jaredzimmerman-WMF raised the priority of this task from to Needs Triage.
• Jaredzimmerman-WMF updated the task description. (Show Details)
• Jaredzimmerman-WMF changed Security from none to None.
• Jaredzimmerman-WMF subscribed.
Qgil triaged this task as Lowest priority.Nov 8 2014, 9:41 AM
• Jaredzimmerman-WMF added a project: Wikimedia-Design.Nov 8 2014, 7:18 PM
• Jaredzimmerman-WMF added a project: Web-Team-Backlog.Nov 24 2014, 5:23 AM
• Jaredzimmerman-WMF moved this task from Incoming to Triaged on the Wikimedia-Design board.Nov 24 2014, 11:22 PM
Aklapper added a project: good first task.Dec 2 2014, 12:37 PM
Jdlrobson moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Dec 5 2014, 7:21 PM
Jdlrobson subscribed.Dec 5 2014, 9:40 PM

I think this was due to the icons. I think this might be fixed now. Jared can you verify on beta labs? If not, could you elaborate a bit more?

Jdlrobson moved this task from 2015-16 Q4 to Epics/Goals on the Web-Team-Backlog board.Dec 5 2014, 9:40 PM
Jdlrobson moved this task from Epics/Goals to Upcoming on the Web-Team-Backlog board.
• Jaredzimmerman-WMF added a comment.Dec 5 2014, 10:50 PM

Screenshot_2014-12-05_14.49.45.png (172×754 px, 21 KB)
it is now worse, so, the opposite of fixed.

Jdlrobson moved this task from Upcoming to 2015-16 Q4 on the Web-Team-Backlog board.Dec 31 2014, 1:35 AM

It's maybe a pixel off now on beta labs. The issue in your image is something else.

• Jaredzimmerman-WMF added a comment.Jan 5 2015, 9:13 PM

why is it still a pixel off?

Jdlrobson added a comment.Jan 5 2015, 9:32 PM

I don't know hence why bug is still open - someone should fix it ;-)

gerritbot added a project: Patch-For-Review.Jan 16 2015, 5:59 PM
gerritbot subscribed.

Change 185467 had a related patch set uploaded (by Phuedx):
Avoid SearchOverlay input drift

https://gerrit.wikimedia.org/r/185467

Patch-For-Review

phuedx moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.Jan 16 2015, 5:59 PM
gerritbot added a comment.Jan 16 2015, 6:32 PM

Change 185467 merged by jenkins-bot:
Avoid SearchOverlay input drift

https://gerrit.wikimedia.org/r/185467

phuedx mentioned this in rEMFR798df69bd6e4: Avoid SearchOverlay input drift.Jan 16 2015, 6:33 PM
Jdlrobson closed this task as Resolved.Jan 16 2015, 6:39 PM
Jdlrobson claimed this task.
phuedx mentioned this in rMEXT29b083978535: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:24 AM
kaldari mentioned this in T95626: When I tap search and start typing, the first few characters get lost..Apr 17 2015, 9:47 PM
• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:28 AM
Restricted Application added a project: Design. · View Herald TranscriptMar 7 2018, 4:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL