Page MenuHomePhabricator

Search results are no longer in correct order.
Closed, ResolvedPublic

Assigned To
Authored By
Mhurd
Oct 29 2015, 12:08 AM
Referenced Files
F2912176: IMG_0056.PNG
Nov 3 2015, 8:48 PM
F2898656: Screen Shot 2015-10-30 at 4.01.20 PM.png
Oct 30 2015, 11:07 PM
F2898661: IMG_0043.PNG
Oct 30 2015, 11:07 PM
F2898659: IMG_0045.PNG
Oct 30 2015, 11:07 PM
F2888175: Screen Shot 2015-10-28 at 5.05.55 PM.png
Oct 29 2015, 12:16 AM
F2888171: Screen Shot 2015-10-28 at 5.13.53 PM.png
Oct 29 2015, 12:14 AM
F2888122: Screen Shot 2015-10-28 at 5.05.55 PM.png
Oct 29 2015, 12:08 AM
F2888131: Screen Shot 2015-10-28 at 5.06.55 PM.png
Oct 29 2015, 12:08 AM

Description

Pre-regression:

Screen Shot 2015-10-28 at 5.13.53 PM.png (1×974 px, 371 KB)

Present regression:

Screen Shot 2015-10-28 at 5.06.55 PM.png (1×974 px, 312 KB)

Event Timeline

Mhurd raised the priority of this task from to Needs Triage.
Mhurd updated the task description. (Show Details)
Mhurd subscribed.
Mhurd set Security to None.
Mhurd updated the task description. (Show Details)
Mhurd updated the task description. (Show Details)

It looks like maybe we forgot this:

https://github.com/wikimedia/wikipedia-ios/pull/206/files#diff-1499a5c5ab7425decad095a89fb50ac9L226

Have to sort the search results based on this index. Known quirk of the search api. (can't remember if this index is only for prefix...)

Which versions the Pre-regression and Present regression screenshots are from?

The Pre-regression sort order is the only correct one?

I see:

4.1.7.171

IMG_0045.PNG (1×640 px, 247 KB)

5.0.0.454

IMG_0043.PNG (1×640 px, 191 KB)

wiki

Screen Shot 2015-10-30 at 4.01.20 PM.png (710×793 px, 192 KB)

Checked with 5.0.0.465 on iPhone 5 iOS 9.02

The Search results order is back to pre-regression.

IMG_0056.PNG (1×640 px, 175 KB)

JMinor subscribed.

Argh as of 501 we're re-regressed. I am closing this as their is a new high priority ticket for this second time around...