Page MenuHomePhabricator
Create Task
Maniphest T117023

Auto-generated infopages on Incubator incorrectly link to the current page for Wikipedia
Closed, ResolvedPublicBUG REPORT
Actions

Description

When visiting an infopage of a test wiki that has not been manually created, the link to Wikipedia points to the current page, when instead it should point to the URL of the Wikipedia.

For instance:

To illustrate, for the case of the Bulgarian Wikinews, the logo for Wikipedia should bring me to bg.wikipedia.org, but instead it brings me back to the same page.

Hence, there seems to be an issue with the way the extension handles Wikipedias and with databases that ends with the suffix "wiki". This affects existing Wikipedias and also uses the incorrect logo.

Details

SubjectRepoBranchLines +/-
Refactor and consolidate configmediawiki/extensions/WikimediaIncubatormaster+117 -73
Customize query in gerrit

Related Objects

Event Timeline

Hydriz created this task.Oct 29 2015, 6:58 AM
Hydriz raised the priority of this task from to Medium.
Hydriz updated the task description. (Show Details)
Hydriz added a project: MediaWiki-extensions-WikimediaIncubator.
Hydriz subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2015, 6:58 AM
StevenJ81 subscribed.Dec 20 2016, 4:04 PM

Additionally: When the test wiki involved is a Wikipedia, and the Wikipedia already exists, the link to the Wikipedia does not show up explicitly on the infopage.

For instance:

StevenJ81 added a comment.Feb 16 2017, 10:50 PM

I'd like to request that this item be pushed up to become the next item on the Incubator workboard to be pushed up. This is really interfering with navigation on Incubator, or alternatively requires root pages to be created when tests are empty. Either way, this really gets in the way. Thanks.

Hydriz added a project: User-Hydriz.Feb 16 2017, 11:30 PM

I will have a look at this and see what I can do.

Hydriz added a comment.Apr 7 2017, 3:40 PM

I added https://gerrit.wikimedia.org/r/#/c/347010/ to resolve this issue. I suspect that this bug occurs as the extension is unable to retrieve any of the Wikipedia-related settings due to changes in the wmf-config code. This simple change should be able to solve this issue.

Hydriz moved this task from Backlog to Blocked on the MediaWiki-extensions-WikimediaIncubator board.Apr 8 2017, 1:52 PM
StevenJ81 added a comment.Apr 13 2017, 3:56 PM

I'm assuming this was not deployed yet (since its status is "blocked" and I see no changes on Incubator yet). Is that right?

Hydriz added a comment.Apr 14 2017, 12:11 AM

That's correct. The patch has not been merged and deployed yet.

Hydriz added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 7:07 AM

The patch was merged, keeping this task open until the patch is deployed.

Hydriz merged a task: T111600: Message infopage-status-beforeincubator has broken link.Nov 28 2018, 3:16 PM
Hydriz merged a task: T117024: Afar test wikis on Incubator incorrectly shows the Wikimedia logo for Wikipedia.
Hydriz added a subscriber: Krinkle.
Hydriz merged a task: T126827: When viewing pages for non-Incubator pages on Incubator, the link to the page on the new wiki is broken .Nov 28 2018, 3:19 PM
Hydriz merged a task: T162518: Special:SearchWiki is broken for existing Wikipedias.
Hydriz added subscribers: MF-Warburg, jeremyb, Benoit_Rochon and 3 others.
Hydriz added a subscriber: gerritbot.
Hydriz removed a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 28 2018, 3:22 PM
Hydriz updated the task description. (Show Details)

This fix is not trivial. The original patch has been reverted in https://gerrit.wikimedia.org/r/#/c/476278/ until further testing can be done.

Hydriz moved this task from Blocked to In progress on the MediaWiki-extensions-WikimediaIncubator board.Nov 28 2018, 3:24 PM
Stashbot subscribed.Nov 28 2018, 4:54 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-28T16:54:47Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/WikimediaIncubator/extension.json: [[gerrit:476304|Revert "Replace wiki with wikipedia as wmf-config has been updated"]] T117023 (duration: 00m 54s)

MF-Warburg added a comment.Sep 26 2019, 12:21 PM

Can someone give this some attention? Can there be a workaround as I suggested at T126827#3450937 2 years ago?

Nintendofan885 subscribed.Jan 3 2021, 11:15 PM
Krinkle unsubscribed.Jan 5 2021, 12:51 AM
Aklapper renamed this task from Auto-generated infopages incorrectly links to the current page for Wikipedia to Auto-generated infopages on Incubator incorrectly link to the current page for Wikipedia.Feb 21 2021, 12:57 PM
jhsoby subscribed.Feb 22 2022, 10:24 AM
jhsoby moved this task from In progress to Bugs on the MediaWiki-extensions-WikimediaIncubator board.Feb 23 2022, 8:57 AM
gerritbot added a comment.May 22 2022, 12:03 AM

Change 794768 had a related patch set uploaded (by Jon Harald Søby; author: Jon Harald Søby):

[mediawiki/extensions/WikimediaIncubator@master] Use 'wikipedia' instead of 'wiki' for $wgConf->get()

https://gerrit.wikimedia.org/r/794768

gerritbot added a project: Patch-For-Review.May 22 2022, 12:03 AM
jhsoby changed the subtype of this task from "Task" to "Bug Report".May 24 2022, 5:54 PM
gerritbot added a comment.Aug 20 2022, 8:38 PM

Change 794768 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Refactor and consolidate config

https://gerrit.wikimedia.org/r/794768

Maintenance_bot removed a project: Patch-For-Review.Aug 20 2022, 9:31 PM
jhsoby closed this task as Resolved.Aug 21 2022, 12:13 AM
jhsoby claimed this task.

Fixed; confirmed in Beta Incubator, will be deployed to the real Incubator next week.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL